From: Bryan O'Donoghue <bod@kernel.org>
To: Atanas Filipov <atanas.filipov@oss.qualcomm.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Kapatrala Syed <akapatra@quicinc.com>,
Hariram Purushothaman <hariramp@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Gjorgji Rosikopulos <grosikop@quicinc.com>,
afilipov@quicinc.com
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] media: dt-bindings: qcom: add JPEG encoder binding
Date: Sat, 16 May 2026 16:51:05 +0100 [thread overview]
Message-ID: <f4159f41-8a06-40a6-919c-5e16314b1732@kernel.org> (raw)
In-Reply-To: <20260515-qcom-jpeg-v4l2-v1-1-f38c2e1b3555@oss.qualcomm.com>
On 15/05/2026 12:46, Atanas Filipov wrote:
> +properties:
> + compatible:
> + items:
> + - enum:
> + - qcom,sc7180-jenc
> + - qcom,sm8250-jenc
> + - qcom,sm7325-jenc
> + - qcom,sc7280-jenc
> + - qcom,qcm6490-jenc
> + - qcom,sm8550-jenc
Per my previous feedback.
Please only list the items you are also providing in the DTS to be verified.
For example if this driver works on sm8250 there should be an enabling
patch for the DTS to that effect so that it can be verified.
Right now I believe all you are asserting in this way is qcm6490, so I
advise very strongly to either add the missing elements or just drop
what's not shown to be supported in your submission.
---
bod
next prev parent reply other threads:[~2026-05-16 15:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 11:46 [PATCH 0/3] Subject: [PATCH 0/3] media: qcom: Add Qualcomm JPEG encoder driver Atanas Filipov
2026-05-15 11:46 ` [PATCH 1/3] media: dt-bindings: qcom: add JPEG encoder binding Atanas Filipov
2026-05-15 12:13 ` Dmitry Baryshkov
2026-05-15 12:16 ` Krzysztof Kozlowski
2026-05-16 2:30 ` Rob Herring (Arm)
2026-05-16 15:47 ` Bryan O'Donoghue
2026-05-16 15:51 ` Bryan O'Donoghue [this message]
2026-05-16 20:16 ` Krzysztof Kozlowski
2026-05-17 10:31 ` Bryan O'Donoghue
2026-05-15 11:47 ` [PATCH 2/3] qcom: media: jpeg: Add Qualcomm JPEG V4L2 encoder Atanas Filipov
2026-05-15 12:21 ` Krzysztof Kozlowski
[not found] ` <SA1PR02MB11289FA5C2A01466B49C62D4BDD042@SA1PR02MB11289.namprd02.prod.outlook.com>
2026-05-15 12:29 ` Krzysztof Kozlowski
2026-05-15 13:28 ` Dmitry Baryshkov
2026-05-15 13:50 ` Nicolas Dufresne
2026-05-15 16:27 ` Bryan O'Donoghue
2026-05-15 11:47 ` [PATCH 3/3] arm64: qcom: dts: qcm6490: Add JPEG encoder DT properties Atanas Filipov
2026-05-15 12:16 ` Dmitry Baryshkov
2026-05-15 12:17 ` Krzysztof Kozlowski
2026-05-16 15:45 ` Bryan O'Donoghue
2026-05-18 7:53 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4159f41-8a06-40a6-919c-5e16314b1732@kernel.org \
--to=bod@kernel.org \
--cc=afilipov@quicinc.com \
--cc=akapatra@quicinc.com \
--cc=andersson@kernel.org \
--cc=atanas.filipov@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=grosikop@quicinc.com \
--cc=hariramp@quicinc.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®