From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E538C47082 for ; Tue, 8 Jun 2021 15:41:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 263786128E for ; Tue, 8 Jun 2021 15:41:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232702AbhFHPnD (ORCPT ); Tue, 8 Jun 2021 11:43:03 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:22168 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232536AbhFHPm5 (ORCPT ); Tue, 8 Jun 2021 11:42:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623166864; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ORZc1zixp8oUuIUPVE92AjT1Etx12X1YTrPl2rXFZL0=; b=WIBbZbQSZVeRbBPrQ0vlcuqOrikLTznH3dQGgQRkFLyQjEoPej+6vaPOVUArAs32/O9BV5 hhVXP8lBVdT+3H097n4v3vwd4dXQ37pEMyE8dhiVhEJbw8AWtzjrmbuB1aEGi66zYcMuri q69ayyhet+H+LK9wJKJWaWHX4T9E9mw= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-240-naxqAGzjOKOOJNNb7sGoBw-1; Tue, 08 Jun 2021 11:40:39 -0400 X-MC-Unique: naxqAGzjOKOOJNNb7sGoBw-1 Received: by mail-wr1-f70.google.com with SMTP id t14-20020adfe44e0000b029011851efa802so9559955wrm.11 for ; Tue, 08 Jun 2021 08:40:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=ORZc1zixp8oUuIUPVE92AjT1Etx12X1YTrPl2rXFZL0=; b=hPbjshMC2vjm2Fr2y2CeDJKnO6Xpz9vu4OaFnTJOSkd4/brAp1Pq4prjEnG4/7LSAh pRnCFchV+A3INYweK6gIHtTz99QE0Tsv7GhwxxYfz4yNzIPCjxNWztQ7kvD6b5lUDDcC 29OOqbTr3w+Ah+ty/ng2sYbdAZT73kjHE9+zOrnXM2AgUvdOiSg0GvOG2iTohrKzlJ/2 Rk6PCeAhc5Sob5bDMmj968nqZB+ugStQDzDTSQxQtoh4cyArLiSWVx/UjT3A7aCfNmuR qtLqIrGAB4jq3P/RqFoBkFXhc2hbyxEvXt9gaW0uZRK+Xz4Of+pRJn2bUZKhICzlkP/q tiNg== X-Gm-Message-State: AOAM531DfnX7P48vRdK8OW7Xyt83i2tEJABYtFDv0NVcoA5hvLS3MYFT 6mS1H/cD8F5rusl/fCC6weFYSXq5Ir0CA2ww7cbKZ/NDqZiwVmzzckQ2ChdhoANztCKtX9+jOMW AeSPbdHd01BBQfTvS1vAHS4uv X-Received: by 2002:adf:e591:: with SMTP id l17mr18369840wrm.46.1623166838506; Tue, 08 Jun 2021 08:40:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxk0Z/tAFwqxqMSIUyFBJY4g4TjfpttrnmxkRMh9DwuD2UbZhmt7nHdIZyip6VFTSh9Dm7Tig== X-Received: by 2002:adf:e591:: with SMTP id l17mr18369820wrm.46.1623166838358; Tue, 08 Jun 2021 08:40:38 -0700 (PDT) Received: from dresden.str.redhat.com ([2a02:908:1e46:160:b272:8083:d5:bc7d]) by smtp.gmail.com with ESMTPSA id u7sm17307067wrt.18.2021.06.08.08.40.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Jun 2021 08:40:38 -0700 (PDT) Subject: Re: [PATCH v2 5/7] fuse: Call vfs_get_tree() for submounts To: Greg Kurz , Miklos Szeredi Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, virtio-fs@redhat.com, Vivek Goyal References: <20210604161156.408496-1-groug@kaod.org> <20210604161156.408496-6-groug@kaod.org> From: Max Reitz Message-ID: Date: Tue, 8 Jun 2021 17:40:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210604161156.408496-6-groug@kaod.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04.06.21 18:11, Greg Kurz wrote: > We recently fixed an infinite loop by setting the SB_BORN flag on > submounts along with the write barrier needed by super_cache_count(). > This is the job of vfs_get_tree() and FUSE shouldn't have to care > about the barrier at all. > > Split out some code from fuse_dentry_automount() to the dedicated > fuse_get_tree_submount() handler for submounts and call vfs_get_tree(). > > Signed-off-by: Greg Kurz > --- > fs/fuse/dir.c | 53 +++++-------------------------------------------- > fs/fuse/inode.c | 36 +++++++++++++++++++++++++++++++++ > 2 files changed, 41 insertions(+), 48 deletions(-) Reviewed-by: Max Reitz