From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6871AC48BD5 for ; Tue, 25 Jun 2019 08:57:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 479A520644 for ; Tue, 25 Jun 2019 08:57:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731227AbfFYI5e (ORCPT ); Tue, 25 Jun 2019 04:57:34 -0400 Received: from s3.sipsolutions.net ([144.76.43.62]:54868 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730741AbfFYI5d (ORCPT ); Tue, 25 Jun 2019 04:57:33 -0400 Received: by sipsolutions.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1hfhGa-0004ub-Do; Tue, 25 Jun 2019 10:57:28 +0200 Message-ID: Subject: Re: nl80211 wlcore regression in next From: Johannes Berg To: Arend Van Spriel , Tony Lindgren Cc: Kalle Valo , Eyal Reizer , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Date: Tue, 25 Jun 2019 10:57:27 +0200 In-Reply-To: (sfid-20190625_105642_518599_389D67F7) References: <20190625073837.GG5447@atomide.com> <2570f4087d6e3356df34635a0380ec8ce06c9159.camel@sipsolutions.net> <20190625080019.GH5447@atomide.com> <7f74087fef1e554e0aeb82a6cec4113727487928.camel@sipsolutions.net> (sfid-20190625_105642_518599_389D67F7) Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-3.fc28) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arend, > By chance noticed the patch included brcmfmac. So I tried, but I get > compile issue below. It is because ERR_PTR really is an inline function > so that is not working. So also need to patch that. I left the extra > braces around the error code although not strictly necessary. D'oh. I'll check that out, thanks for the report/patch! johannes