From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06565C7EE2D for ; Thu, 25 May 2023 03:51:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236418AbjEYDvL (ORCPT ); Wed, 24 May 2023 23:51:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237076AbjEYDu7 (ORCPT ); Wed, 24 May 2023 23:50:59 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id AD7FBE7; Wed, 24 May 2023 20:50:57 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8EEED1042; Wed, 24 May 2023 20:51:42 -0700 (PDT) Received: from [10.162.43.6] (unknown [10.162.43.6]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E9CB93F6C4; Wed, 24 May 2023 20:50:50 -0700 (PDT) Message-ID: Date: Thu, 25 May 2023 09:20:47 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v4 29/36] mm: Remove page_mapping_file() Content-Language: en-US To: "Matthew Wilcox (Oracle)" , linux-arch@vger.kernel.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230315051444.3229621-1-willy@infradead.org> <20230315051444.3229621-30-willy@infradead.org> From: Anshuman Khandual In-Reply-To: <20230315051444.3229621-30-willy@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/15/23 10:44, Matthew Wilcox (Oracle) wrote: > This function has no more users. On v6.4-rc3, there are still some users. Am I looking into a wrong tree/branch/tag ? ~/workplace/linux$ git grep page_mapping_file arch/arc/mm/cache.c: mapping = page_mapping_file(page); arch/arm/mm/copypage-v4mc.c: __flush_dcache_page(page_mapping_file(from), from); arch/arm/mm/copypage-v6.c: __flush_dcache_page(page_mapping_file(from), from); arch/arm/mm/copypage-xscale.c: __flush_dcache_page(page_mapping_file(from), from); arch/arm/mm/fault-armv.c: mapping = page_mapping_file(page); arch/arm/mm/flush.c: mapping = page_mapping_file(page); arch/arm/mm/flush.c: mapping = page_mapping_file(page); arch/csky/abiv1/cacheflush.c: mapping = page_mapping_file(page); arch/csky/abiv1/cacheflush.c: if (page_mapping_file(page)) { arch/mips/mm/cache.c: struct address_space *mapping = page_mapping_file(page); arch/nios2/mm/cacheflush.c: mapping = page_mapping_file(page); arch/nios2/mm/cacheflush.c: mapping = page_mapping_file(page); arch/parisc/kernel/cache.c: if (page_mapping_file(page) && arch/parisc/kernel/cache.c: struct address_space *mapping = page_mapping_file(page); arch/sh/mm/cache-sh4.c: struct address_space *mapping = page_mapping_file(page); arch/sh/mm/cache-sh7705.c: struct address_space *mapping = page_mapping_file(page); arch/sparc/kernel/smp_64.c: page_mapping_file(page) != NULL)); arch/sparc/kernel/smp_64.c: if (page_mapping_file(page) != NULL && arch/sparc/kernel/smp_64.c: if (page_mapping_file(page) != NULL) arch/sparc/kernel/smp_64.c: if (page_mapping_file(page) != NULL) arch/sparc/mm/init_64.c: page_mapping_file(page) != NULL)); arch/sparc/mm/init_64.c: if (page_mapping_file(page) != NULL && arch/sparc/mm/init_64.c: mapping = page_mapping_file(page); arch/sparc/mm/tlb.c: mapping = page_mapping_file(page); arch/xtensa/mm/cache.c: struct address_space *mapping = page_mapping_file(page); > > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/linux/pagemap.h | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h > index e56c2023aa0e..a87113055b9c 100644 > --- a/include/linux/pagemap.h > +++ b/include/linux/pagemap.h > @@ -394,14 +394,6 @@ static inline struct address_space *page_file_mapping(struct page *page) > return folio_file_mapping(page_folio(page)); > } > > -/* > - * For file cache pages, return the address_space, otherwise return NULL > - */ > -static inline struct address_space *page_mapping_file(struct page *page) > -{ > - return folio_flush_mapping(page_folio(page)); > -} > - > /** > * folio_inode - Get the host inode for this folio. > * @folio: The folio.