mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Julian Braha <julianbraha@gmail.com>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Dmitry Voytik <voytikd@gmail.com>,
	Nicolas Schier <nsc@kernel.org>,
	Nicolas Schier <n.schier@fritz.com>,
	linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH v8] scripts/config: honor $KBUILD_OUTPUT by default
Date: Wed, 18 Nov 2026 11:14:59 +0000	[thread overview]
Message-ID: <f430727b-0ae4-4210-80d2-cef29109a863@gmail.com> (raw)
In-Reply-To: <20261118081025.GA671584@ax162>


[-- Attachment #1.1: Type: text/plain, Size: 953 bytes --]

On 11/18/26 08:10, Nathan Chancellor wrote:
> On Tue, Nov 17, 2026 at 07:25:17PM +0000, Julian Braha wrote:
>> On 11/17/26 13:25, Dmitry Voytik wrote:
>>> +# If no '--file' was specified, use KBUILD_OUTPUT as the base if it exists
>>> +if [[ "$FN" = ".config" && -n "$KBUILD_OUTPUT" ]]; then
>> Right so this will give different results with:
>>     '--file .config'
>> and:
>>     '--file ./.config'
>>
>> but maybe that was intentional -- i.e. we're assuming a user passing
>> '.config' intends it to be '$KBUILD_OUTPUT/.config' while a user passing
>> './.config' would intend CWD/.config?
> It was intentional since I had figured they were passing the default
> value so they should get the default behavior. Maybe it would be better
> to only do this when no '--file' value was provided period though to
> avoid some unexpected behavior?

All good, I think it's reasonable. Just wanted to confirm the intention

- Julian Braha

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

      reply	other threads:[~2026-11-18 11:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 13:25 Dmitry Voytik
2026-11-17 19:25 ` Julian Braha
2026-11-18  8:10   ` Nathan Chancellor
2026-11-18 11:14     ` Julian Braha [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f430727b-0ae4-4210-80d2-cef29109a863@gmail.com \
    --to=julianbraha@gmail.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=n.schier@fritz.com \
    --cc=nathan@kernel.org \
    --cc=nsc@kernel.org \
    --cc=voytikd@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®