From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBC9833CEAA for ; Tue, 17 Mar 2026 09:27:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773739647; cv=none; b=mbMADxbsJElWmUK1jY94pGVKoXDDgp8lspg+MRquR6CAS8eKdNj8zwqf+apbKBPdkS+p4SI5wG+Xp3mBh26v4fdWoBJNDIWby9/EKtZpb9+BMVlJachQKFcvQ2MSbfULvkIZ6fgd04D3elh2XoX++NIF+uZoMNK8twY+QDaQA7I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773739647; c=relaxed/simple; bh=PqEXds4GrlgZ3n52VaQfUbW8LHZn+0T/t/toWPk5DGE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Jy8DrFfdGNdZxXx6WTHIsjnIfVoVHOlAfKfxHuSVJaECT7QXK+pAnlO7by74UcDtS2b9TrPPUobqIId2O4vRJmZDFtLjVXCjv+r5JJXPieJwW2+4ZlwPdfcaLQ424uWCoERPCXdnBAHz2ATjJByDZwMyx2LGvibM/QB5wb9kEwg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=AuOBz6uW; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Yeusu0S6; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="AuOBz6uW"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Yeusu0S6" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62H94ddB4023448 for ; Tue, 17 Mar 2026 09:27:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= VsUDLAst7GCYzE791DlmXpqcmyhgQ6vfLLVyLS8iSTk=; b=AuOBz6uWd9ill70Q 46wqbr2fS/zJP2yLzkN7fDs3xLKvHI6NXUfPqWkwFxlfz4Hm7QI1iY3cgwnGurV6 +frQ5nwVv6zK8l2VLyH8fxGcIOUqwaIffATyxrFJ0FiZ2P02wYWQufHNIfSk7UKT aEVBRriPJ6DCqzR94AKX29Y+cQ4AOMKLm1FQiVEFV3Aq7147B/ysgayU1tB7GXLl N2EoBe554fTqYORXjtDcPZo5l91m6wW0ccqO1nWKJzPOeczJj5EexYfzg3fvS1No XyJZUelDKhY0ypCkXiFzKoSXiAvp75FrRF8oGO+DLZ8jUffOz/YKv0F9QvU+24aj p+lu1A== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cxn3fk374-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 17 Mar 2026 09:27:24 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2aec784479cso335729845ad.3 for ; Tue, 17 Mar 2026 02:27:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773739644; x=1774344444; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VsUDLAst7GCYzE791DlmXpqcmyhgQ6vfLLVyLS8iSTk=; b=Yeusu0S606MaraiVAAGPK3UxoNCpCGzfOB4gaogeVoJxkBVRhTJIxFS15sbcS8VH5C wPMzYnIWMdxWxCE/+cNljVooGs3bpHiLuPqhkLy2SeqQJjdMcqyeb3sCI7MOXd+6qTAo AUfGwZgpovUQPLCnaVzmgFeagLCiDkP15aacV34HMA5EQKVuNDZY78GQ8CaTN4vTUJv1 DmuALXAfnb1/GlRKR8Hh1WTgV+hEF6D5BfZaVuXvSnfOJt0CXaSTVjFbrfmwFrinFf9N pNiBwxfKWHxKFz+8iJjBML0DcEp5yAgB0vIrNc6TQqQzFUfNUwfp3HLFBTMs8d78KSGa SOFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773739644; x=1774344444; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VsUDLAst7GCYzE791DlmXpqcmyhgQ6vfLLVyLS8iSTk=; b=ia3K3PTWf3/uJTf0rbDHvbmU91X3kIwC05xqIndYWl4G+hMo4gP+1/rtntbh7FSgI+ PgSq+OS5Q8tIOk3xMvPAi/n143rGQVMac1Vj6T/dm6CGPkvydQAQAHHyFT13NplpEfVN R4GXDA38HAjJh2l8XT9REhJWzTKkKvxJGED4CvuGsk3JjpLqy5VCm9RyTRT0r0gF4Br3 zMl/YQJRhErfzU7Sb+ZcrzP3knlkdcpjX1laJnytfHU2v+iXsT60Sw3LQ+wUKoJsc+ap Le4UN5DqZGgbJYiKyMeLFPVz14DRqq7HIbgkOGQb9UVz/EcTOm5L1fB1f04arcQz21dI jiSQ== X-Forwarded-Encrypted: i=1; AJvYcCUBNJ4gC+eW2kL24YvhBl5ImatvqWoX46upLx1L/b/ICdeMNneZ/e8Rb3QHtVwE4zoEYaPkwUlVSQmhuCs=@vger.kernel.org X-Gm-Message-State: AOJu0YxHtFAD8IJxl1NRDGUevueVKOLuh+8lMu8pwR6GTxzELfWSO8TO bHIDdmTTBauybIgTBHf2Bhb+6XoO00D/ZizzUm5xmtdbLZcLjOxJ23U+dH/AQ2pe+RmAzFs8B93 KXE1BTwsrgXgNn+lXp6DNX9bohI96vuz/ziNfKvMmHPM6BtsmuThbNI6L/walJrm/lW4= X-Gm-Gg: ATEYQzziQBxPC4uOmDC+zV7/eSdN3qqgoj9tvVk0xf1aJ0UkFRqVN8URMRgprLvTsQa YOaV2xzCKRDSWowtRr4WchRbPsgwJKCgfMAeVXBF27753rkY8iv3kLUMysc1LMgAzJZ8tgELRc8 39xlqTOQsIF6+ncunS5AH5Z4M9g9qudaRCtXneM04QrZ6lFNoATr+y9RLcWvS9v6zKVYTm/TrYd nW2ORVU56uIa2iluIha40hS4pE/nlmca8R9A0YJOlsTcCc3eX+t306GTM0d+MXjrRz3bY7LLSxl +qU15WkpOzraM/Kxby0ylxFQMFDL9hTkzftwjz+ibB+KNzevyWx9P50PZyUY9bUc9jVgpIMlN9i 6a8uMT+JNxByUDO6VNIh0dXxoEBGt7QmmofIxYfx9XKy5t7VyNbQ= X-Received: by 2002:a17:902:d505:b0:2ae:ced7:4650 with SMTP id d9443c01a7336-2aeced7510fmr163910395ad.24.1773739643819; Tue, 17 Mar 2026 02:27:23 -0700 (PDT) X-Received: by 2002:a17:902:d505:b0:2ae:ced7:4650 with SMTP id d9443c01a7336-2aeced7510fmr163910045ad.24.1773739643365; Tue, 17 Mar 2026 02:27:23 -0700 (PDT) Received: from [10.217.223.121] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b0659a90fesm19021845ad.45.2026.03.17.02.27.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Mar 2026 02:27:23 -0700 (PDT) Message-ID: Date: Tue, 17 Mar 2026 14:57:18 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] arm64: dts: qcom: sm8250: Add inline crypto engine To: Alexander Koskovich , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov References: <20260309-sm8250-ice-v3-0-418bf5c5c042@pm.me> <20260309-sm8250-ice-v3-2-418bf5c5c042@pm.me> Content-Language: en-US From: Harshal Dev In-Reply-To: <20260309-sm8250-ice-v3-2-418bf5c5c042@pm.me> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=C5bkCAP+ c=1 sm=1 tr=0 ts=69b91e7c cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=LnETC1lSbQsXWPk8PCwA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-GUID: Qbe7OPDo4deNbNwtqB-HrKve9WI5fl9W X-Proofpoint-ORIG-GUID: Qbe7OPDo4deNbNwtqB-HrKve9WI5fl9W X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE3MDA4MyBTYWx0ZWRfX4rKPRt/Y0/18 hzuxTB+8Z0tiBj+DF7XUONjB1WFXhB4SBtLk4+UPA+Q41R0euPUAGO9Ukf0i3igD6ife3etd0y1 drbPtcozN7sohZVJdhnAS+8BFMYFITtLiq2E7Sy9cMRNqA4nP7B8PDPi+LqakZ8KxLDvOxhMj1q Y9ecc02S8g/zAbdocWz5IcdWPVpQRfqN+/I047uLDutC4ky6wQtWFikm8m1nMECPeCC6YMfvX7O AJdIgHsIThY7pNpGxSCPsB2KlXhsRx+b04UDf2Oil06yDM2H7+isdCWg/XXMftovYvw0QZpDFrf Lj4qOHPcs8MaEL/YPLtUyQxk7zZxNtEspGYQPuiBNPys8bUhAtWrI9JkhvcJH8Hx6chYGyT+tZE 6PRT9SxRppHKFPQXuYs4tUNcyUGEw4C3LBkAZheOgSOtOcwCwiEKNCRVPwmBmycN8TVYRqDvsKj oe9yz6fkjC9GafuZMEA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-17_01,2026-03-16_06,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 suspectscore=0 priorityscore=1501 spamscore=0 lowpriorityscore=0 clxscore=1015 malwarescore=0 impostorscore=0 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603170083 Hi Alexander, On 3/10/2026 8:42 AM, Alexander Koskovich wrote: > Add the ICE found on sm8250 and link it to the UFS node. > > qcom-ice 1d90000.crypto: Found QC Inline Crypto Engine (ICE) v3.1.81 > > Reviewed-by: Dmitry Baryshkov > Signed-off-by: Alexander Koskovich > --- > arch/arm64/boot/dts/qcom/sm8250.dtsi | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi > index c7dffa440074..b49007934278 100644 > --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi > @@ -2513,6 +2513,8 @@ ufs_mem_hc: ufshc@1d84000 { > > power-domains = <&gcc UFS_PHY_GDSC>; > > + qcom,ice = <&ice>; > + > iommus = <&apps_smmu 0x0e0 0>, <&apps_smmu 0x4e0 0>; > > clock-names = > @@ -2592,6 +2594,17 @@ ufs_mem_phy: phy@1d87000 { > status = "disabled"; > }; > > + ice: crypto@1d90000 { > + compatible = "qcom,sm8250-inline-crypto-engine", > + "qcom,inline-crypto-engine"; > + reg = <0 0x01d90000 0 0x8000>; > + clocks = <&gcc GCC_UFS_PHY_ICE_CORE_CLK>, > + <&gcc GCC_UFS_PHY_AHB_CLK>; > + clock-names = "ice_core_clk", > + "iface_clk"; As per comments on v2 of this patch, the clock names have been updated to 'core' and 'iface'. Please update the same here since your patch depends on this one: https://lore.kernel.org/all/20260317-qcom_ice_power_and_clk_vote-v3-1-53371dbabd6a@oss.qualcomm.com/ Regards, Harshal > + power-domains = <&gcc UFS_PHY_GDSC>; > + }; > + > cryptobam: dma-controller@1dc4000 { > compatible = "qcom,bam-v1.7.4", "qcom,bam-v1.7.0"; > reg = <0 0x01dc4000 0 0x24000>; >