From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D871C71156 for ; Tue, 1 Dec 2020 17:25:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 56179207FF for ; Tue, 1 Dec 2020 17:25:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404012AbgLARZa (ORCPT ); Tue, 1 Dec 2020 12:25:30 -0500 Received: from smtprelay0148.hostedemail.com ([216.40.44.148]:60596 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2391673AbgLARZ2 (ORCPT ); Tue, 1 Dec 2020 12:25:28 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id 07E5018224D8D; Tue, 1 Dec 2020 17:24:47 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: jump74_6009439273ac X-Filterd-Recvd-Size: 1893 Received: from XPS-9350.home (unknown [47.151.128.180]) (Authenticated sender: joe@perches.com) by omf03.hostedemail.com (Postfix) with ESMTPA; Tue, 1 Dec 2020 17:24:46 +0000 (UTC) Message-ID: Subject: Re: [PATCH v5] checkpatch: add fix and improve warning msg for Non-standard signature From: Joe Perches To: Aditya Srivastava Cc: lukas.bulwahn@gmail.com, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org Date: Tue, 01 Dec 2020 09:24:44 -0800 In-Reply-To: <20201201112931.11192-1-yashsri421@gmail.com> References: <20201201112931.11192-1-yashsri421@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2020-12-01 at 16:59 +0530, Aditya Srivastava wrote: > Currently, checkpatch.pl warns for BAD_SIGN_OFF on non-standard signature > styles. > > This warning occurs because of incorrect use of signature tags, > e.g. an evaluation on v4.13..v5.8 showed the use of following incorrect > signature tags, which may seem correct, but are not standard: I'm not a fan of this patch. There is already a "non-standard" signature warning for all of these cases since 2012, predating the range of this retrospective evaluation by over 5 years and yet these existing commits have been accepted. The value in actual standardization and effectively requiring specific signature style tags is quite low. Anyone that signed a thing a particular way should be free to sign the thing as they choose. Most of these warnings would also still be in the tree in the future in new patches as running checkpatch without it emitting a message of any type isn't a requirement nor should checkpatch use actually be required workflow.