From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f47.google.com (mail-dl1-f47.google.com [74.125.82.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4DBF2D780A for ; Mon, 19 Jan 2026 19:42:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768851729; cv=none; b=FVMihDc4AozyyLWn6ML1tzkfB+q1hnZi82VRVYfni0IPC8aqntTHf21vLVgmt+8VW8qSP41KJS4HZFymgyil32z6Z+memjii7rnWCKWqv4rTrFOjyBj8adMoh8Cg2CdbB16NSG8FfqCWLTMmRoNsg0mutkkczkHhuNU6gWRhuR4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768851729; c=relaxed/simple; bh=iZO2VBK0nImOZW9dN9Z9WYlUe8QYmg2zG5xkDa41XXY=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=IIics0PwJvKXhy2XOoTgZhIyWTYguEQItpyjGUi+Nb6jPsjjvq0Kzl7AP7DIkQNEEEdoiLHeJre9tp4b3e3RfcKXP9WegltnFtdZ1cmwfqyc7xD4hu4QZkK9BBi0qDr6+v86FwOBrDFDHY5OER7cs6q1lwHddv4GKFDSewKkvh4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ELTnFtq9; arc=none smtp.client-ip=74.125.82.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ELTnFtq9" Received: by mail-dl1-f47.google.com with SMTP id a92af1059eb24-1233b953bebso4698891c88.1 for ; Mon, 19 Jan 2026 11:42:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768851727; x=1769456527; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=eb9yz+SvKdaT36UoPu1hkjKyUKmj8Asls2elh6D0MXY=; b=ELTnFtq9vcI+NL8Vk0rQW1gW791J0zoxX7iOoVMuY0muU2+U2pyuJY1Rzy+sznLkfZ nOc5nygNckvNSPGSU4erbSwmfna07vMEjMDfJejyg8E6mNQrbIldv/I+27CpM85xVrN6 h1YjpDK11gLbDLSdD7QheadASOqutoYhk/K+7xWI98j8TI5L41qcLcjvdjDgKt4E5eQN Rr0ue62Apvi18zPyMW6dd9Im92ZS52N1yQhZ19zXRRZr8IE1BguIgXuRE1t6QmQJCVC0 WsVoF1dia4y20aYtANH5AxwIfPNMXXquyKiZ/LUvExub0jo9LDqSWAk4dAKljrA8huLq IdUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768851727; x=1769456527; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eb9yz+SvKdaT36UoPu1hkjKyUKmj8Asls2elh6D0MXY=; b=xPfiTsIcG3nnKjE9COBSvNEV42l5oguoCPuIwAoRbfk1z2FLpefEzfl+XQ/dvQBC3K /D3SGNOtRAp/PNmcsRR489TB+9KzovIKJv/TlZc3XCEFnrPGeb/7K0+jjWQBATKqLp1R W2RequKzsET3C9w28HsdbkMABK2y6Ovlf9UB1DSj4MVn1cPjbhyh38+ZnH9m+YE4ErRK D9WYBoqFNlgtx+NKyoZ9zetqtebJoByxorxLCfY5n3pz+PDHUeR+dT4uj8OGWHOnkcjA wWQ2oKVErVbf3R1cbsawkiLiFn95mHQ4AAZFK9xvKDxParQyZwwfHnZOA7uH1Po2ssVs 4Rew== X-Forwarded-Encrypted: i=1; AJvYcCVGBMfNIoFFYKFrwUJZNNH19d0hiTSHzH0ytD85Od+2IA3EaYSJ6o6jYD9JEbR0lI0vr1idCeFxIRUvYXY=@vger.kernel.org X-Gm-Message-State: AOJu0YxJTRKxoHbPtSlP4LDWGNVi/pm63k5vD3pv3CvQbGv+y4ZuUGAZ PQh7iRLjcqm4fI9nWW6B47JvK/pnLUQOoJuzbrO0EE7i0CoHKslCYo3T X-Gm-Gg: AY/fxX5WnnReGyb+0xSBh4LrdIUfrvNSLMalBjqQVqJyiij34OULb/gp78QFMy9qJ/U DkXtwWicMgDvhCJTJCNDlqT6EVWXAvJ0M0f6DDYkdr9OGi/BPpZ/RVx1WYF2qbqg/oO439y/D0e 3K0rxlW6j+KFU4zaW/5jS6kUO+7zFwzWwpvKxTTmuKvj9mp6MYQ02B3oR6IHlwY5TXGLAMQPnpc iRmru9jyZsN0cKKuU7V9wZnw1RK9yg2ZXomgsoxcGOHhd3l8aE5/J3zt94yXIZ7SIms0G5Y9+mm CqPuSI8Cj/H3RuUghvqP4Wp4iDQB8wExse50JTrREJNErJ0bdPSj+5QsV2OE3z2rB0b5X2JjLOX gYr1noluFVgDrmwW06tnYkF+YPNnd7IA0lZBaDiKEqBLmwCYCXM7q+TNS4S72ZqFRUt3QIQd2a9 Cvvz3FJ+suuni9xxWFE+qSfXpka4eCv9GWh7yCTonXo5q/MqyhkM+sDVslDkV6ZQaTDA== X-Received: by 2002:a05:7022:6606:b0:123:2d4f:ef1d with SMTP id a92af1059eb24-1244a73d37dmr10368106c88.30.1768851726861; Mon, 19 Jan 2026 11:42:06 -0800 (PST) Received: from ?IPv6:2a03:83e0:115c:1:4cd6:17bf:3333:255f? ([2620:10d:c090:500::aa81]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1244af22aaasm14952342c88.17.2026.01.19.11.42.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jan 2026 11:42:06 -0800 (PST) Message-ID: Subject: Re: [PATCH v2] bpf/verifier: optimize ID mapping reset in states_equal From: Eduard Zingerman To: Qiliang Yuan , andrii.nakryiko@gmail.com Cc: andrii@kernel.org, ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, haoluo@google.com, jolsa@kernel.org, kpsingh@kernel.org, linux-kernel@vger.kernel.org, martin.lau@linux.dev, sdf@fomichev.me, song@kernel.org, yonghong.song@linux.dev, yuanql9@chinatelecom.cn Date: Mon, 19 Jan 2026 11:42:04 -0800 In-Reply-To: <20260116090809.25290-1-realwujing@gmail.com> References: <20260116090809.25290-1-realwujing@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.2 (3.58.2-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Fri, 2026-01-16 at 17:08 +0800, Qiliang Yuan wrote: [...] > Metric | Baseline | Patched | Delta > ----------------|---------------|---------------|---------- > Iterations | 5710 | 5731 | +0.37% > Instructions | 1.714 T | 1.555 T | -9.28% > Inst/Iter | 300.2 M | 271.3 M | -9.63% > Cycles | 1.436 T | 1.335 T | -7.03% > Branches | 350.4 B | 311.9 B | -10.99% > Migrations | 25,977 | 23,524 | -9.44% >=20 > Test Command: > seq 1 2000000 | sudo perf stat -a -- \ > timeout 60s xargs -P $(nproc) -I {} ./veristat access_map_in_map.bpf.= o [...] As discussed in a separate thread, I don't think that system-wide profiling is a good fit here. When using perf stat for collecting pyperf180.bpf.o processing stats I don't see a big difference. Regardless of specific statistics, I think this change should be landed. =20 > Suggested-by: Eduard Zingerman Please remove this 'Suggested-by', you found this change yourself, Andrii suggested improving it further (this usually goes to a changelog). > Suggested-by: Andrii Nakryiko > Signed-off-by: Qiliang Yuan > --- Acked-by: Eduard Zingerman [...]