From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43484306B33 for ; Thu, 16 Oct 2025 14:32:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760625141; cv=none; b=iXDs1lBox0FUaWCUlG9VrLdSgeeE1dU+mj1oX7QFQsMEhUDWBJ4dHi2ufggKUHzYalfhMHHwNyqrvKSakACJZz8zJNho0rvil5+1C66xdusIIrz89PUF+lTxDUVjY3mwSTyH8b5SsABKClxeSy1UAXEGuAS3GQuqtWzzTGLiXVg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760625141; c=relaxed/simple; bh=oVgTTSWymuwNDXSjOLTCtJSxnTKy3SLVg9lJFZY+thI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=I8VD0MeJnPTd1U2IVKndZVscJSlmM1t5ZOTYySCbCx4wTXlosDKU8bAgHOnBxFGWrWGg6P2mKpuCofuOdwDDbBltVfr40yZLqGoSfqZxJiUVPiBcqRCnvBbr/KOWUvtVffZ9Lud7bLfBiu/8X5Hmoq5GmOYtz2wNSWWzjoyEU2E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NUgcKwKc; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NUgcKwKc" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-471066cfc2aso7576525e9.0 for ; Thu, 16 Oct 2025 07:32:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760625136; x=1761229936; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Bjgpgf1yen6+73wHP5NT0rnx9GIZYBxz/Xgqh4376MQ=; b=NUgcKwKcLwB68BgsghDNdkCn1Tk7wnt7AGDseY1BAjQauUw5SXw+2A9gaiYvNpdB4t x1DVC19GVYVm35v3gez4bSscKN0A4lpqEX217+V5R+YPauqq+YSuR6GUNhk8WxCRXMSv WsxN+HdXvLRQfUGpxEAU+/Aa0IqWlunCmBsXRrEfr+tTtCYAPMwIQfPzQPgSTVcQhyEH ld8/4kY2TaglSEWvnZZo+YI/UWVAakd7bLhWv/t/NoCw2PW53LM0iJRBlAQDeGFYjPiZ bx9IyXHNg4DFb19mqgBPBHY1ZhV9va8fsXmohGZAb1kVnsgH3fPboRv735ytdft2wZJH rABw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760625136; x=1761229936; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Bjgpgf1yen6+73wHP5NT0rnx9GIZYBxz/Xgqh4376MQ=; b=BtOSaOgpvmPMhgrOIA9l1+fgSTMDjkj6dXPWDrjvz6bvAdobR2JADsmEsfQ4oSR+MV ZhvnCkubzRRIAnA8vdtmarj0FqNJGktMIkRgJ/IXQ4QEp7wP5+UY3BZY8dsja+8Nj7uP YNBbHzipAbDuASk6F8tmj8XIsKzyzotTGkufaaIe6kieDrWlCb9hVYFxQr3TxaGnusly z1jkAC4Eb7HJNDj8SjAJTW5SFdbk2iA4MMHi6NCXVae0oyLIO/30m4uI0KQb+quXPK4w LZp/4H26l/KEoNf4OQYOeVgMcjpurLBdNl7fF7WqMCnV7+u7DysiLKGB7c9rr6CiqqA6 1Xpg== X-Forwarded-Encrypted: i=1; AJvYcCVLfmF8cLsMblchOAFhGTqAwnb2Ei74Y6u4tAGfIlE97xllCP/hkXBSzcmvWSVXZpskXYAMuz1whEFIdG0=@vger.kernel.org X-Gm-Message-State: AOJu0YyaAi1bQlLBULBhxU7wPBxbRGfpfsH1wJMrv2ksck9I330TQiEr 0zwldGrYAqtZC4JGcxLxIY1Sv+kghq/MRkI+47iMWwt9uhHoXRsIQSAv X-Gm-Gg: ASbGncsJg/KNBiaOfQrNzgJQjk3wIdcdid8AXn4V6gI5gu2cGluBkbDzt0CE9b6pSif paO2wI+Am3WqvLBZ4FeLKg42jzqaJjH6eu0amBS6V9sw26ynR6Np2OlgRQLwxGaGGogkNtoDz3E GyWJ6RiANelrlF/5Fr3uN+tSIwM6qGRXj431amHyg+CLpSMmDuY7HbT6HOBhSzGR9rN2jzzQ1Gq qsgSLIMWRZ7fRGhsTh/mYMljIq7ZkT7ZPIbatb+JIv8/mo8mCF6k9PXKa2xpCLADgGdnA9KoAU0 oVgf+GrT8GOxN3LbHXP8yn15cMsMGtzgTNTU0Npk7Zb16Y1+YLfItC599Y20a0fLWEdjIZnjIZ+ 8fgdugZcz9/e+53febKmGFG2aVgXuLQ/LmLy0Wk4MmBynd8OAyxyod+Z+o4FIKWx3GzRrd5mdza BYAv1gTmMAYUFVR4ZFkBcaGvSE X-Google-Smtp-Source: AGHT+IGSkWcSAojrpSrugH42CurtsovE3X2ZyORbM74RU+hM35J3Nc11QarWCirMiwvKlyqZPAU6Pg== X-Received: by 2002:a05:600c:4eca:b0:45d:f83b:96aa with SMTP id 5b1f17b1804b1-4711786c6f0mr1670475e9.7.1760625136233; Thu, 16 Oct 2025 07:32:16 -0700 (PDT) Received: from [192.168.1.121] ([176.206.100.218]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4711442dbaesm31205685e9.8.2025.10.16.07.32.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Oct 2025 07:32:15 -0700 (PDT) Message-ID: Date: Thu, 16 Oct 2025 16:32:15 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 0/7] HID: asus: Fix ASUS ROG Laptop's Keyboard backlight handling To: Antheas Kapenekakis Cc: platform-driver-x86@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Jiri Kosina , Benjamin Tissoires , Corentin Chary , "Luke D . Jones" , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , fooqux@proton.me References: <20251013201535.6737-1-lkml@antheas.dev> <160c3adf-9333-4486-ba4c-d3359ea73337@gmail.com> <13c53469-58fd-462a-a462-626975d6055f@gmail.com> Content-Language: en-US, it-IT, en-US-large From: Denis Benato In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/16/25 14:51, Antheas Kapenekakis wrote: > On Thu, 16 Oct 2025 at 14:46, Denis Benato wrote: >> >> On 10/16/25 14:28, Antheas Kapenekakis wrote: >>> On Thu, 16 Oct 2025 at 14:19, Denis Benato wrote: >>>> On 10/16/25 14:14, Antheas Kapenekakis wrote: >>>>> On Thu, 16 Oct 2025 at 13:57, Denis Benato wrote: >>>>>> On 10/13/25 22:15, Antheas Kapenekakis wrote: >>>>>>> This is a two part series which does the following: >>>>>>> - Clean-up init sequence >>>>>>> - Unify backlight handling to happen under asus-wmi so that all Aura >>>>>>> devices have synced brightness controls and the backlight button works >>>>>>> properly when it is on a USB laptop keyboard instead of one w/ WMI. >>>>>>> >>>>>>> For more context, see cover letter of V1. Since V5, I removed some patches >>>>>>> to make this easier to merge. >>>>>>> >>>>>>> All comments with these patches had been addressed since V4. >>>>>> I have loaded this patchset for users of asus-linux project to try out. >>>>>> >>>>>> One of them opened a bug report about a kernel bug that happens >>>>>> consistently when closing the lid of his laptop [1]. >>>>>> >>>>>> He also sent another piece of kernel log, but didn't specify anything more >>>>>> about this [2]. >>>>>> >>>>>> [1] https://pastebin.com/akZx1w10 >>>>>> [2] https://pastebin.com/sKdczPgf >>>>> Can you provide a link to the bug report? [2] seems unrelated. >>>> The log in [2] was posted without additional context in the same >>>> discord message as [1]. >>> Link me the kernel sources. Is it linux-g14 in the AUR? >> Someone has replicated it on the AUR but it's just an out-of-sync replica. >> >> The true source code is here: >> https://gitlab.com/asus-linux/linux-g14 branch 6.17 > Ok, lets wait for the user to replicate on a stock kernel > User said "yes I just confirmed it: it is only on the asus kernel, mainline doesn't have this issue". With "asus kernel" he is referring to -g14. I added him in CC. >>>> I think I will tell the user to open a proper bug report because >>>> I do agree on the fact that it's looking unrelated. >>>>> As for [1], it looks like a trace that stems from a sysfs write to >>>>> brightness stemming from userspace that follows the same chain it >>>>> would on a stock kernel and times out. Is it present on a stock >>>>> kernel? >>>> I have asked more details to the user. The user is not online ATM >>>> so I will get to you with more details when I can. >>>>> Ilpo should know more about this, could the spinlock be interfering? >>>>> My testing on devices that have WMI led controls is a bit limited >>>>> unfortunately. However, most of our asus users have been happy with >>>>> this series for around half a year now. >>>> Unless they have looked to kernel logs they won't be able to tell >>>> since apparently there are no visible consequences. >>>>> Antheas >>>>> >>>>>>> --- >>>>>>> V5: https://lore.kernel.org/all/20250325184601.10990-1-lkml@antheas.dev/ >>>>>>> V4: https://lore.kernel.org/lkml/20250324210151.6042-1-lkml@antheas.dev/ >>>>>>> V3: https://lore.kernel.org/lkml/20250322102804.418000-1-lkml@antheas.dev/ >>>>>>> V2: https://lore.kernel.org/all/20250320220924.5023-1-lkml@antheas.dev/ >>>>>>> V1: https://lore.kernel.org/all/20250319191320.10092-1-lkml@antheas.dev/ >>>>>>> >>>>>>> Changes since V5: >>>>>>> - It's been a long time >>>>>>> - Remove addition of RGB as that had some comments I need to work on >>>>>>> - Remove folio patch (already merged) >>>>>>> - Remove legacy fix patch 11 from V4. There is a small chance that >>>>>>> without this patch, some old NKEY keyboards might not respond to >>>>>>> RGB commands according to Luke, but the kernel driver does not do >>>>>>> RGB currently. The 0x5d init is done by Armoury crate software in >>>>>>> Windows. If an issue is found, we can re-add it or just remove patches >>>>>>> 1/2 before merging. However, init could use the cleanup. >>>>>>> >>>>>>> Changes since V4: >>>>>>> - Fix KConfig (reported by kernel robot) >>>>>>> - Fix Ilpo's nits, if I missed anything lmk >>>>>>> >>>>>>> Changes since V3: >>>>>>> - Add initializer for 0x5d for old NKEY keyboards until it is verified >>>>>>> that it is not needed for their media keys to function. >>>>>>> - Cover init in asus-wmi with spinlock as per Hans >>>>>>> - If asus-wmi registers WMI handler with brightness, init the brightness >>>>>>> in USB Asus keyboards, per Hans. >>>>>>> - Change hid handler name to asus-UNIQ:rgb:peripheral to match led class >>>>>>> - Fix oops when unregistering asus-wmi by moving unregister outside of >>>>>>> the spin lock (but after the asus reference is set to null) >>>>>>> >>>>>>> Changes since V2: >>>>>>> - Check lazy init succeds in asus-wmi before setting register variable >>>>>>> - make explicit check in asus_hid_register_listener for listener existing >>>>>>> to avoid re-init >>>>>>> - rename asus_brt to asus_hid in most places and harmonize everything >>>>>>> - switch to a spinlock instead of a mutex to avoid kernel ooops >>>>>>> - fixup hid device quirks to avoid multiple RGB devices while still exposing >>>>>>> all input vendor devices. This includes moving rgb init to probe >>>>>>> instead of the input_configured callbacks. >>>>>>> - Remove fan key (during retest it appears to be 0xae that is already >>>>>>> supported by hid-asus) >>>>>>> - Never unregister asus::kbd_backlight while asus-wmi is active, as that >>>>>>> - removes fds from userspace and breaks backlight functionality. All >>>>>>> - current mainline drivers do not support backlight hotplugging, so most >>>>>>> userspace software (e.g., KDE, UPower) is built with that assumption. >>>>>>> For the Ally, since it disconnects its controller during sleep, this >>>>>>> caused the backlight slider to not work in KDE. >>>>>>> >>>>>>> Changes since V1: >>>>>>> - Add basic RGB support on hid-asus, (Z13/Ally) tested in KDE/Z13 >>>>>>> - Fix ifdef else having an invalid signature (reported by kernel robot) >>>>>>> - Restore input arguments to init and keyboard function so they can >>>>>>> be re-used for RGB controls. >>>>>>> - Remove Z13 delay (it did not work to fix the touchpad) and replace it >>>>>>> with a HID_GROUP_GENERIC quirk to allow hid-multitouch to load. Squash >>>>>>> keyboard rename into it. >>>>>>> - Unregister brightness listener before removing work queue to avoid >>>>>>> a race condition causing corruption >>>>>>> - Remove spurious mutex unlock in asus_brt_event >>>>>>> - Place mutex lock in kbd_led_set after LED_UNREGISTERING check to avoid >>>>>>> relocking the mutex and causing a deadlock when unregistering leds >>>>>>> - Add extra check during unregistering to avoid calling unregister when >>>>>>> no led device is registered. >>>>>>> - Temporarily HID_QUIRK_INPUT_PER_APP from the ROG endpoint as it causes >>>>>>> the driver to create 4 RGB handlers per device. I also suspect some >>>>>>> extra events sneak through (KDE had the @@@@@@). >>>>>>> >>>>>>> Antheas Kapenekakis (7): >>>>>>> HID: asus: refactor init sequence per spec >>>>>>> HID: asus: prevent binding to all HID devices on ROG >>>>>>> platform/x86: asus-wmi: Add support for multiple kbd RGB handlers >>>>>>> HID: asus: listen to the asus-wmi brightness device instead of >>>>>>> creating one >>>>>>> platform/x86: asus-wmi: remove unused keyboard backlight quirk >>>>>>> platform/x86: asus-wmi: add keyboard brightness event handler >>>>>>> HID: asus: add support for the asus-wmi brightness handler >>>>>>> >>>>>>> drivers/hid/hid-asus.c | 235 +++++++++++---------- >>>>>>> drivers/platform/x86/asus-wmi.c | 157 ++++++++++++-- >>>>>>> include/linux/platform_data/x86/asus-wmi.h | 69 +++--- >>>>>>> 3 files changed, 291 insertions(+), 170 deletions(-) >>>>>>> >>>>>>> >>>>>>> base-commit: 3a8660878839faadb4f1a6dd72c3179c1df56787