From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 816427580A for ; Thu, 2 May 2024 13:15:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714655761; cv=none; b=nWOWgpp7DfdhsLXodoTtMgvlFGEUZY0GWKyDzCUnlA2YArmgKyvLuTZnAJgQXavPZnEpcQGG+eRsoTT28CClFPokR++4Y7vG5KLXWnotVdEgak0DuifzhLUx4yFk2pzSJeZrVmi7J3c7M3Q2YJA9kqlLp0vB5/3dEb9tajgFIoA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714655761; c=relaxed/simple; bh=c8ZZ9d64RbEWyQ6Kk0VKbXdMhQLFT49iGgzs/AfSJQw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uPAcBYOcCf4iadhIfw/Aei4M6X6qibG7XfIguy4zM/fc00gDlVshWUElvSiYlzB74PHwenzY3ZriF9Bhw+1jdOcnR5iFrd3SM/0vtaW/RLFrp6EaRwua6kHobSioCUXqoycIlTTTx2gPH6xbSKbcSpflTCkKufWmTjz1M+Jpla8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=C+dMKvAM; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="C+dMKvAM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1714655758; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=yJRM9yLGjCQ3X2KTtow0XulnnmVUDuYuBv4ldY/21BM=; b=C+dMKvAMruldzeBkCJz+VP994VvXuVhVe6oRkQ+7JwMGv0Nesno72yEixe6zh9e5mlyqqC BZ7R7vX1Os3oJqnQAxl0d+pjntSaP7UXV9PJ56fY/vAb93bSw87ENylGkea/HDvaqLI0+a ekHmooOAYktqeifKZ/ULc9k/xS8DdHg= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-106-zyvSBYc4OmeffEq1JG3m9g-1; Thu, 02 May 2024 09:15:57 -0400 X-MC-Unique: zyvSBYc4OmeffEq1JG3m9g-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-418df23b51cso35402925e9.1 for ; Thu, 02 May 2024 06:15:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714655755; x=1715260555; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yJRM9yLGjCQ3X2KTtow0XulnnmVUDuYuBv4ldY/21BM=; b=ne0uTuC0HwqIduvFa3wEbUSVbVKLhWU9o+vDaFIWqYDG0MXOaf3HVxn1XnDMciWPse d+62z3bj/7xq85fNRDngt3PUr9zIaeo9XufOfnpvoKRB3lNcH2ijpRoi+2rQ7DHtfB80 I8hxb0NeQHE3KfsRmb6/J3+kYdrqDTgo88o6JCzN4g2zIptlwWzZh1RoJtEnyRfotZ/z 69C+JcJw/lDKuRpb8m37mJGAxzpUSBNc9KwjS90kgJ6Za4eSt80EirU7bPCuZY0EE4HP Vgubn5ADe70t5Xfjup5aMpZzzpMHKmjG6/wBQCVqLb3vGaY0STxjP07AcsLP3Xx50+pS O5WA== X-Gm-Message-State: AOJu0Yytl3iCofzDPdKbBC6+XdS+t7FhZg6/oqkDlibM/LN0TxOg0SUv ARyBV6f9K71V2q4nc+OpzasfGp6UVebUSQUYBHqfLuVA2p3OP0E5AFn0/zvgN/1UnGkY3uj4H/h 35bdGE0Tp5E6zVIQfsd26oxwhJ8JPdLaVTdbJHZ94bVT428OuBqU0gCJ4duXi3A== X-Received: by 2002:a05:600c:5347:b0:41a:f9db:88ac with SMTP id hi7-20020a05600c534700b0041af9db88acmr4205373wmb.14.1714655755539; Thu, 02 May 2024 06:15:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHIdIVLBhB+0aie2kvkajxvjiyhxiVZplyKjASYKUxI+SOW9NeCEQX4xWLxZvFVP3TIfqcaow== X-Received: by 2002:a05:600c:5347:b0:41a:f9db:88ac with SMTP id hi7-20020a05600c534700b0041af9db88acmr4205355wmb.14.1714655755077; Thu, 02 May 2024 06:15:55 -0700 (PDT) Received: from ?IPV6:2003:cb:c71e:bf00:eba1:3ab9:ab0f:d676? (p200300cbc71ebf00eba13ab9ab0fd676.dip0.t-ipconnect.de. [2003:cb:c71e:bf00:eba1:3ab9:ab0f:d676]) by smtp.gmail.com with ESMTPSA id s7-20020a05600c384700b0041c12324eb6sm5728258wmr.22.2024.05.02.06.15.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 May 2024 06:15:54 -0700 (PDT) Message-ID: Date: Thu, 2 May 2024 15:15:53 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/hugetlb: align cma on allocation order, not demotion order To: Frank van der Linden , linux-mm@kvack.org, muchun.song@linux.dev, akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org, Roman Gushchin References: <20240430161437.2100295-1-fvdl@google.com> Content-Language: en-US From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240430161437.2100295-1-fvdl@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 30.04.24 18:14, Frank van der Linden wrote: > Align the CMA area for hugetlb gigantic pages to their size, not the > size that they can be demoted to. Otherwise there might be misaligned > sections at the start and end of the CMA area that will never be used > for hugetlb page allocations. > > Signed-off-by: Frank van der Linden > Cc: Roman Gushchin > Fixes: a01f43901cfb ("hugetlb: be sure to free demoted CMA pages to CMA") > --- > mm/hugetlb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 5dc3f5ea3a2e..cfe7b025c576 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -7794,7 +7794,7 @@ void __init hugetlb_cma_reserve(int order) > * huge page demotion. > */ > res = cma_declare_contiguous_nid(0, size, 0, > - PAGE_SIZE << HUGETLB_PAGE_ORDER, > + PAGE_SIZE << order, > HUGETLB_PAGE_ORDER, false, name, > &hugetlb_cma[nid], nid); > if (res) { I was wondering how that worked when reviewing your other patch. Wondering why we never got a BUG report, maybe we were always lucky about the alignment we actually got? We round up size to PAGE_SIZE << order, so that's the alignment we need. Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb