From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9E522882A8 for ; Mon, 2 Feb 2026 15:10:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770045041; cv=none; b=EyU6T2rY5tQZ+KK+RS4rvgzu8k3UBmHwyf/C//cmuK0v1oqK1ktQzn9IGJ5JSV/RolBQIo65EpIPsf71NgIGg45ZLJF291pY/BlcE3zYtYP05AwQEkSzYqxtzhZ+nFOUiTS3jL7BHH0vbZP6AkPLqje48rPbRel88wORTxscd4U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770045041; c=relaxed/simple; bh=UNy4yDJeV+m4ntYxGYDyc8ert9Faoypz6hlYzsx1LBo=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=o7oZw2nTi4e8kHuaiOxvyXWhgSb+loeKaxyPOlSfHIBVUBR5wrcYwfud2BxeB/0fpS1TqjNVXt5sA6HkB0NLVqhkSYtfDLPRtvlsCMtwvGoTkzMetWWj5ElJwcc9TNcXkrJdEwqGn79evH8dIY8ASbtR70uWra6kJyxlbPpToic= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=d0o4Rh5c; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=K+MfAt3I; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="d0o4Rh5c"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="K+MfAt3I" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 612EM3gX1072589 for ; Mon, 2 Feb 2026 15:10:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= qjsroVNnTA3WFPJbo7FKiQMN9RAOW7J9k8+sWZ+5fz8=; b=d0o4Rh5c3ImSc820 FXpLVQaFKliucWaGQOpevLW3MyqP7IBt/fse/xMcfyML/uH2u+elx44xbrVSVnyR Od6V0ZMNqq7BsN9fMvYAru7DV9jC5SiZe3NeH7qLYiVNXhYQtnMtMg0EsWDq6xCU eL2zNzeZV2yI/0+gE2u3fbyutnPbYcqbC0cx/E+Ka+d1RMgIAQ7nhikcJ3yegNR0 5KBk+rQTJV91AS9RGe81q02IkezKnQZowob1/bij2HpEBhB+h91KadPhE9foAdQj 25BihkcEbAd4P9rrIlbiMAIcyz1hKzlK9q/erq8Kf3/9HadizWnQsbCQbXBTj9rx I9epAQ== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c1awnww6g-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 02 Feb 2026 15:10:38 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8ca06e38994so486324085a.3 for ; Mon, 02 Feb 2026 07:10:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770045038; x=1770649838; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=qjsroVNnTA3WFPJbo7FKiQMN9RAOW7J9k8+sWZ+5fz8=; b=K+MfAt3ILp+FHftamuoCI2UHPRV6ygM0jTFBpm8f2CwQDV215kVTJO4FV/Xk6LODwp f0+W1DJcbNKDQBgtSQ0R/HfLYrEDh3ExloOwRXlYdgQgn6BZMz/su7pq4quDUZmDDDe2 H/kLX9XnO9h5cVRa79tN0PdMIrfbQq6LDVx9w2ArXnXGCLHKWEEyyrf9XNAv9rKTUapD 1Aw9jFke5zAtbStZmqyztyD84uWcICL4vsA9vt4xQn8kYkn5j1eTnmVXB6z6J+sx7J7e 5UZOw1Tnom7iiwk8amVXWS4IXXFHkp0hBQ3R29DNXfYEJZVYaioZXPyXPuOoyTx3z3lv LPIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770045038; x=1770649838; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qjsroVNnTA3WFPJbo7FKiQMN9RAOW7J9k8+sWZ+5fz8=; b=gZAt4euYMGcedNxU47PsjLjkpe538eRfVjKIvzovbeiy4E9GaSenKIKRoKfsD7J+cx 07s2lpb1tqNfKTtTXOhaVEGFrIvYKjvS5miBINEKJx/QpsG2BkkuVUBLh1QUnfzXlDtS GAs4ic6VFmPeQCNUvXJEzQr4rWcNKhE4C06y1+GU9gbRSdrf+T1WE/9fp7rnp7RIhyZV UuRDGr7hQw+/3cQ5Ant5nZJyz+4IY9HrWXgRjX/dur1bIWJW2f+BJOZhs+ZoiRnRIOZy zJns7MjgU+73kRomCGvFoCetTvrjD63GEXsVCpifug6OFUwoFJzSs0hZpnSy8+scTlBl hCEA== X-Forwarded-Encrypted: i=1; AJvYcCWdRpNgD2QhT29ZNKJeLlH8SNoqKJUEgO3fScJ2dQc5Rw8Paaos09lwOd/wR9QobRRqRZ5qBurFhihaXHI=@vger.kernel.org X-Gm-Message-State: AOJu0Yx2C00UXOVqm5sJRkplGUSF6gC9PnKf4hB7yJiAgq+C5X29z8dO 9S8gJ4MmWP2mRnZXvJKFdPKgF0iYvbz6R4qcqX2cPjIWdyLUvd3u3aA0uec9xeMCfaoo6AuduWz Y9HBYYmMiUdEI9+HGmAYAFjatHlUzZjVmPcXRWqyVPpqg1nRBL8JSmC1fYWPGz5P9HQ0= X-Gm-Gg: AZuq6aJ8HFBW7Er3LRg4T+EykEQG/x4BC4CUdHel29+sj6u/nKVTCilmRFPfz9Mg2mL +OrNnFsElMwxHbtHgvzJSYugflx1rXQn1UL/h3IJKTrWF5/bGL+OFqZ1jabNM+BJutOxmpANvIL Ys+ZptKLo8QYPuaARt5fj23EaJgTza5uAWhQYKR3YwwM5+T0EIBNzUulMHehC1GcPpSyJND7wLz ddoYFGHINc+BGa3VOzLfVvQVR0RI0o5dJ1WQ4THUviPrVnM/CoiYcrMkF2vMF+mTRV+euRLVAaq kQCQ5LStwm/Flu1Nc4qFCyvsSChfQ/090gkh19Cj9GOYF6d4jIsNJsg1/Ea1tiP7WO2nO04W4LP PcxA0c9nt0mhhHcOTqzz2eahL/PEIjhCzqhU1iGvZ/TBe41ZoORdIJeP/SRq5bFtWLr12YGlgP4 9x08QrE7ln3ciLjtCLIxaAhIx2hr0VZWWyQf/nwUPKom9V1MBRb9FkPUhIIW1NECthwyPPqu7BV 9VQ X-Received: by 2002:a05:620a:461e:b0:8b2:e5da:d316 with SMTP id af79cd13be357-8c9eb338d00mr1483019485a.87.1770045037858; Mon, 02 Feb 2026 07:10:37 -0800 (PST) X-Received: by 2002:a05:620a:461e:b0:8b2:e5da:d316 with SMTP id af79cd13be357-8c9eb338d00mr1483012185a.87.1770045037140; Mon, 02 Feb 2026 07:10:37 -0800 (PST) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8dbef86991sm899192566b.4.2026.02.02.07.10.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Feb 2026 07:10:36 -0800 (PST) Message-ID: Date: Mon, 2 Feb 2026 16:10:35 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: johannes.goede@oss.qualcomm.com Subject: Re: [PATCH 1/2] platform/x86: int3472: Add board data for Intel nvl To: Arun T Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260130092431.2335363-1-arun.t@intel.com> Content-Language: en-US, nl In-Reply-To: <20260130092431.2335363-1-arun.t@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=MNltWcZl c=1 sm=1 tr=0 ts=6980be6e cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=QyXUC8HyAAAA:8 a=_nQcPkY42JPOdq3XkR4A:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-GUID: VO97xaNgy_c_jeoJcNJH9_WmG-Kk5KRH X-Proofpoint-ORIG-GUID: VO97xaNgy_c_jeoJcNJH9_WmG-Kk5KRH X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjAyMDExOSBTYWx0ZWRfX7z4wZox6qluI z9rxtnrYG5gX242oyJxI9702N00L5aDtEWpWLurBeChUSX6Tty9ya5XYfbUGu/aP4OyGsqFCXIn Awjx/KPgEZcBB5q/ZblaaLbaTjIOmbKMM/75e4bb8Kvoil34tt+pLj0oHE5UxwBqPSteZXorRAw 5iAARUzlnZwGIHp9/PEZ6hypXb4IFyipBNg1AkObcZMkv06JohKuyZXDrYr4o4SMMfMpm9q5+2D RqYLoPLNisJC/4fJNrpzOPLs8eSCHHJBhezeMssCtVmL5Y3PauXOURkP/F9dhxAhZba5Er60vW9 Yj5SnopvXJxCv92OmzKDOuUOFQRtvOJnbUMOGP8X/dINIcMZmOi5empUXSDCuP6irdLb0V81NsA HxImMeNF4U0tlv13N927oh2SF9sOcexpUcRDrR6iskuG0px4n6b5EnTUsdkjm1l6GbplOdN1fxO 9+Uu67F6rSqor7XIlIQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-02_04,2026-01-30_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 adultscore=0 impostorscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 spamscore=0 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602020119 Hi Arun, Thank you for your patch. On 30-Jan-26 10:24, Arun T wrote: > The Intel Nvl O13b10 sensor with the Intel IPU8 ISP. > The sensor is powered by a TPS68470 PMIC, and so we > need some board data to describe how to configure the GPIOs and > regulators to run the sensor. > > Signed-off-by: Arun T > --- > .../x86/intel/int3472/tps68470_board_data.c | 150 ++++++++++++++++++ > 1 file changed, 150 insertions(+) > > diff --git a/drivers/platform/x86/intel/int3472/tps68470_board_data.c b/drivers/platform/x86/intel/int3472/tps68470_board_data.c > index 71357a036292..7820ff811df8 100644 > --- a/drivers/platform/x86/intel/int3472/tps68470_board_data.c > +++ b/drivers/platform/x86/intel/int3472/tps68470_board_data.c > @@ -143,6 +143,34 @@ static struct regulator_consumer_supply int3479_aux2_consumer_supplies[] = { > REGULATOR_SUPPLY("dovdd", "i2c-INT3479:00"), > }; > > +/* Settings for Intel NVL platform */ > + > +static struct regulator_consumer_supply int347_ov13b_core_consumer_supplies[] = { > + REGULATOR_SUPPLY("dvdd", "i2c-OVTI13B1:00"), > +}; > + > +static struct regulator_consumer_supply int347_ov13b_ana_consumer_supplies[] = { > + REGULATOR_SUPPLY("ana", "i2c-OVTI13B1:00"), > +}; > + > +static struct regulator_consumer_supply int347_ov13b_vcm_consumer_supplies[] = { > + REGULATOR_SUPPLY("vdd", "i2c-OVTI13B1:00"), > +}; > + > +static struct regulator_consumer_supply int347_ov13b_vsio_consumer_supplies[] = { > + REGULATOR_SUPPLY("dovdd", "i2c-OVTI13B1:00"), > + REGULATOR_SUPPLY("vsio", "i2c-OVTI13B1:00"), > + REGULATOR_SUPPLY("vddd", "i2c-OVTI13B1:00"), > +}; > + > +static struct regulator_consumer_supply int347_ov13b_aux1_consumer_supplies[] = { > + REGULATOR_SUPPLY("vdda", "i2c-OVTI13B1:00"), > +}; > + > +static struct regulator_consumer_supply int347_ov13b_aux2_consumer_supplies[] = { > + REGULATOR_SUPPLY("vdddo", "i2c-OVTI13B1:00"), > +}; > + You're defining many regulator supplies here, but in your ov13b10 patch you only consume: "avdd", /* Analog power */ "dovdd", /* Digital I/O power */ "dvdd", /* Digital core power */ So you should only define those as supplies here. Regards, Hans