From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E23A237F8BD for ; Wed, 4 Feb 2026 20:57:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770238621; cv=none; b=cBxKgEhdusrSqehXk+jEGKq7zmprbvOQjwJtnI5dfjVe416Z84wsZgu4B5qvgTLvmyUfx5CRLjJs2Xa6egT+6MyWThuBv04BtameLyX1gT/haCUC5GaDXNiDJqA7Rdu/MwsWzl3VkG6bGQ8fELxaxb9+jpNZBwhsKZzSzWMoKXU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770238621; c=relaxed/simple; bh=8NgQB5UnC0334tRXgRIV1lgPmtUmZwFX5qcZrt4DO8E=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=RUB1N7tg1lJ4DuAbiDWkAM0C4JA8AWVoJJ0pCRvcXB2kFBIRBhC2UhAxMw/958gLTkTgcda45b1rfW47MP3wp0jUpq18+agn2yInhLnZepKdBcDZ1G/7Ze21AN7spT5/4TtkLPbSsFqYeM5d9ty+gHxa5INc8uQkhClzjEuLboE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=R8nqvuU4; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=iBAdvO8t; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="R8nqvuU4"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="iBAdvO8t" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770238620; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YxG8OYua1gClXTSBhwuZi6jzgFrYOt/LM5ChTM0bqUk=; b=R8nqvuU4+Hg0g/pskzJGjSJrHd2VpaEuwhbZntCS+fbyP+P+gn8WHnjZ4xgAX1GaqIkN0I QnaebSGmQQmnLvOWgzUe/PcB7F6lQcVI/+BG09tYDJ0w9+KewYSlCK3UYoIAvIHVW8v2af DoEgxvk25mtSdGRregxsfpW6tO73n3s= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-404-FQaUqJWbMyaldtlV7C5QHw-1; Wed, 04 Feb 2026 15:56:56 -0500 X-MC-Unique: FQaUqJWbMyaldtlV7C5QHw-1 X-Mimecast-MFC-AGG-ID: FQaUqJWbMyaldtlV7C5QHw_1770238616 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-894766748f9so15432176d6.1 for ; Wed, 04 Feb 2026 12:56:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1770238616; x=1770843416; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=YxG8OYua1gClXTSBhwuZi6jzgFrYOt/LM5ChTM0bqUk=; b=iBAdvO8tWUWDFuhyM6hSj77KVFOIPhMkYFcHo0ciE558sAoBNMknEr4JlrH+lZcQJu qsDhFaidhyc4kPNrrIpV1HjdlxDP1SxLQ342DRy4zKcKwbFhvhEmKLgzGrbUMGAyFL2a QTVpJ9Ew0e8lhdUobZOGL5ImzdXDA09Gc2tet/Eu958QgFD6FtKwaATRqJ7J7768BIoo nbfmrNTLU2gZ40poNgnuDegcNU/bABTQNna6Ra8hN8OSUtB3jEfN2gDbEq3Fhx+rko6k /EZLzj3kEdz54LF5BnCfHe/5+/uYcFwQkmkTCpW9ilu1TmN2Y0Pczb0HIH2LWIFJU0A+ MVGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770238616; x=1770843416; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YxG8OYua1gClXTSBhwuZi6jzgFrYOt/LM5ChTM0bqUk=; b=gIctZ7Xc3pnirqdRoalzO90DaQS22u73loM67NUznu/HaIAPNvnkHJqWBpj7p4VwGN 1KoIAq8T2b/be7Ng3WPTUxkC/24XimFSq+nU0KI22FEH65Mdx6VwG5H3E3DRYwP8sMds 9N9/K3/KdRqKw1HCCBaivydcfVhKcuKBepKcFEBbnwE4s5wrd6sfWiqD9Ay/BGWhCkNr 1mLG+1QL2n+05LlCIQCw67DL+e685ZQfFzkvPg8scz4PJ0X3cqF1nrDpH2x5pJtrzSHg yklouCbjdWa0YBXgT9X3zSrOoV9mp/krInTdq+HyspVTwJD5RKjjX4bbKVkpVL7768Ee BGJA== X-Gm-Message-State: AOJu0Yxr5A2NDCZBN9OPhhY+N+YfPzEFs1zGabx6ijm2vyJVhv88vlU6 D+s/S8B4O1F7JJkZzl/d7baasZqvmZKjcyEz/cNNgLByLF7t7c9gwp+dFtCybvaSRNwetqEfdd1 5m6DtE+U/hLSouM0K4kTDC53/wLb7XpTyirZFkKBi775xe9QCFceSV2O9RAugQDa3MdpqcIDhSA == X-Gm-Gg: AZuq6aKQpdeUzT9OdnHDPDScBfTy9s31HFqf6DIdHCJfAofpBW5q8evLxsL5/0T1+T6 +PfJCWTsosh3CCDENaj05Dzdjbs84yakYLFsL9t8WpbrBay81Y0kutKLubCyhxT2QyVnzgZiPzi zDowOTX2yeirz8lVqstsITW0gbCTdHs+Y54tj6RjypN3SA8CDDzaQQ1NaY1vn8n7kCwugSSxRYe +nLW/FCghYefVrkUo6UJletbIpAwB3Zu6IoSbhVibOOnlShOIRuQNoXVGxP+IXZeAZs8F7eOfVD ZyXnPf0g9VAFBEVpw2qZMhm4ist++9tBPCnsfy7Zj3LzFiKdQZ9oPnxxi4iZ1VPXT2z6S042P3G gkmzY3w== X-Received: by 2002:a05:620a:4483:b0:8ca:1107:1215 with SMTP id af79cd13be357-8ca2f80c345mr484845885a.9.1770238616244; Wed, 04 Feb 2026 12:56:56 -0800 (PST) X-Received: by 2002:a05:620a:4483:b0:8ca:1107:1215 with SMTP id af79cd13be357-8ca2f80c345mr484843885a.9.1770238615795; Wed, 04 Feb 2026 12:56:55 -0800 (PST) Received: from [192.168.8.4] ([100.0.180.93]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-89521c00173sm27081576d6.12.2026.02.04.12.56.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Feb 2026 12:56:55 -0800 (PST) Message-ID: Subject: Re: [PATCH v5 2/4] rust/drm: Don't setup private driver data until registration From: lyude@redhat.com To: Daniel Almeida Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, rust-for-linux@vger.kernel.org, Danilo Krummrich , nouveau@lists.freedesktop.org, Miguel Ojeda , Simona Vetter , Alice Ryhl , Shankari Anand , David Airlie , Benno Lossin , Asahi Lina Date: Wed, 04 Feb 2026 15:56:54 -0500 In-Reply-To: <95623012-BAA8-4AA5-9D34-42FAE44B0FFD@collabora.com> References: <20260131001602.2095470-1-lyude@redhat.com> <20260131001602.2095470-3-lyude@redhat.com> <95623012-BAA8-4AA5-9D34-42FAE44B0FFD@collabora.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.2 (3.58.2-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Wed, 2026-02-04 at 15:28 -0300, Daniel Almeida wrote: > > +=C2=A0=C2=A0=C2=A0 pub(crate) data_is_init: AtomicBool, >=20 > What about this? >=20 > /** > * @registered: > * > * Internally used by drm_dev_register() and > drm_connector_register(). > */ > bool registered; >=20 > Can=E2=80=99t we use this in lieu of this flag you=E2=80=99ve added? No we couldn't unfortunately. As I said before: a lot of KMS setup has to happen prior to registration, and most of those callbacks (atomic_check, atomic_commit, etc.) can both happen before registration and after. And that's a lot more difficult to deal with if we don't have access to the private driver data for any of those callbacks. So - it really does truly need to be tracked separately. >=20 > > +