From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755232AbdK1LQx (ORCPT ); Tue, 28 Nov 2017 06:16:53 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:39818 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755112AbdK1LQu (ORCPT ); Tue, 28 Nov 2017 06:16:50 -0500 X-Google-Smtp-Source: AGs4zMaoJzboIn/GmBAJLCfQvYJ7LZe0veJEEJ0AylHu18gUlP01hTiCI92xIGY00Bcyc5iGviGOrQ== Subject: Re: [PATCH v3 4/6] ARM: dts: imx6qdl: Add Variscite DART-MX6 SoM support To: Fabio Estevam Cc: Shawn Guo , Sascha Hauer , Fabio Estevam , linux-kernel , "linux-arm-kernel@lists.infradead.org" References: <1511785716-23492-1-git-send-email-narmstrong@baylibre.com> <1511785716-23492-5-git-send-email-narmstrong@baylibre.com> From: Neil Armstrong Organization: Baylibre Message-ID: Date: Tue, 28 Nov 2017 12:16:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/11/2017 13:57, Fabio Estevam wrote: > On Mon, Nov 27, 2017 at 10:28 AM, Neil Armstrong > wrote: > >> +&pcie { >> + fsl,tx-swing-full = <103>; >> + fsl,tx-swing-low = <103>; >> + reset-gpio = <&gpio4 11 GPIO_ACTIVE_HIGH>; > > This can only be active high if 'reset-gpio-active-high' property is > present, so what you > want here is: > reset-gpio = <&gpio4 11 GPIO_ACTIVE_LOW>; > > With this fixed: > > Reviewed-by: Fabio Estevam > Ok, I will post a v4 lately with this fixed. Thanks, Neil