From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3DEE3BD225 for ; Sat, 22 Aug 2026 10:55:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787396130; cv=none; b=LdAB3oGznD/9/U0rCOVYzpxyfn939NpxcK4w3wuo5nb5CeKEQYCLNe3QwXvivV1RUhvjp7Gbh1i3z9OmmTH7IQNTVYXWn5HoMWH/UqAw+Pf22BnvMyIxbifNVx2hpKp23Xrj8WsvQW3UUPT0+AY3x5+Wq7a2BALZpJ6kmvL5Jdg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787396130; c=relaxed/simple; bh=mIRVvQlMitwJ2TgSeN+63is4M32mqgfMaLC73/cG5gs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=INy4bpY1BhI+t9tRFXezTry31rLGUBpNpFHNNcSHElL37u5haiaoDgpLrm+a0IQ8RpIrjTlkUzQKngU35KemhmFfRUaKCivOx7Er6VIoBQGsz5yWT8i6eGriu4sCGMfuQshPR88v/atTe/bhI31eAQp99avpht9tPDUaa54qnTM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=oNLqXqYm; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oNLqXqYm" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4998b5a63e2so14982175e9.1 for ; Sat, 22 Aug 2026 03:55:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787396125; x=1788000925; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=iXeos56KLg2M5NQRpaxXrpkevC0KZ7ingkuH0fmAz58=; b=oNLqXqYmtmk/GOas16Z4CR15w6NfzQE1xnkhOq45BnJJlADrHx/sDkDGFd6hkgGee7 7NUZbLUyjHtprTCJpNUEMiY5Oc2VaPr6VhnSUALoXBTtECJ2RhfFRNy8QK8sejpS3jub 33rXWb5/QmfrjV9LLHc4IVNg2cy3UVqPsVZ73Vo5OmTdqyVi2B3UVvAp9HBW4VxLZF8u lO+2U/RMN/kmPqcXXqgiTBxHPIxTDsTA574LDjDBXU+FO7FOkXRUO9n+rc5kPW8J5UKE iCVu7eqs5QppXKy4xyTRgNu+vPqn3CG3zDkyrQonPuApGV540Bnfc/ZhL7oUFoe5OVQb uRtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787396125; x=1788000925; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=iXeos56KLg2M5NQRpaxXrpkevC0KZ7ingkuH0fmAz58=; b=ffgpgsfzva/crfvd4w1Ct16O1N9WdypzDFnYsXdkYAkbli6n9OVpvaZbi+DfHaVF+E ppjCdshib4Qe1ZFM6mO2unttJIK/nkjT6QWYlk5aq3XNyXIEfC8qMX/zCjN8J8yjL8Hj FA8t/yqq1QY3TiKCTkW3EuIOy22PxU/UlsKHdNW7ugHk2NojX4g/IZEnhXrY2umDdn1J JeDkwK6SS1wKoJOzlXEUKQtdjbLTZzprtpL897nyRqqbD7vvDJ9+8wJb5amJ5Xo/FMAX maNrjHpY8zIFtrzz3q5Xvd/9KcdvCadbyUP/9XIvNLg3WrebQMfjKT6PrnZqc9wvK/Rj BmXQ== X-Forwarded-Encrypted: i=1; AHgh+Rp4w4p2+W0AUrv6UHJSwOV0wbVnazrW2FhDYHQmshJueEYIdMLD9RxLMLXfxC8gmN1pvi0mu1dY/r6N8bk=@vger.kernel.org X-Gm-Message-State: AFuF++mlyATxYcj1s4DDsPDxySobx9u7EJbpcinsIgvJE4oc34WDR5T7 MQIhJm+Ya/1c9XiBsDQzC82CTp7Q1aCLlgKvPRSJKrrf3o4hkQRJKe8Q X-Gm-Gg: AR+sD132Sf8cZao/vH8rfN9ReUBiGNs0JvYFtAhvnfKlmwEZUVcrxRSaTNHhv5kGH1W lkUQFxeB7L+qNgX/tuaJ/oCs18ud0yNXj8+H/sGf/TDqXhM9HzyHYcQFeuAVYZSIfki4mIcudcQ khFlfPdzIFVCbMwuAG01iOwg8Z0QLJV1Vyoaa99krE6vwlIney2QSsJd0c2mD14S33tr1ZWidpi O2cbXvlAVt2vEumXaYxV8+xoOnBedCKKVTPAVX7Wrc+YnaLpqxYvWrS+r9b74CO3SQamD1xciJy rlbwYl7HpayI6idxLB/s7UHXPu7e37y5BegQPOyKQisMwy9vA5dG72eghk3E/CGOhC/FyzseKnR zv6G6coKNtLTE7ZgPgOfnjvsW0Ryh2065OSzbgulbXuGaVRtUJXuGJ2BwWp0L3SNn76Lc4n6Ufo SbG9TWp2ndiFOlo7Nqg/3fMY4M2nQHlWSzvt4GWG9aR7ZjZRKSj+QVCZNkNePgjGMnruB4uvDfC qx1Sdc/FwlkTEtnN6fI8O+D9QhqJHLq3KRHRN+rZV3wFFcPQokRTUSX4ixf3qTXKXp9Q8093+OL lihjbb8nDTo4wJFKX6YaYHtrOUW4buvQ8RqsLvw= X-Received: by 2002:a05:600c:6217:b0:499:8ae1:b900 with SMTP id 5b1f17b1804b1-499b8460e7fmr182614885e9.12.1787396125322; Sat, 22 Aug 2026 03:55:25 -0700 (PDT) Received: from ?IPV6:2a01:4b00:bd21:4f00:7cc6:d3ca:494:116c? ([2a01:4b00:bd21:4f00:7cc6:d3ca:494:116c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499b915cda6sm65813845e9.14.2026.08.22.03.55.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 22 Aug 2026 03:55:23 -0700 (PDT) Message-ID: Date: Sat, 22 Aug 2026 11:55:22 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v4 2/2] net: tcp: block mixing readable and unreadable frags To: Mina Almasry , Paolo Abeni Cc: kuba@kernel.org, kaiyuanz@google.com, willemb@google.com, edumazet@google.com, sdf@fomichev.me, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, dev@openvswitch.org, davem@davemloft.net, horms@kernel.org, ncardwell@google.com, kuniyu@google.com, aconole@redhat.com, echaudro@redhat.com, i.maximets@ovn.org, kerneljasonxing@gmail.com, bobbyeshleman@gmail.com, fw@strlen.de References: <20260814191336.187243-2-almasrymina@google.com> <20260818102612.132228-1-pabeni@redhat.com> Content-Language: en-US From: Pavel Begunkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 8/18/26 19:37, Mina Almasry wrote: > On Tue, Aug 18, 2026 at 3:26 AM Paolo Abeni wrote: ...>> Note the mixing described in the second direction pre-dates this patch >> (there was no check at all before); the incorrect predicate and the >> forced re-segmentation are new. Reaching this also needs a local >> privileged setup (dmabuf TX binding plus MD5/AO or IPsec plus an ethtool >> feature change), and in that configuration a devmem send through the copy >> path would likely already fail in skb_copy_to_page_nocache() since the >> iovec holds dmabuf offsets rather than user addresses, so this is stated >> as an observation rather than a demonstrated corruption path. > > Pre-existing issue I think. We indeed assume binding != NULL means the > send is devmem and zc is set. We missed that we may not set zc if > NETIF_F_SG is not enabled. Probably the code setting binding to Hmm, I flagged this one, I'm going to send out the diff I attached in the thread for v3. -- Pavel Begunkov