From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BDF1C433F5 for ; Thu, 20 Jan 2022 15:26:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376640AbiATP0I (ORCPT ); Thu, 20 Jan 2022 10:26:08 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:35544 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376574AbiATPZ6 (ORCPT ); Thu, 20 Jan 2022 10:25:58 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 20AE41F45362 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1642692356; bh=8+iuI55GEe2f55qKCFzj4slDIPT5+kv1gU6x/pdsBWs=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=GTb4GYgETr0dGmKkiXlgmJg7q/i9Jobg8xDglDVLE1yiD9nqSCfbJ6YOsd7BirHkD MpqsMfqmuNcZ+/1ceXPqJt5YiQxspgDj8/6fwrcKtbxzqDMxkf0CJd+BvzYKQk1wCa znonQ211B4GgUX0BhXhUSWLOh0spevMCXUj4FkR3Hs2qri6R4TuaWaDpcmVZmfnE84 N6QN0FEQe2Vx+L2ongu551azvIgenLYGdYwfHrlOJz7/5zAPq6bHoPz1y5cyXrCzIo EyzdhCTvcMM3srz9WawMdAtHs/6Gs83C9GqliWKX7cG1GQ5+h/XPDjwyc/QfyJOinP MCe8ry4JrqplA== Subject: Re: [PATCH v11] drm/bridge: add it6505 driver To: allen Cc: Kenneth Hung , Jernej Skrabec , Jau-Chih Tseng , David Airlie , "open list:DRM DRIVERS" , Neil Armstrong , open list , Robert Foss , Jonas Karlman , Hermes Wu , Laurent Pinchart , Andrzej Hajda , Hsin-yi Wang , Hsin-Yi Wang References: <20220114091502.333083-1-allen.chen@ite.com.tw> From: AngeloGioacchino Del Regno Message-ID: Date: Thu, 20 Jan 2022 16:25:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20220114091502.333083-1-allen.chen@ite.com.tw> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 14/01/22 10:14, allen ha scritto: > This adds support for the iTE IT6505. > This device can convert DPI signal to DP output. > > From: Allen Chen > Tested-by: Hsin-yi Wang > Signed-off-by: Hermes Wu > Signed-off-by: Allen Chen > --- > v10 -> v11 : remove drm_bridge_new_crtc_state > --- > drivers/gpu/drm/bridge/Kconfig | 8 + > drivers/gpu/drm/bridge/Makefile | 1 + > drivers/gpu/drm/bridge/ite-it6505.c | 3352 +++++++++++++++++++++++++++ > 3 files changed, 3361 insertions(+) > create mode 100644 drivers/gpu/drm/bridge/ite-it6505.c > ...snip... > +static const struct of_device_id it6505_of_match[] = { > + { .compatible = "ite,it6505" }, > + { } > +}; If you want to have a DT compatible and DT properties, you have to also add dt-bindings (yaml) for this driver, otherwise, any SoC/device DT will fail the dt binding check.... So, please, add that. For the driver by itself, though: Acked-by: AngeloGioacchino Del Regno > + > +static struct i2c_driver it6505_i2c_driver = { > + .driver = { > + .name = "it6505", > + .of_match_table = it6505_of_match, > + .pm = &it6505_bridge_pm_ops, > + }, > + .probe = it6505_i2c_probe, > + .remove = it6505_i2c_remove, > + .shutdown = it6505_shutdown, > + .id_table = it6505_id, > +}; > + > +module_i2c_driver(it6505_i2c_driver); > + > +MODULE_AUTHOR("Allen Chen "); > +MODULE_DESCRIPTION("IT6505 DisplayPort Transmitter driver"); > +MODULE_LICENSE("GPL v2"); >