From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48AE134A78C for ; Thu, 19 Feb 2026 15:52:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771516349; cv=none; b=iZ2VwqAKHAtf3rhuhbUeFEJopQuuMzSMZT0SrZEktUBeDwSbiE7rVWeB3bLJmHhheXNuyzZPqjm6B0KNtgKsqYxjo83i0Qy8bcoJtd6QbxO+c8xHr7jWFFRksaIuWEFTOBvtfp1Mg1w8mTRvPWFxRuOctPQqadYg4bK67FNGHYQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771516349; c=relaxed/simple; bh=hUVMfsGdV0aDbsIFOhfMsdPp5kAixuq61G/flR5Alxg=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=j+Gt46gm+8H+t+C9ecVuhfgIufExotJFpSdwXzCXUBeTg3RtkloPPmGy7WxoYJMclq43TgdZ65i9ayrXDTEOIQqY1NR47N7jJTAA9HkPASEm7cMMENtEqlyUSFolehWJ6GUKpuqDZq0wyd9aNF4iHm1fVmWjYaUhLSCHgdU3t2Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=yV9ak2c9; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yV9ak2c9" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-43621bf67ceso779371f8f.2 for ; Thu, 19 Feb 2026 07:52:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1771516346; x=1772121146; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=ausNYp9VNOhe1fBHOC525G26Oe60ih9EhrjdJ5sgpHg=; b=yV9ak2c9B8AV5lOFP2+ASu81htz4cub/EZEvHYTW6zwjxUR0sbJ3wNLOLEVTKUmniP Qg8C9YIASU2HiwGMvPlurEY5c/W3ET39r5gHOJ7kUZ+EdIEmraU0C24ueJM7mACg4PmJ ZfaKOqaNq0ptYYVRRMX/2DHWJTvP5sWZtMhaFvPE44b9l5mW1CNB56MV1wLIGMvN3ZCF SFryge4s8mXDYNGrOiOCuw+MdBh1Y8yKQFnXe/eIgdyxSV7zBpnVZgUyCFBwgsdcqv/m m6kcXoAB49/10DVAJsXRUI1I8nt1XhrdEw8XOexD0Wc8vDpyODntZbRxMsk8939vdZAE JvOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771516346; x=1772121146; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ausNYp9VNOhe1fBHOC525G26Oe60ih9EhrjdJ5sgpHg=; b=WcriK2IUkQCGcRFf4mhZZqz5NPw1oX8L7py81JN5KX4SErRuKtfQDy5VLhlZq/2DEr y42pCCWC0zrRxg+KsAb8YRAhJhM09PrW74CIXSd84N9+QqO7eqFFqQvyxSiZJ4UI63qN H1n2E+tJqO9NQexahZZ43ujpgmbIeZuMKNsBjMK4eXe2Rdjo3iOYEBr7e4sV6vtwT/2w 4O7JDpPyDaOpYZth4ZHQlU+xZrsbaFDsvhUUK+r8lj5trQ6s6zvKW92mJuCTgGS7HU24 N452g6/fKcEqadzrhsYJ4QPXlhjyXm/3u8NnzskPazbPIbY8IvODvTKDCfG8Pgad6afE G1bA== X-Gm-Message-State: AOJu0YwN43LAX1FBOqXGSYaVMo/m8ba+47pyzqzlvAjIXtvjDmK68dsN Hj/iZBXX68nZtD3R3Il5bYZFk6SLroJW5H4NyEl6mW7uuj8vzoL62qL60XVt+fmfgNY= X-Gm-Gg: AZuq6aIVWTNpCt2Or+2s04waqNDAdytH0Yku43+FQk4n//Tl+Slpn2lXUR8OWNBFycc BxDDokJZC+RZYRqas8sDnBM/07+rzAbto2nRGDmN3NvD5wbkGivVzmGtaMrpXRj8vBh02zeMUiX nRjmRxb28t1cuagPfhoSaGUK65g7HDmlItCVWbNh+a0OV/sb35FgTQuzlh9RjTzKpWonml/ZgJs dLT1DyGeTpNjQTtA+AwwjfAlcbq9Y8ucKEE8fM9rlvaQYGt4jCejr4IX5++E1W9yxBRTOkE63e2 NKzX9EwMu3X2X2CZYUCuFZHI2lKpyszmuRG7NXhoa3LX4W7ipzxNpanqJN3YLaMyxIiO9tW7MN+ i9WF76l+K2Vf0gURsGJuMmThvL90mX3xj5otclcw+r9vKNo/P2NuO/fqMY0qjsr27B/RmOKqUTc fF4I/uXFtWbaKn4AVm0OuKiQt/DFrlUw== X-Received: by 2002:a05:6000:2001:b0:436:3475:4737 with SMTP id ffacd0b85a97d-4379db8cfddmr32328493f8f.30.1771516346564; Thu, 19 Feb 2026 07:52:26 -0800 (PST) Received: from draszik.lan ([212.129.80.248]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43796a5ac7csm47748995f8f.7.2026.02.19.07.52.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Feb 2026 07:52:26 -0800 (PST) Message-ID: Subject: Re: [PATCH v7 5/6] power: supply: max77759: add charger driver From: =?ISO-8859-1?Q?Andr=E9?= Draszik To: amitsd@google.com, Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lee Jones , Greg Kroah-Hartman , Badhri Jagan Sridharan , Heikki Krogerus , Peter Griffin , Tudor Ambarus , Alim Akhtar , Mark Brown , Matti Vaittinen , Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, RD Babiera , Kyle Tso Date: Thu, 19 Feb 2026 15:52:55 +0000 In-Reply-To: <20260218-max77759-charger-v7-5-e8d907ce69c5@google.com> References: <20260218-max77759-charger-v7-0-e8d907ce69c5@google.com> <20260218-max77759-charger-v7-5-e8d907ce69c5@google.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-2+build4 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi Amit, I was trying out your series and noticed a few things that I didn't before: On Wed, 2026-02-18 at 21:59 +0000, Amit Sunil Dhamne via B4 Relay wrote: [...] >=20 > diff --git a/drivers/power/supply/max77759_charger.c b/drivers/power/supp= ly/max77759_charger.c > new file mode 100644 > index 0000000000000000000000000000000000000000..035f16822d85de94c7707ce11= c49345c714cd559 > --- /dev/null > +++ b/drivers/power/supply/max77759_charger.c [...] > + dev_err(chg->dev, "Invalid mode transition from %d to %d", > + chg->mode, mode); All your format strings are missing the final \n throughout this patch. [...] > +static int max77759_charger_probe(struct platform_device *pdev) > +{ > + struct regulator_config chgin_otg_reg_cfg; > + struct power_supply_config psy_cfg; > + struct device *dev =3D &pdev->dev; > + struct max77759_charger *chg; > + int ret; > + > + device_set_of_node_from_dev(dev, dev->parent); > + chg =3D devm_kzalloc(dev, sizeof(*chg), GFP_KERNEL); > + if (!chg) > + return -ENOMEM; > + > + platform_set_drvdata(pdev, chg); > + chg->dev =3D dev; > + chg->regmap =3D dev_get_regmap(dev->parent, "charger"); > + if (!chg->regmap) > + return dev_err_probe(dev, -ENODEV, "Missing regmap"); > + > + ret =3D devm_mutex_init(dev, &chg->lock); > + if (ret) > + return dev_err_probe(dev, ret, "Failed to initialize lock"); > + > + ret =3D devm_mutex_init(dev, &chg->retry_lock); > + if (ret) > + return dev_err_probe(dev, ret, > + =C2=A0=C2=A0=C2=A0=C2=A0 "Failed to initialize retry_lock"); > + > + psy_cfg.fwnode =3D dev_fwnode(dev); > + psy_cfg.drv_data =3D chg; > + chg->psy =3D devm_power_supply_register(dev, &max77759_charger_desc, > + =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 &psy_cfg); > + if (IS_ERR(chg->psy)) > + return dev_err_probe(dev, -EPROBE_DEFER, > + =C2=A0=C2=A0=C2=A0=C2=A0 "Failed to register psy, ret=3D%ld", > + =C2=A0=C2=A0=C2=A0=C2=A0 PTR_ERR(chg->psy)); Why are you returning -EPROBE_DEFER here instead of the original error? Thi= s is quite unusual. Cheers, Andre'