From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Sunny Patel <nueralspacetech@gmail.com>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: Fix reference leak in of_i2c_register_devices
Date: Thu, 17 Apr 2025 00:11:53 +0200 [thread overview]
Message-ID: <f4742d44-0ea3-4af1-91ab-8bb5af6d781b@wanadoo.fr> (raw)
In-Reply-To: <20250414154224.27836-1-nueralspacetech@gmail.com>
Le 14/04/2025 à 17:42, Sunny Patel a écrit :
> Fix a potential reference leak in of_i2c_register_devices where the
> reference to the node is not released if device registration fails.
> This ensures proper reference management and avoids memory leaks.
>
> Signed-off-by: Sunny Patel <nueralspacetech@gmail.com>
> ---
> drivers/i2c/i2c-core-of.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i2c/i2c-core-of.c b/drivers/i2c/i2c-core-of.c
> index 02feee6c9ba9..7c50905de8f1 100644
> --- a/drivers/i2c/i2c-core-of.c
> +++ b/drivers/i2c/i2c-core-of.c
> @@ -107,6 +107,7 @@ void of_i2c_register_devices(struct i2c_adapter *adap)
> "Failed to create I2C device for %pOF\n",
> node);
> of_node_clear_flag(node, OF_POPULATED);
> + of_node_put(node);
> }
> }
>
Hi,
Why resending this patch?
it is the same has before,, so my understanding is still the same and I
still think that it is just wrong.
See [1].
CJ
[1]:
https://lore.kernel.org/all/1dacfce7-c66d-44c6-9a0c-2dd00bc24ffc@wanadoo.fr/
prev parent reply other threads:[~2025-04-16 22:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-06 13:48 Sunny Patel
2025-04-06 18:06 ` Christophe JAILLET
[not found] ` <CAGNPQObiZA76gva-+_DY8TtpEiJfLL3QDoONYST4npOSkgZ+5g@mail.gmail.com>
2025-04-08 19:04 ` Christophe JAILLET
2025-04-14 15:42 ` Sunny Patel
2025-04-16 22:11 ` Christophe JAILLET [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4742d44-0ea3-4af1-91ab-8bb5af6d781b@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nueralspacetech@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®