From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB006C388F7 for ; Wed, 4 Nov 2020 00:56:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9E106223C7 for ; Wed, 4 Nov 2020 00:56:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730170AbgKDA4J (ORCPT ); Tue, 3 Nov 2020 19:56:09 -0500 Received: from smtprelay0093.hostedemail.com ([216.40.44.93]:44658 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729163AbgKDA4J (ORCPT ); Tue, 3 Nov 2020 19:56:09 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay05.hostedemail.com (Postfix) with ESMTP id 7140518029121; Wed, 4 Nov 2020 00:56:08 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: baby40_1802367272bd X-Filterd-Recvd-Size: 1681 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf11.hostedemail.com (Postfix) with ESMTPA; Wed, 4 Nov 2020 00:56:07 +0000 (UTC) Message-ID: Subject: Re: [RFC PATCH] .clang-format: Remove conditional comments From: Joe Perches To: Miguel Ojeda Cc: clang-built-linux , LKML Date: Tue, 03 Nov 2020 16:56:06 -0800 In-Reply-To: References: <363325b4a85f094ba9cf06301dd022912ec79d03.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2020-11-03 at 22:33 +0100, Miguel Ojeda wrote: > It is, yeah; however, the concern is that there may be developers > running an old clang-format from their distro (i.e. not using it for > compiling the kernel). I expect that'd be extremely unusual. > We need to compare the functionality advantage > vs. the inconvenience of installing a current LLVM. The best would be > to ask whoever is using it right now, but there is no easy way to do > that -- many will only notice when the change is actually pushed :-) Do remember that this patch is for the current kernel and not any old version that someone might be compiling. The current kernel _requires_ clang 10.0+ and that would obviously provide clang-format 10+ as well.