From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751966AbcLFAgJ (ORCPT <rfc822;w@1wt.eu>);
        Mon, 5 Dec 2016 19:36:09 -0500
Received: from mga01.intel.com ([192.55.52.88]:38209 "EHLO mga01.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751388AbcLFAgF (ORCPT <rfc822;Linux-kernel@vger.kernel.org>);
        Mon, 5 Dec 2016 19:36:05 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,750,1477983600"; 
   d="scan'208";a="1095041585"
Subject: Re: [PATCH v1 0/4] perf report: Show inline stack
To: acme@kernel.org, jolsa@kernel.org
References: <1480431344-1644-1-git-send-email-yao.jin@linux.intel.com>
Cc: Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com
From: "Jin, Yao" <yao.jin@linux.intel.com>
Message-ID: <f475f908-848e-152b-0e50-ca5b442087d1@linux.intel.com>
Date: Tue, 6 Dec 2016 08:35:28 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <1480431344-1644-1-git-send-email-yao.jin@linux.intel.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Any comments on this patch series?

Thanks

Jin Yao


On 11/29/2016 10:55 PM, Jin Yao wrote:
> It would be useful for perf to support a mode to query the
> inline stack for callgraph addresses. This would simplify
> finding the right code in code that does a lot of inlining.
>
> For example, the c code:
>
> static inline void f3(void)
> {
>          int i;
>          for (i = 0; i < 1000;) {
>
>                  if(i%2)
>                          i++;
>                  else
>                          i++;
>          }
>          printf("hello f3\n");   /* D */
> }
>
> /* < CALLCHAIN: f2 <- f1 > */
> static inline void f2(void)
> {
>          int i;
>          for (i = 0; i < 100; i++) {
>                  f3();   /* C */
>          }
> }
>
> /* < CALLCHAIN: f1 <- main > */
> static inline void f1(void)
> {
>          int i;
>          for (i = 0; i < 100; i++) {
>                  f2();   /* B */
>          }
> }
>
> /* < CALLCHAIN: main <- TOP > */
> int main()
> {
>          struct timeval tv;
>          time_t start, end;
>
>          gettimeofday(&tv, NULL);
>          start = end = tv.tv_sec;
>          while((end - start) < 5) {
>                  f1();   /* A */
>                  gettimeofday(&tv, NULL);
>                  end = tv.tv_sec;
>          }
>          return 0;
> }
>
> The printed inline stack is:
>
> 0.05%  test2    test2              [.] main
>         |
>         ---/home/perf-dev/lck-2867/test/test2.c:27 (inline)
>            /home/perf-dev/lck-2867/test/test2.c:35 (inline)
>            /home/perf-dev/lck-2867/test/test2.c:45 (inline)
>            /home/perf-dev/lck-2867/test/test2.c:61 (inline)
>
> I tag A/B/C/D in above c code to indicate the source line,
> actually the inline stack is equal to:
>
> 0.05%  test2    test2              [.] main
>         |
>         ---D
>            C
>            B
>            A
>
> Jin Yao (4):
>    perf report: Find the inline stack for a given address
>    perf report: Create a new option "--inline"
>    perf report: Show inline stack in stdio mode
>    perf report: Show inline stack in browser mode
>
>   tools/perf/Documentation/perf-report.txt |   4 +
>   tools/perf/builtin-report.c              |   2 +
>   tools/perf/ui/browsers/hists.c           |  98 ++++++++++++++-
>   tools/perf/ui/stdio/hist.c               |  56 ++++++++-
>   tools/perf/util/hist.c                   |   5 +
>   tools/perf/util/sort.h                   |   1 +
>   tools/perf/util/srcline.c                | 206 ++++++++++++++++++++++++++-----
>   tools/perf/util/symbol.h                 |   3 +-
>   tools/perf/util/util.h                   |  15 +++
>   9 files changed, 356 insertions(+), 34 deletions(-)
>