mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Alim Akhtar <alim.akhtar@samsung.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Cc: krzysztof.kozlowski+dt@linaro.org, avri.altman@wdc.com,
	bvanassche@acm.org, martin.petersen@oracle.com,
	chanho61.park@samsung.com, linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH] scsi: ufs: host: ufs-exynos: staticize fsd_ufs_drvs
Date: Thu, 11 Aug 2022 14:53:11 +0300	[thread overview]
Message-ID: <f47638a3-08e6-2ea0-5e1a-b482f3687142@linaro.org> (raw)
In-Reply-To: <20220811113550.31914-1-alim.akhtar@samsung.com>

On 11/08/2022 14:35, Alim Akhtar wrote:
> struct fsd_ufs_drvs is not used outside this file, so made it static.
> This fixes sparse warning:
> 
> drivers/ufs/host/ufs-exynos.c:1721:28: sparse: sparse:
> symbol 'fsd_ufs_drvs' was not declared. Should it be static?
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: 216f74e8059a ("scsi: ufs: host: ufs-exynos: Add support for FSD UFS HCI")
> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>

This should be static const.

Best regards,
Krzysztof

      reply	other threads:[~2022-08-11 11:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20220811114614epcas5p29046e326acc8d13824479504e80a0d49@epcas5p2.samsung.com>
2022-08-11 11:35 ` Alim Akhtar
2022-08-11 11:53   ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f47638a3-08e6-2ea0-5e1a-b482f3687142@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=alim.akhtar@samsung.com \
    --cc=avri.altman@wdc.com \
    --cc=bvanassche@acm.org \
    --cc=chanho61.park@samsung.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®