From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758049AbcHCRF4 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 3 Aug 2016 13:05:56 -0400
Received: from mail-pf0-f173.google.com ([209.85.192.173]:35730 "EHLO
	mail-pf0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754020AbcHCRFx (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 3 Aug 2016 13:05:53 -0400
Subject: Re: [PATCH v0 2/4] i2c: bcm-kona: Use complete() instead of
 complete_all()
To: Daniel Wagner <wagi@monom.org>, Wolfram Sang <wsa@the-dreams.de>
References: <1470225791-16613-1-git-send-email-wagi@monom.org>
 <1470225791-16613-3-git-send-email-wagi@monom.org>
Cc: Beniamino Galvani <b.galvani@gmail.com>, Kamal Dasu <kdasu.kdev@gmail.com>,
        Ray Jui <rjui@broadcom.com>, Tim Kryger <tim.kryger@linaro.org>,
        linux-amlogic@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
        bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org,
        Daniel Wagner <daniel.wagner@bmw-carit.de>
From: Ray Jui <ray.jui@broadcom.com>
Message-ID: <f47779be-5e1e-cbf2-b590-fdd9a0e80917@broadcom.com>
Date: Wed, 3 Aug 2016 09:38:11 -0700
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:47.0) Gecko/20100101
 Thunderbird/47.0
MIME-Version: 1.0
In-Reply-To: <1470225791-16613-3-git-send-email-wagi@monom.org>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Daniel,

On 8/3/2016 5:03 AM, Daniel Wagner wrote:
> From: Daniel Wagner <daniel.wagner@bmw-carit.de>
>
> There is only one waiter for the completion, therefore there
> is no need to use complete_all(). Let's make that clear by
> using complete() instead of complete_all().
>
> The usage pattern of the completion is:
>
> bcm_kona_send_i2c_cmd()
>   reinit_completion()
>   ...
>   bcm_kona_i2c_send_cmd_to_ctrl()
>   ...
>   wait_for_completion_timeout()
>
> Signed-off-by: Daniel Wagner <daniel.wagner@bmw-carit.de>
> ---
>  drivers/i2c/busses/i2c-bcm-kona.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-bcm-kona.c b/drivers/i2c/busses/i2c-bcm-kona.c
> index ac9f476..f987432 100644
> --- a/drivers/i2c/busses/i2c-bcm-kona.c
> +++ b/drivers/i2c/busses/i2c-bcm-kona.c
> @@ -229,7 +229,7 @@ static irqreturn_t bcm_kona_i2c_isr(int irq, void *devid)
>  		       dev->base + TXFCR_OFFSET);
>
>  	writel(status & ~ISR_RESERVED_MASK, dev->base + ISR_OFFSET);
> -	complete_all(&dev->done);
> +	complete(&dev->done);
>
>  	return IRQ_HANDLED;
>  }
>

This change looks good me! Thanks.

Acked-by: Ray Jui <ray.jui@broadcom.com>