From: Richard Fitzgerald <rf@opensource.cirrus.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
patches@opensource.cirrus.com
Subject: Re: [PATCH] ASoC: soc-core: Create device_link to ensure correct suspend order
Date: Tue, 2 Jun 2026 14:34:53 +0100 [thread overview]
Message-ID: <f47bf7df-f1fc-4d77-9293-938e20600826@opensource.cirrus.com> (raw)
In-Reply-To: <0aef9b01-65fa-473e-b999-0c5b285009c5@sirena.org.uk>
On 02/06/2026 2:31 pm, Mark Brown wrote:
> On Mon, Jun 01, 2026 at 03:28:35PM +0100, Richard Fitzgerald wrote:
>
>> + for_each_card_components(card, component) {
>> + if (!device_link_add(card->dev, component->dev,
>> + DL_FLAG_AUTOREMOVE_CONSUMER)) {
>> + dev_warn(card->dev, "Failed to create device link to %s\n",
>> + dev_name(component->dev));
>> + ret = -EINVAL;
>> + goto probe_end;
>
> Do we still have devices registering separate components with the same
> device for DMA and DAI operations? They'd end up duplicating the links
> here.
Ok, weird, but I agree it's possible for one driver to register multiple
components. I'll make a V2 that skips the device link if the component
dev is the same as the card dev.
next prev parent reply other threads:[~2026-06-02 13:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-01 14:28 Richard Fitzgerald
2026-06-02 8:46 ` Charles Keepax
2026-06-02 13:31 ` Mark Brown
2026-06-02 13:34 ` Richard Fitzgerald [this message]
2026-06-02 13:46 ` Mark Brown
2026-06-02 13:55 ` Richard Fitzgerald
2026-06-02 14:52 ` Mark Brown
2026-06-05 8:55 ` Richard Fitzgerald
2026-06-05 16:32 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f47bf7df-f1fc-4d77-9293-938e20600826@opensource.cirrus.com \
--to=rf@opensource.cirrus.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®