mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alexander Gordeev <agordeev@linux.ibm.com>
To: "Mike Rapoport (Microsoft)" <rppt@kernel.org>
Cc: Heiko Carstens <hca@linux.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Christian Borntraeger <borntraeger@linux.ibm.com>,
	David Hildenbrand <david@kernel.org>,
	Sven Schnelle <svens@linux.ibm.com>,
	Vlastimil Babka <vbabka@kernel.org>,
	linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org
Subject: Re: [PATCH 12/14] s390/sclp_ftp: Replace get_zeroed_page() with kzalloc()
Date: Mon, 16 Nov 2026 16:27:18 +0100	[thread overview]
Message-ID: <f47dc1fa-3def-4558-acb1-5b58a3ff226a-agordeev@linux.ibm.com> (raw)
In-Reply-To: <20261108-s390-sclp-ready-v1-12-3e7c90eb6676@kernel.org>

On Sun, Nov 08, 2026 at 10:58:43AM +0200, Mike Rapoport (Microsoft) wrote:
> sclp_ftp_et7() allocates the SCCB used for an HMC file transfer request
> and sclp_ftp_startup() allocates the SCCB used to read the SCLP info in
> the debug code.
> 
> These buffers can be allocated with kmalloc() as there's nothing special
> about them to go directly to the page allocator.
> 
> kmalloc() provides a better API that does not require ugly casts and
> kfree() does not need to know the size of the freed object.
> 
> Performance difference between kmalloc() and __get_free_pages() is not
> measurable as both allocators take an object/page from a per-CPU list for
> fast path allocations.
> 
> For the slow path the performance is anyway determined by the amount of
> reclaim involved rather than by what allocator is used.
> 
> Replace use of get_zeroed_page() with kzalloc() and free_page() with
> kfree().
> 
> Link: https://lore.kernel.org/all/635405e4-9423-4a25-a6e7-e03c8ea0bcbe@redhat.com
> Signed-off-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
> ---
>  drivers/s390/char/sclp_ftp.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/s390/char/sclp_ftp.c b/drivers/s390/char/sclp_ftp.c
> index 853492d53953c..c46fd056e9daf 100644
> --- a/drivers/s390/char/sclp_ftp.c
> +++ b/drivers/s390/char/sclp_ftp.c
> @@ -93,7 +93,7 @@ static int sclp_ftp_et7(const struct hmcdrv_ftp_cmdspec *ftp)
>  	int rc;
>  
>  	req = kzalloc_obj(*req);
> -	sccb = (void *) get_zeroed_page(GFP_KERNEL | GFP_DMA);
> +	sccb = kzalloc(PAGE_SIZE, GFP_KERNEL | GFP_DMA);
>  	if (!req || !sccb) {
>  		rc = -ENOMEM;
>  		goto out_free;
> @@ -155,7 +155,7 @@ static int sclp_ftp_et7(const struct hmcdrv_ftp_cmdspec *ftp)
>  	}
>  
>  out_free:
> -	free_page((unsigned long) sccb);
> +	kfree(sccb);
>  	kfree(req);
>  	return rc;
>  }
> @@ -250,7 +250,7 @@ int sclp_ftp_startup(void)
>  		return rc;
>  
>  #ifdef DEBUG
> -	info = get_zeroed_page(GFP_KERNEL);
> +	info = (unsigned long)kzalloc(PAGE_SIZE, GFP_KERNEL);

Hmm.. Why not make info struct sysinfo_2_2_2 * instead?

>  	if (info != 0) {
>  		struct sysinfo_2_2_2 *info222 = (struct sysinfo_2_2_2 *)info;
> @@ -262,7 +262,7 @@ int sclp_ftp_startup(void)
>  				 info222->lpar_number, info222->name);
>  		}
>  
> -		free_page(info);
> +		kfree((void *)info);
>  	}
>  #endif	/* DEBUG */
>  	return 0;

Thanks!

  parent reply	other threads:[~2026-11-16 15:27 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-08  8:58 [PATCH 00/14] s390/sclp: replace page allocator calls with k[mz]alloc() Mike Rapoport (Microsoft)
2026-11-08  8:58 ` [PATCH 01/14] s390/sclp_vt220: Replace get_zeroed_page() with kzalloc() Mike Rapoport (Microsoft)
2026-11-08  8:58 ` [PATCH 02/14] s390/sclp_config: " Mike Rapoport (Microsoft)
2026-11-08  8:58 ` [PATCH 03/14] s390/sclp_pci: " Mike Rapoport (Microsoft)
2026-11-08  8:58 ` [PATCH 04/14] s390/sclp_ctl: " Mike Rapoport (Microsoft)
2026-11-08  8:58 ` [PATCH 05/14] s390/sclp_con: " Mike Rapoport (Microsoft)
2026-11-08  8:58 ` [PATCH 06/14] s390/sclp_tty: " Mike Rapoport (Microsoft)
2026-11-08  8:58 ` [PATCH 07/14] s390/sclp: Replace __get_free_page() with kmalloc() Mike Rapoport (Microsoft)
2026-11-08  8:58 ` [PATCH 08/14] s390/sclp_sdias: " Mike Rapoport (Microsoft)
2026-11-08  8:58 ` [PATCH 09/14] s390/sclp_sd: " Mike Rapoport (Microsoft)
2026-11-08  8:58 ` [PATCH 10/14] s390/sclp_cmd: Replace page allocator calls with kzalloc() Mike Rapoport (Microsoft)
2026-11-08  8:58 ` [PATCH 11/14] s390/sclp_cpi: Replace get_zeroed_page() " Mike Rapoport (Microsoft)
2026-11-08  8:58 ` [PATCH 12/14] s390/sclp_ftp: " Mike Rapoport (Microsoft)
2026-11-16 15:26   ` Heiko Carstens
2026-11-16 15:27   ` Alexander Gordeev [this message]
2026-11-08  8:58 ` [PATCH 13/14] s390/sclp_mem: Replace page allocator calls with k[mz]alloc() Mike Rapoport (Microsoft)
2026-11-08  8:58 ` [PATCH 14/14] s390/sclp_ap: Replace get_zeroed_page() with kzalloc() Mike Rapoport (Microsoft)
2026-11-16 15:28 ` [PATCH 00/14] s390/sclp: replace page allocator calls with k[mz]alloc() Heiko Carstens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f47dc1fa-3def-4558-acb1-5b58a3ff226a-agordeev@linux.ibm.com \
    --to=agordeev@linux.ibm.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=david@kernel.org \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=rppt@kernel.org \
    --cc=svens@linux.ibm.com \
    --cc=vbabka@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®