From: Valentin Schneider <valentin.schneider@arm.com>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Morten Rasmussen <Morten.Rasmussen@arm.com>
Subject: Re: [PATCH v2 1/3] sched/fair: fix rounding issue for asym packing
Date: Wed, 19 Dec 2018 15:11:42 +0000 [thread overview]
Message-ID: <f48118ab-8782-a096-9299-58c6b8d384bb@arm.com> (raw)
In-Reply-To: <CAKfTPtCVqSYOC_GUdBm8_5KNMNEwXdf77mXL4SDB4_G5_iE0iA@mail.gmail.com>
On 19/12/2018 15:05, Vincent Guittot wrote:
[...]
>> True, I had a look at the trace and there doesn't seem to be any running
>> task on that CPU. That's a separate matter however - the rounding issues
>> can happen regardless of the wl values.
>
> But it means that the rounding fix +1 works and your problems comes
> from something else
Oh yes, I never said it didn't work - I was doing some investigation on
the reason as to why we'd need this fix, because it's wasn't explicit from
the commit message.
The rounding errors are countered by the +1, yes, but I'd rather remove
the errors altogether and go for the snippet I suggested in my previous
reply.
next prev parent reply other threads:[~2018-12-19 15:11 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-14 16:01 [PATCH v2 0/3] sched/fair: some fixes for asym_packing Vincent Guittot
2018-12-14 16:01 ` [PATCH v2 1/3] sched/fair: fix rounding issue for asym packing Vincent Guittot
2018-12-18 17:32 ` Valentin Schneider
2018-12-19 8:32 ` Vincent Guittot
2018-12-19 11:58 ` Valentin Schneider
2018-12-19 13:39 ` Vincent Guittot
2018-12-19 14:59 ` Valentin Schneider
2018-12-19 15:05 ` Vincent Guittot
2018-12-19 15:11 ` Valentin Schneider [this message]
2018-12-19 15:20 ` Vincent Guittot
2018-12-19 15:30 ` Valentin Schneider
2018-12-19 15:54 ` Vincent Guittot
2018-12-14 16:01 ` [PATCH v2 2/3] sched/fair: trigger asym_packing during idle load balance Vincent Guittot
2018-12-17 16:59 ` Valentin Schneider
2018-12-18 8:17 ` Vincent Guittot
2018-12-18 12:00 ` Valentin Schneider
2018-12-14 16:01 ` [PATCH v2 3/3] sched/fair: fix unnecessary increase of balance interval Vincent Guittot
2018-12-17 16:56 ` Valentin Schneider
2018-12-18 9:32 ` Vincent Guittot
2018-12-18 11:46 ` Valentin Schneider
2018-12-18 13:23 ` Vincent Guittot
2018-12-18 14:09 ` Valentin Schneider
2018-12-19 8:27 ` Vincent Guittot
2018-12-19 11:16 ` Valentin Schneider
2018-12-19 13:29 ` Vincent Guittot
2018-12-19 15:54 ` Valentin Schneider
2018-12-19 16:54 ` Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f48118ab-8782-a096-9299-58c6b8d384bb@arm.com \
--to=valentin.schneider@arm.com \
--cc=Morten.Rasmussen@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®