From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754212AbdEJTam (ORCPT ); Wed, 10 May 2017 15:30:42 -0400 Received: from mout.web.de ([212.227.15.14]:63099 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752923AbdEJTak (ORCPT ); Wed, 10 May 2017 15:30:40 -0400 To: netdev@vger.kernel.org, "David S. Miller" Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Subject: [PATCH] net-procfs: Adjust buffer output in dev_mc_seq_show() Message-ID: Date: Wed, 10 May 2017 21:30:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:E2LoRWYXUlgbbXgA5fv9RZ4OA+i5gjtVnohAZQdtf/Sz8GtXB8Z zFVHLR//gnaIzwypcN+9FKT9bN3h+MT+s2CawZBZKFcbrxXDR9ndAX0mDiz1bPUCRjEUGN8 oD4F0G7FANPxHs1gG4BLyUUfWtxPw+IDBIz1ExgIZ7tjyH9YPNFXowh2oYvER5+hxRRsrDN 4LbTb8pjizzJp2bhBOpMQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:yNrMWN0ULtc=:XXJjFqoQBZZb29Hq5gcu7z g1z62rnhFiTdl3lZBE9VJb6u6t6hUO+8VQI/gA7nuFAmjjN7s43r+ApZ8K+qFFlpyZ3icTpW8 C3VpxkUp1km3++1+ZwPAvKQRriwdLSPMb6fCcbhrvEDcMYsHxtuwzmTqAjzbDpBdTNma2CKLH aXDVjYoo1Tn+5BWMd15TBNBURFABR/G/8IRfgalX3pnUmeKeshVKT+BRSasHo1fzm6gl2NAqC 4tpV7Dx1rt3HjrKyu8TsthnL4eCz28vuhaAN/rY4M1LxwxLJOJo0pXjWblhmIM+4K8QLOFSTF wX3wxD5p5GShl8RFH9Wx3iQKQVAyEeKaJ05mVJB1Mm+f14ZPWJ2TseyKjDnlw5NtTfQ94J8wn Zv+36vKodIbb1L2t8fJ1/QWeX+zqPZpO2BhoRpBexRqXb9mbVKxmChiPjckQkggHUqR9yMKNM w1tPR8FLG0+u9Oui6UmdVVnNevblWG56NK4ezrEyqGibDRn2GKBI4/NnB6Uy5rIHtQLdF9Dcr Ih5K/9kfgWl4AequSiBfJHjAec90A/+f0k0Bzq7VJIie0yVwHEQorAi8L+fyQn10nMaKorOgk tK0+w5r/ZOvSV0R23Cnxbqc78PFZR7NnSZEKTAeqvOYu7kNLlmOLFVGltIJFacqa/DSoDAQ2f KvWP81tvIq2KvXlljNfFuHAF5Cogw/TI9p4ZQgkaWOEcrKS3tbP8/jDcUZCfj6WEPjNM4ccvg TYE6EZZLo+sAZxm2Uz15f4grn26OGFTKgI+8D1rDSJ0ITBAsXm5dkyIkuGyIqijrvhemzED8P 6YQpmXE Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 10 May 2017 21:17:43 +0200 * Use a special format string specification for the desired output of the array "addr" into a sequence. This issue was detected by using the Coccinelle software. * Delete the local variable "i" and a call of the function "seq_putc" which became unnecessary with this refactoring. Signed-off-by: Markus Elfring --- net/core/net-procfs.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/net/core/net-procfs.c b/net/core/net-procfs.c index 14d09345f00d..6aa427a2fb98 100644 --- a/net/core/net-procfs.c +++ b/net/core/net-procfs.c @@ -363,15 +363,9 @@ static int dev_mc_seq_show(struct seq_file *seq, void *v) netif_addr_lock_bh(dev); netdev_for_each_mc_addr(ha, dev) { - int i; - seq_printf(seq, "%-4d %-15s %-5d %-5d ", dev->ifindex, dev->name, ha->refcount, ha->global_use); - - for (i = 0; i < dev->addr_len; i++) - seq_printf(seq, "%02x", ha->addr[i]); - - seq_putc(seq, '\n'); + seq_printf(seq, "%*phN\n", dev->addr_len, ha->addr); } netif_addr_unlock_bh(dev); return 0; -- 2.12.3