From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2065.outbound.protection.outlook.com [40.107.236.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48052647 for ; Fri, 27 Dec 2024 06:48:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.236.65 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735282131; cv=fail; b=pDVoPsQx3YSj1c+HhP3f1gYYkXj8y/TXIXmL8v5gpJ2qG/89zDIDe/4mOza2ua8oMELx8t8bDqDkZ0TsEWFB4SAD1IuCu5jsLNgBkuip6Yr9w4Wf7bieZVqIBu0cCXuxrNHV3bAzHA9f9itpbR29RVxrAYb7pooRH6SLws5FxIM= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735282131; c=relaxed/simple; bh=8o8xmhqXFxFq6jcVoLk/a6hjcDLof3QQXP16LNdYc8E=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=CdPj+nzmZdQ08XNbHrrFw859cy71aYZdFqIo8GS/0NCYf+rYvZ4MnNMVfD1elkQ3QLfGEASPK4/dIHsex38aroLcStGC/L8KoJ5om8QfEAEGMqyb2qxx+dF4kkdTm1F9KYTVm6i0356bKZIhDsL29gnInITxXFnsBmLBM7gUsPE= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=ozmpc2YK; arc=fail smtp.client-ip=40.107.236.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="ozmpc2YK" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=C9NczN9PwHRIvuMTMFx3ERmKnqGULpsPqY9dFQDyAh6G4N5bXXoBNAqyr0f9IQdMEEob5zajzsmMkcgNc4A6jkJoz9cuEZmzzDcR8Cvq1U0/0lTmCxlHR56t0CpIkXUJE7SRblMLodXo6U1bqmFT7vtkFANSl+dDLDgPgfgySoNdtUv4iB6odPUJTR11FHfJGI7D5RoPc/ESgL0Vp0yQ7E32l6EBW5EztKh4JZ4BiX08nRqQIkuPTJjTM350/5LJbGx99UOqO8fCuG4BV011VBON55m91AERNXkcThYzDKwALqEXj3/Ck7uI5vKNSLI3PqKWDRGYQPr/lKVDTbaFrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E6hpPIQITjS2DYkUK/KLu8WfyE241fKxbwcGfy34PHI=; b=hZIVzFMbTM2QMMYVetJrxKj0yrWoEiUCXqSzLyTdmJRKn+cxgAxhVXev2yCn3X0hujWtFM+F/39UGbZSOGKDTFTFZvnV3suaQ8EvPR8ILd0FVm4ubxPpXg+SBNu4mvm5kzQNpJybYXisK7TAvxxHQCSzd/2fwjo0lgPUZqlTq2Ux+ltPo92aWTbKgFMi0TqBDeRhCnJ6RsmtYygPKUXg0Ll/vSns65aEDfdEv90mdSZtcZ3udo2EoI34rucJ4koRVhA5/5vjzIupnxiFQnF0noobdTi1C/eL89t1WibkUer+vGuO9pzeSiU/iHKTrYu92zKxrDKX75y+4fL6/O98fg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linux.dev smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E6hpPIQITjS2DYkUK/KLu8WfyE241fKxbwcGfy34PHI=; b=ozmpc2YKSjdqiWGqcmS0jsmVMDwQ1ImBc6x0bSJ26ey9726xpQEGSgs8C33UFmPXcJClVtJ0Bzn9ZlcsgK42tRpWYO35EOLU5MTEjMXVtk0COGxb4rDKbBGp/lhA447AZSQ00aygH50QJfcDU/WPo+sqQD/3fF7y/HPL1jNF/ow= Received: from MW4PR03CA0049.namprd03.prod.outlook.com (2603:10b6:303:8e::24) by CYYPR12MB8937.namprd12.prod.outlook.com (2603:10b6:930:cb::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8293.15; Fri, 27 Dec 2024 06:48:41 +0000 Received: from SJ1PEPF00002310.namprd03.prod.outlook.com (2603:10b6:303:8e:cafe::1c) by MW4PR03CA0049.outlook.office365.com (2603:10b6:303:8e::24) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8293.16 via Frontend Transport; Fri, 27 Dec 2024 06:48:41 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ1PEPF00002310.mail.protection.outlook.com (10.167.242.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8293.12 via Frontend Transport; Fri, 27 Dec 2024 06:48:40 +0000 Received: from [10.252.205.52] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 27 Dec 2024 00:48:35 -0600 Message-ID: Date: Fri, 27 Dec 2024 12:18:27 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] psi: Fix race when task wakes up before psi_sched_switch() adjusts flags To: Chengming Zhou , Johannes Weiner , Suren Baghdasaryan , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , CC: Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , "Gautham R. Shenoy" References: <20241227061941.2315-1-kprateek.nayak@amd.com> Content-Language: en-US From: K Prateek Nayak In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00002310:EE_|CYYPR12MB8937:EE_ X-MS-Office365-Filtering-Correlation-Id: 705f030f-1b38-48cf-e21c-08dd26427fcf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|7416014|376014|36860700013|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?NDZFRW5TSi9kWkdpSHRZTldiVUZrY1hTNzVPeklFaE5jR3lod29ZenVYMlBQ?= =?utf-8?B?RkVmcUtBTjZvak1CcnlZT3NWTUFaS3NrSUgweTJCZDl2U05HcHBtaTNLaHVX?= =?utf-8?B?cUl4WDh5cVNud24wenRvKzZGYlU5ZzFvVUxNQ0NvVmN3c0hWayszKy92VE9z?= =?utf-8?B?QVdrY0pBTnpRazhkdCtqOE1HREtrUU5tRUMvbGZ0ZUNIRnZVeVpBSkErSTRK?= =?utf-8?B?NUNVeG42VmZNemRNbGxPZ2M1QjcwY0N5VGlCbHhpUDVGSi9aTlVWRWVGN0xU?= =?utf-8?B?UHc0M3FldElWT2JEZlBFdTM3QlBNNUY1WjNvbnkzaHU0bEhqU1VpMGl2bks4?= =?utf-8?B?cUhrYlFmS0UxOGtwYyttcmlrSzE5ekhMbjNGRFUrWm5XNXR6Yk9EWmZPSlBT?= =?utf-8?B?eWxSTi9DN25kS3U5SjdQT1JxSEMvbDJTS2lMN2NaM0NTdENUemxxUjFUb3pm?= =?utf-8?B?WFU1Q1lsSGthWlVtYWN1amZkdUdzSjY0azlvd3M2VzNwbitGNXE1UmVqcE9P?= =?utf-8?B?OVNtQzM5NEk2dFd2cC9WTEpIQ2NiWlE3b3d4NzZQblA3cklWTWZQTFBFbDA4?= =?utf-8?B?bitXaVhqL1FvZ3VHdEtuUjZJWU1aOWNDTWYxOG9LZlJOQytreDBzdG15WVNl?= =?utf-8?B?SENRSmIvMVZmUFMvZEE3VWtaOGIxY0VBL2hMMjZ6aVhVMUh3RmJIM2pZOWpS?= =?utf-8?B?Z2dQOStTd1VqSlZWa3IySVlSekpjK2JoRHBmc1c2Zm40OFA1ampSdmM3TDBS?= =?utf-8?B?cmUyZVFyQTlwVGVqSVNjNDdZcVVjSVNIa01kYTJQajZOSTdnQ3A4ODhDcHo2?= =?utf-8?B?YlV2TTJkRXBvcWNObGlGbWhuMmVWYk0reStJTzk1M1JuN295eDNjZmF4K2lZ?= =?utf-8?B?N1EyUCtOZFBURDRNR2x5NCttMUFSUXVRYTJUeURXNE9Qb0dCSE80Y1JHNC9Z?= =?utf-8?B?N2ZGa0NCMHdvWmJBWjNsbjVJZmZFY3dsTHE0TSt5d21yQzdPcmJLUHd6eUto?= =?utf-8?B?M0EwYTRNNWJiL2VnMFRJT1ZqYjJubHkzbHZ4VmhjMXNnSytCQklBaFhZbDNW?= =?utf-8?B?UExFUXlaNlNXY0NQVU1zS08yVmxCT1cxWWxYNEJTMFBLRXNadXRsWnZJbEJ6?= =?utf-8?B?cUQ4eWFtemVnSE9LQjZSSlRYWmlNVEtTRGFMYnlYQk1YN2VwNjhKN3NiVzBl?= =?utf-8?B?ZTJVTGRyVU5ZTm9IcHk4Q3pyUi9sTlJaaUhMK0lVT05iVlpaZ29IOXlLOUtl?= =?utf-8?B?OHMra004OHo3eVU1MkpHZzVFU3oreWkyZUdWT2lJN3BYd1c2cWRKWnF3WlVD?= =?utf-8?B?bklrYWduMWVDaGxRZ1luYTRGbCtzLzF1RzJYc2RDWlRGdW4rLzc3UFBjN1Mz?= =?utf-8?B?WnhBK09od0pIV1dCc1hXdkx4cysxQU10YnUza1FFcEkxZDVRazlhUXpJeVZV?= =?utf-8?B?ZTdIbXplcnRUaEt1dXZ6a3pyY0hTdHhQTElaMHhpRy9qMGhHTzlSVWdIRlN1?= =?utf-8?B?cWZGQzhSbFdlT3RsVC9zSUl3WVRpS2RWODd1SGQxQzRCemNyZjY1WTRPSXhn?= =?utf-8?B?TnhqQW5SMHQrNWdiWlFyemxIYTEwN3NNZHBLcTdFblEyMUdSditDeVllVVJa?= =?utf-8?B?YWg1eElKOHVlU1RRb0ZvVzNNSWxKNVh1bWJRTDZIYlp4OWYrT2JhZHBhL0dm?= =?utf-8?B?Yk54UHpYZzBtenY5bDBMY2JSTTQ5ZUFGNHByN2x4ZThUQlNiMGNCY3ExRW9O?= =?utf-8?B?bWtXcGg2UU0xRXZGcTRKemxRUDRXa1YzendXNWQrL3d0VXRkV09kdW52V1pw?= =?utf-8?B?Nk5ya2NRdThVQVp0bWxOL1VIMnpRRzJPOG9WVjFjZ25yakFleEdYTG1uaGV1?= =?utf-8?B?RkplTUNUdUNDUXVHdlNyRlVUc1ROeVlaaGRMU09ka3VXOGVNNTREVGsvcDNP?= =?utf-8?B?NW0zYlRpcGVQY3NEeW81b3JwRFZ0NTJvWDRscXZOaVFzVHc1N3pFMHFQMCs4?= =?utf-8?B?akZ2WHpRNk5BPT0=?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(7416014)(376014)(36860700013)(7053199007);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Dec 2024 06:48:40.8943 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 705f030f-1b38-48cf-e21c-08dd26427fcf X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00002310.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR12MB8937 On 12/27/2024 12:11 PM, Chengming Zhou wrote: > I just notice the return value of try_to_block_task() is not > used anymore, not a problem though. Proxy execution might use it soon enough so I'll let it be for now and prefer to clean it up later after those details are squashed :) > > Reviewed-by: Chengming Zhou Thanks a ton! > > Thanks! -- Thanks and Regards, Prateek