From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753371AbYITIdt (ORCPT ); Sat, 20 Sep 2008 04:33:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751096AbYITIdm (ORCPT ); Sat, 20 Sep 2008 04:33:42 -0400 Received: from ey-out-2122.google.com ([74.125.78.27]:23530 "EHLO ey-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751036AbYITIdl (ORCPT ); Sat, 20 Sep 2008 04:33:41 -0400 Message-ID: Date: Sat, 20 Sep 2008 01:33:40 -0700 From: "Steven Noonan" To: linux-kernel@vger.kernel.org Subject: Re: [PATCH] ftrace: mcount_addr defined but not used Cc: akpm@linux-foundation.org, mingo@elte.hu, "Steven Noonan" In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080920061659.GF25713@elte.hu> <1221897638-16272-1-git-send-email-steven@uplinklabs.net> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 20, 2008 at 1:31 AM, Steven Noonan wrote: > On Sat, Sep 20, 2008 at 1:00 AM, Steven Noonan wrote: >> >> /* >> - * Since MCOUNT_ADDR may point to mcount itself, we do not want >> - * to get it confused by reading a reference in the code as we >> - * are parsing on objcopy output of text. Use a variable for >> - * it instead. >> - */ >> -static unsigned long mcount_addr = MCOUNT_ADDR; >> - >> -/* > > This line looks like a typo. I think I screwed up a comment block > there. I'll re-submit a patch in a moment. > Nevermind, I read it wrong. diff is messing with my head.