From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754388AbYIWHXA (ORCPT ); Tue, 23 Sep 2008 03:23:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753223AbYIWHWu (ORCPT ); Tue, 23 Sep 2008 03:22:50 -0400 Received: from ey-out-2122.google.com ([74.125.78.27]:32215 "EHLO ey-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752917AbYIWHWt (ORCPT ); Tue, 23 Sep 2008 03:22:49 -0400 Message-ID: Date: Tue, 23 Sep 2008 00:22:47 -0700 From: "Steven Noonan" To: "Luis R. Rodriguez" Subject: Re: [ath9k-devel] ath9k: massive unexplained latency in 2.6.27 (rc5, rc6, probably others) Cc: linux-wireless , LKML , "Senthilkumar Balasubramanian" , "ath9k-devel@lists.ath9k.org" , "Luis Rodriguez" , "Johannes Berg" , "Ingo Molnar" In-Reply-To: <43e72e890809220901y162636fu63ed133f0a0c235@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=KOI8-R Content-Disposition: inline References: <43e72e890809201426x61c94bfej2dcda1c178be81b@mail.gmail.com> <20080922065453.GD19580@tesla> <20080922080632.GA20446@tesla> <43e72e890809220901y162636fu63ed133f0a0c235@mail.gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by alpha id m8N7NAdq026733 On Mon, Sep 22, 2008 at 9:01 AM, Luis R. Rodriguez wrote:> On Mon, Sep 22, 2008 at 8:11 AM, Steven Noonan wrote:>> On Mon, Sep 22, 2008 at 1:06 AM, Luis R. Rodriguez>> wrote:>>> Please test the following patch.>>>>>> diff --git a/drivers/net/wireless/ath9k/core.c b/drivers/net/wireless/ath9k/core.c>>> index c262ef2..9a51739 100644>>> --- a/drivers/net/wireless/ath9k/core.c>>> +++ b/drivers/net/wireless/ath9k/core.c>>> @@ -681,10 +681,12 @@ int ath_open(struct ath_softc *sc, struct ath9k_channel *initial_chan)>>> * Enable MIB interrupts when there are hardware phy counters.>>> * Note we only do this (at the moment) for station mode.>>> */>>> +#if 0>>> if (ath9k_hw_phycounters(ah) &&>>> ((sc->sc_ah->ah_opmode == ATH9K_M_STA) ||>>> (sc->sc_ah->ah_opmode == ATH9K_M_IBSS)))>>> sc->sc_imask |= ATH9K_INT_MIB;>>> +#endif>>> /*>>> * Some hardware processes the TIM IE and fires an>>> * interrupt when the TIM bit is set. For hardware>>>>>>> It didn't apply to -rc7, but I managed to apply it manually>> (apparently you made this for wireless-testing?) and added the #if 0.>> After 7 hours uptime with the driver, no apparent interrupt storm.>>>> I'll do more thorough testing later, but I have a 3 hour drive today,>> and some packing to do, so it'll need to wait a bit.>> Yeah I did it for wireless-testing. Good to hear this so far has> solved the issue. I'll port it to 27 and post it once I get your> blessings that this fixed it by a Tested-by.> Okay. I'm in Seattle now. Yes, it solved the issue, but surely an #if 0 isn't a proper solution.What's the actual bug here? I'm afraid the meaning of what's going onhere isn't exactly intuitive. Also, I'm doing an 8 hour run with this patch tonight. Maybe more,depends on when I wake up. ;) I think if this resolves the issue on two separate 8 hour runs, itshould be considered the solution to the issue, unless it resurfaces. - Steven{.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I