Re: [PATCH 2/2] ACPI: x86: s2idle: Add another ID to s2idle_dmi_table

[Luke Jones <luke@ljones.dev>]

On Wed, 2022-09-28 at 11:19 -0500, Mario Limonciello wrote:
> It's reported that "ASUSTeK COMPUTER INC. ROG Flow X16 GV601RW" has
> non-functional fans after resume when using the AMD codepath.  This
> issue is fixed using the Microsoft codepath.
> 
> Add the 3 variants of this system to the Microsoft codepath DMI
> table.
> * GV601RW
> * GV601RM
> * GV601RE
> 
> Link:
> https://www.reddit.com/r/linuxhardware/comments/wh50nd/compatibility_report_asus_rog_flow_x16_gv601rm/
> Link:
> https://gitlab.freedesktop.org/drm/amd/-/issues/2148#note_1571241
> Reported-by: Luke Jones <luke@ljones.dev>
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
>  drivers/acpi/x86/s2idle.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/drivers/acpi/x86/s2idle.c b/drivers/acpi/x86/s2idle.c
> index 3ae2ba74de92..0155c1d2d608 100644
> --- a/drivers/acpi/x86/s2idle.c
> +++ b/drivers/acpi/x86/s2idle.c
> @@ -451,6 +451,17 @@ static const struct dmi_system_id
> s2idle_dmi_table[] __initconst = {
>                         DMI_MATCH(DMI_PRODUCT_NAME, "ROG Flow X13
> GV301"),
>                 },
>         },
> +       {
> +               /*
> +                * ASUSTeK COMPUTER INC. ROG Flow X16 GV601RW_GV601RW
> +                *
> https://gitlab.freedesktop.org/drm/amd/-/issues/2148
> +                */
> +               .callback = lps0_prefer_microsoft,
> +               .matches = {
> +                       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER
> INC."),
> +                       DMI_MATCH(DMI_PRODUCT_NAME, "ROG Flow X16
> GV601"),
> +               },
> +       },
>         {}
>  };
>  

Hi Mario,

related dts here
https://gitlab.com/asus-linux/reverse-engineering/-/tree/master/GV601R