From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F29C8C433E9 for ; Wed, 17 Mar 2021 13:16:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A5B3D64F77 for ; Wed, 17 Mar 2021 13:16:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230417AbhCQNPo (ORCPT ); Wed, 17 Mar 2021 09:15:44 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:55017 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230196AbhCQNPN (ORCPT ); Wed, 17 Mar 2021 09:15:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615986913; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XZJdEeunzwNk70+oFRPGk8WEPnwuyPe914Z6NlRRz+8=; b=StAz4J2yULTMyaIAY5Wex22ZucLBmA/GthuW6PJqjGE1tfaIyADS3MN2B1WEqRnPg6lQV7 FqJtmdBOIven453idk/oRdARZkYsQGaqNN7MzpRoOOTjTlPWnRKCZoixg4iRhQULZQkKrf J3lESdgQnsfMvI8pUoaZXH6fpSuHXAg= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-204-SrsQ7Ue4PtKdEuaAd6jjww-1; Wed, 17 Mar 2021 09:15:10 -0400 X-MC-Unique: SrsQ7Ue4PtKdEuaAd6jjww-1 Received: by mail-wm1-f70.google.com with SMTP id l16so6214625wmc.0 for ; Wed, 17 Mar 2021 06:15:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:subject:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XZJdEeunzwNk70+oFRPGk8WEPnwuyPe914Z6NlRRz+8=; b=H7vLUvoWo/pIcac/gBxTD8I8OBECKKGEM0t7bihdzdRZdOtsXX/2e82lLEEToXv06D KGJuu2pnL7NYfe07b5z24iNhfd6iOwzt+jmhm5TWpekX5L/8xjbjNirYr6TArf2WI6lX 3o6r/PHfZd1Gw/9bjYZIRnrVtByWJ9yKkkuS5hGOmrTnXXHSVPhm4jqFSJF6PTReLCad Ts14d2Ncymonw5ZsvTa26M2j1WvlKyuQXfaiTgQLovTf5C3hJCsNLn16MAUAqQrcRVY7 yQ4EhR5tcpGFG0/1kEW3+aMllL6+mlyayU7pBkZhCN5ZWgkpHcsW+kGeN8pqgohHp18A /SWg== X-Gm-Message-State: AOAM530e9GLzPevwmgUcjTmjSYw7lWexptdIruLZPOK1FA3TWJHMRmkP kBDj7IMkRapLXb2jtB87JGcnZS1Ape4z1RWEa+qTwmVUuOtA2/ABdshVpdg3CUXSoEHejxeCnPn lxin/0vOGAhbbXlPnskZaagX9 X-Received: by 2002:adf:fac1:: with SMTP id a1mr4576709wrs.98.1615986909596; Wed, 17 Mar 2021 06:15:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyZ2dfEsieu9J241DYA3s8c2or2c3fDFAPaeacFxyxanimtAaKIxHG7SAHnH2UL0oytvdAGIA== X-Received: by 2002:adf:fac1:: with SMTP id a1mr4576689wrs.98.1615986909373; Wed, 17 Mar 2021 06:15:09 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id x8sm25487700wru.46.2021.03.17.06.15.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Mar 2021 06:15:08 -0700 (PDT) To: Sean Christopherson Cc: Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Alexander Graf , Yuan Yao References: <20210316184436.2544875-1-seanjc@google.com> <20210316184436.2544875-4-seanjc@google.com> From: Paolo Bonzini Subject: Re: [PATCH 3/4] KVM: VMX: Macrofy the MSR bitmap getters and setters Message-ID: Date: Wed, 17 Mar 2021 14:15:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210316184436.2544875-4-seanjc@google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/03/21 19:44, Sean Christopherson wrote: > + return (ret)true; \ I'm not sure if (void)true is amazing or disgusting, but anyway... > +BUILD_VMX_MSR_BITMAP_HELPER(bool, test, read) > +BUILD_VMX_MSR_BITMAP_HELPER(bool, test, write) > +BUILD_VMX_MSR_BITMAP_HELPER(void, clear, read, __) > +BUILD_VMX_MSR_BITMAP_HELPER(void, clear, write, __) > +BUILD_VMX_MSR_BITMAP_HELPER(void, set, read, __) > +BUILD_VMX_MSR_BITMAP_HELPER(void, set, write, __) ... I guess we have an armed truce where you let me do my bit manipulation magic and I let you do your macro magic. Still, I think gluing the variadic arguments with ## is a bit too much. This would be slightly less mysterious: +BUILD_VMX_MSR_BITMAP_HELPER(bool, vmx_test_msr_bitmap_, read, test_bit) +BUILD_VMX_MSR_BITMAP_HELPER(bool, vmx_test_msr_bitmap_, write, test_bit) +BUILD_VMX_MSR_BITMAP_HELPER(void, vmx_clear_msr_bitmap_, read, __clear_bit) +BUILD_VMX_MSR_BITMAP_HELPER(void, vmx_clear_msr_bitmap_, write, __clear_bit) +BUILD_VMX_MSR_BITMAP_HELPER(void, vmx_set_msr_bitmap_, read, __set_bit) +BUILD_VMX_MSR_BITMAP_HELPER(void, vmx_set_msr_bitmap_, write, __set_bit) And I also wonder if we really need to expand all six functions one at a time. You could remove the third argument and VMX_MSR_BITMAP_BASE_*, at the cost of expanding the inline functions' body twice in BUILD_VMX_MSR_BITMAP_HELPER. Thanks, Paolo