From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751453AbdIQG7D (ORCPT ); Sun, 17 Sep 2017 02:59:03 -0400 Received: from mout.web.de ([217.72.192.78]:61571 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750749AbdIQG7B (ORCPT ); Sun, 17 Sep 2017 02:59:01 -0400 Subject: [PATCH 2/2] [media] si2157: Improve a size determination in two functions From: SF Markus Elfring To: linux-media@vger.kernel.org, Antti Palosaari , Mauro Carvalho Chehab Cc: LKML , kernel-janitors@vger.kernel.org References: <87f4a386-ac11-87f5-2d22-7bfc0593de34@users.sourceforge.net> Message-ID: Date: Sun, 17 Sep 2017 08:58:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <87f4a386-ac11-87f5-2d22-7bfc0593de34@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:25b/UDDlB5TM6pEV+mFHosUtswRxN9IUz4PBIkfyHBt3TRLNihq blxxeeIpQ4vGIru1AjvL0VmN5pMvQ9RUi+eVIoTsdOCq1SvBmq0q6uaHtXtkh31HZ1sWHlD US7wRrxidgVVS3SdIu/GAHmmZ1X5kVCJ95EawFy3L3FDr+USZG/eta8Z029LLy1g5pdIV6C ypscaufBEU5OJWy2C9Iuw== X-UI-Out-Filterresults: notjunk:1;V01:K0:UZWeFPKpstk=:VOB73GAHaSfKsncmzCbez+ dR4GFvmIPev4m6xJTzel9OJ8hVdCB3ACrdSx/Y0yfZIK/y+JSuHWFD8zW0JOfjwgP6+i/zpmP y3vbX4JxFaXCJkBiQT17P2tdOOE95f7/qHMsotS4s3+RqETOwi6TPAtqo1gJZ9P5bCgzj4L45 lvmIH482n0/9V9SS01yrlWWNaOT3PB7EF9jBGXN91uMd+G5Ni8nVXgQvM4+RRdrPwcb697uvO atQCKBX23igDcC1L3qszMQLRGFQE3yWJXSVv/A7OIo37OlYy331BrUudG09cHtZnWWUpEkDrR ja6H0B5+mMMtujjh9YvDkr9dZ8Tjs6EWS5tcgOEgvc7OzMXL53tnhgr7B20aYFkZtXsaGN2Mg N3YUSEzQpVws0nygda/7Kb0qgtnRZx93y1kHtBWLD9fr6r8mHRXznscT4R6X8DI0TPWzHxPev i6LYVLygbou9mIZ8frJXC57JKfak1fto2AJ7fCRN7xQv9sQs1WArLRtKYAA5y69WrB/9sd7qp T7WGzoQPFmP+OlbM8TjuDt/DEuZdfaGrxkzk6qULoTt+yzKi1azKcVx6lM2O5eSEs+A8RW4YH MfPYnFChNPcEG4n/9FRAjrdSdozCBnfyaVUULTNXDkjQBUgPCOqVaVBiw2KEjb5DdVg5Wtk5X u6ymmo2J8lQ5amxTrXOn6YJNFREogvH12Q+sbVypNK3W23IDCux0DxWEkXY5vwS3qoSts066p SicJhWoyk5T2Pzg2gK9U//yUnVP0J2pZSWDZ40aC/I/BQZLfNeheq+K2uapo3f6PR767mzipz 7VxdoMJoXMHwSeejcKaGchqGaDMfBYM23HvHiRGeQZ5mDmAgrw= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sun, 17 Sep 2017 08:32:17 +0200 Replace the specification of data structures by variable references as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/media/tuners/si2157.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/tuners/si2157.c b/drivers/media/tuners/si2157.c index aefa85718496..e3e2027a5027 100644 --- a/drivers/media/tuners/si2157.c +++ b/drivers/media/tuners/si2157.c @@ -457,7 +457,7 @@ static int si2157_probe(struct i2c_client *client, if (ret) goto err_kfree; - memcpy(&fe->ops.tuner_ops, &si2157_ops, sizeof(struct dvb_tuner_ops)); + memcpy(&fe->ops.tuner_ops, &si2157_ops, sizeof(si2157_ops)); fe->tuner_priv = client; #ifdef CONFIG_MEDIA_CONTROLLER @@ -514,7 +514,7 @@ static int si2157_remove(struct i2c_client *client) media_device_unregister_entity(&dev->ent); #endif - memset(&fe->ops.tuner_ops, 0, sizeof(struct dvb_tuner_ops)); + memset(&fe->ops.tuner_ops, 0, sizeof(fe->ops.tuner_ops)); fe->tuner_priv = NULL; kfree(dev); -- 2.14.1