Re: [PATCH 4.19 00/36] 4.19.303-rc1 review

[Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>]

Hello Greg,

On 19/12/23 10:57 am, Daniel Díaz wrote:
> Hello!
> 

> 
> -----8<-----
>    In file included from /builds/linux/include/linux/list.h:9,
>                     from /builds/linux/include/linux/module.h:9,
>                     from /builds/linux/net/core/skbuff.c:41:
>    /builds/linux/net/core/skbuff.c: In function 'skb_segment':
>    /builds/linux/include/linux/kernel.h:847:43: warning: comparison of 
> distinct pointer types lacks a cast
>      847 |                 (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
>          |                                           ^~
>    /builds/linux/include/linux/kernel.h:861:18: note: in expansion of 
> macro '__typecheck'
>      861 |                 (__typecheck(x, y) && __no_side_effects(x, y))
>          |                  ^~~~~~~~~~~
>    /builds/linux/include/linux/kernel.h:871:31: note: in expansion of 
> macro '__safe_cmp'
>      871 |         __builtin_choose_expr(__safe_cmp(x, y), \
>          |                               ^~~~~~~~~~
>    /builds/linux/include/linux/kernel.h:880:25: note: in expansion of 
> macro '__careful_cmp'
>      880 | #define min(x, y)       __careful_cmp(x, y, <)
>          |                         ^~~~~~~~~~~~~
>    /builds/linux/net/core/skbuff.c:3630:32: note: in expansion of macro 
> 'min'
>     3630 |                 partial_segs = min(len, GSO_BY_FRAGS - 1) / mss;
>          |                                ^~~
> ----->8-----
> 

Note:

Caused by this commit:
98c6fb04f83b net: prevent mss overflow in skb_segment()

I don't see this commit being queued in other stable branches yet, 
5.4.y, 5.10.y, 5.15.y, 6.1.y, 6.6.y but only 4.19.y

Thanks,
Harshit

> Greetings!
> 
> Daniel Díaz
> daniel.diaz@linaro.org
> 
>