mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Luiz Capitulino <luizcap@redhat.com>
To: Pedro Falcato <pfalcato@suse.de>
Cc: "Vlastimil Babka (SUSE)" <vbabka@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Liam R. Howlett" <liam@infradead.org>,
	Lorenzo Stoakes <ljs@kernel.org>, Jann Horn <jannh@google.com>,
	David Hildenbrand <david@kernel.org>,
	Jakub Matena <matenajakub@gmail.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [REGRESSION] mremap() fails VMA expansion when VM_MIXEDMAP is set
Date: Fri, 23 Oct 2026 14:16:55 -0400	[thread overview]
Message-ID: <f49c5d8f-b83a-4b1f-ba91-07eabd0ed46e@redhat.com> (raw)
In-Reply-To: <attZIKD7GfoNeqbg@pedro-suse.tail5790ac.ts.net>



On 10/23/26 9:00 AM, Pedro Falcato wrote:
> On Fri, Oct 23, 2026 at 08:13:56AM -0400, Luiz Capitulino wrote:
>>
>>
>> On 10/23/26 3:16 AM, Vlastimil Babka (SUSE) wrote:
>>> On 10/23/26 04:31, Luiz Capitulino wrote:
>>>> Growing a VM_MIXEDMAP VMA with mremap(), with or without MREMAP_MAYMOVE, fails
>>>> with -ENOMEM when the address range after the VMA is free.
>>>>
>>>> This regression was introduced in v6.1 by commit ca3d76b0aa80 ("mm: add merging
>>>> after mremap resize"). This commit changed mremap() to use vma_merge() instead
>>>> of vma_adjust() for the expansion case. However, vma_merge() returns NULL for
>>>> a VMA that has any of the VM_SPECIAL flags set.
>>>
>>> Hi,
>>>
>>> 6.1 was a rather long time ago. How was it discovered just now? I.e. what
>>> use case broke by the change and prompted creating the reproducer?
>>
>> The use-case that broke was an application running on an older kernel
>> and accessing a GPFS volume/FS. I was told that GPFS sets VM_MIXEDMAP on
> 
> So the application is growing a file VMA with mremap?

To be honest, I don't know because I don't have access to the
application/production environment that reproduced this. I got a
detailed report with debugging information that allowed me to identify
the regression.

I can try to get this information if it's important for what you're
proposing below.

>> a VMA because it inserts pages in the process address space with
>> vm_insert_page(). I then asked an LLM to check if there was anything in
> 
> FWIW this is really odd for a filesystem to do. I see we have two filesystems
> upstream (at least in 7.3) that do this; that is, cramfs and FUSE DAX. This is
> arguably weird and should be fixed. Perhaps the VM side isn't giving
> filesystems the right flag here.
> 


  reply	other threads:[~2026-10-23 18:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-23  2:31 Luiz Capitulino
2026-10-23  7:16 ` Vlastimil Babka (SUSE)
2026-10-23  8:19   ` Lorenzo Stoakes (ARM)
2026-10-23 12:16     ` Luiz Capitulino
2026-10-23 12:13   ` Luiz Capitulino
2026-10-23 13:00     ` Pedro Falcato
2026-10-23 18:16       ` Luiz Capitulino [this message]
2026-10-23  8:18 ` Lorenzo Stoakes (ARM)
2026-10-23 12:15   ` Luiz Capitulino
2026-10-23 14:28     ` Lorenzo Stoakes (ARM)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f49c5d8f-b83a-4b1f-ba91-07eabd0ed46e@redhat.com \
    --to=luizcap@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@kernel.org \
    --cc=jannh@google.com \
    --cc=liam@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=matenajakub@gmail.com \
    --cc=pfalcato@suse.de \
    --cc=vbabka@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®