From: Zhihao Cheng <chengzhihao1@huawei.com>
To: Li Zetao <lizetao1@huawei.com>, <richard@nod.at>,
<Artem.Bityutskiy@nokia.com>, <ext-adrian.hunter@nokia.com>
Cc: <yi.zhang@huawei.com>, <linux-mtd@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ubifs: Fix memory leak in alloc_wbufs()
Date: Mon, 24 Oct 2022 09:31:46 +0800 [thread overview]
Message-ID: <f4a4e992-9efd-b4ca-1788-efe99e4b7d87@huawei.com> (raw)
In-Reply-To: <20221022115211.1969429-1-lizetao1@huawei.com>
在 2022/10/22 19:52, Li Zetao 写道:
> kmemleak reported a sequence of memory leaks, and show them as following:
>
> unreferenced object 0xffff8881575f8400 (size 1024):
> comm "mount", pid 19625, jiffies 4297119604 (age 20.383s)
> hex dump (first 32 bytes):
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> backtrace:
> [<ffffffff8176cecd>] __kmalloc+0x4d/0x150
> [<ffffffffa0406b2b>] ubifs_mount+0x307b/0x7170 [ubifs]
> [<ffffffff819fa8fd>] legacy_get_tree+0xed/0x1d0
> [<ffffffff81936f2d>] vfs_get_tree+0x7d/0x230
> [<ffffffff819b2bd4>] path_mount+0xdd4/0x17b0
> [<ffffffff819b37aa>] __x64_sys_mount+0x1fa/0x270
> [<ffffffff83c14295>] do_syscall_64+0x35/0x80
> [<ffffffff83e0006a>] entry_SYSCALL_64_after_hwframe+0x46/0xb0
>
> unreferenced object 0xffff8881798a6e00 (size 512):
> comm "mount", pid 19677, jiffies 4297121912 (age 37.816s)
> hex dump (first 32 bytes):
> 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk
> 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk
> backtrace:
> [<ffffffff8176cecd>] __kmalloc+0x4d/0x150
> [<ffffffffa0418342>] ubifs_wbuf_init+0x52/0x480 [ubifs]
> [<ffffffffa0406ca5>] ubifs_mount+0x31f5/0x7170 [ubifs]
> [<ffffffff819fa8fd>] legacy_get_tree+0xed/0x1d0
> [<ffffffff81936f2d>] vfs_get_tree+0x7d/0x230
> [<ffffffff819b2bd4>] path_mount+0xdd4/0x17b0
> [<ffffffff819b37aa>] __x64_sys_mount+0x1fa/0x270
> [<ffffffff83c14295>] do_syscall_64+0x35/0x80
> [<ffffffff83e0006a>] entry_SYSCALL_64_after_hwframe+0x46/0xb0
>
> The problem is that the ubifs_wbuf_init() returns an error in the
> loop which in the alloc_wbufs(), then the wbuf->buf and wbuf->inodes
> that were successfully alloced before are not freed.
>
> Fix it by adding error hanging path in alloc_wbufs() which frees
> the memory alloced before when ubifs_wbuf_init() returns an error.
>
> Fixes: 1e51764a3c2a ("UBIFS: add new flash file system")
> Signed-off-by: Li Zetao <lizetao1@huawei.com>
> ---
> fs/ubifs/super.c | 17 +++++++++++++----
> 1 file changed, 13 insertions(+), 4 deletions(-)
Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>
prev parent reply other threads:[~2022-10-24 1:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-22 11:52 Li Zetao
2022-10-24 1:31 ` Zhihao Cheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4a4e992-9efd-b4ca-1788-efe99e4b7d87@huawei.com \
--to=chengzhihao1@huawei.com \
--cc=Artem.Bityutskiy@nokia.com \
--cc=ext-adrian.hunter@nokia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=lizetao1@huawei.com \
--cc=richard@nod.at \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome