From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3186BC0015E for ; Wed, 26 Jul 2023 09:48:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233143AbjGZJsR (ORCPT ); Wed, 26 Jul 2023 05:48:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33526 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233092AbjGZJsP (ORCPT ); Wed, 26 Jul 2023 05:48:15 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B1B197 for ; Wed, 26 Jul 2023 02:48:14 -0700 (PDT) Received: from kwepemm600004.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4R9psF1lGfzNmTw; Wed, 26 Jul 2023 17:44:49 +0800 (CST) Received: from [10.67.103.231] (10.67.103.231) by kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 26 Jul 2023 17:48:11 +0800 Message-ID: Date: Wed, 26 Jul 2023 17:48:10 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH RESEND v3 1/2] soc: hisilicon: Support HCCS driver on Kunpeng SoC To: Randy Dunlap , , , , CC: , , , , , , References: <20230424073020.4039-1-lihuisong@huawei.com> <20230725075706.48939-1-lihuisong@huawei.com> <20230725075706.48939-2-lihuisong@huawei.com> From: "lihuisong (C)" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.231] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemm600004.china.huawei.com (7.193.23.242) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Randy Dunlap, many thanks for reviewing my patch. 在 2023/7/25 23:28, Randy Dunlap 写道: > Hi-- > > On 7/25/23 00:57, Huisong Li wrote: >> diff --git a/drivers/soc/hisilicon/Kconfig b/drivers/soc/hisilicon/Kconfig >> new file mode 100644 >> index 000000000000..87a1f15cbedb >> --- /dev/null >> +++ b/drivers/soc/hisilicon/Kconfig >> @@ -0,0 +1,19 @@ >> +# SPDX-License-Identifier: GPL-2.0-only >> + >> +menu "Hisilicon SoC drivers" >> + depends on ARCH_HISI || COMPILE_TEST >> + >> +config KUNPENG_HCCS >> + tristate "HCCS driver on Kunpeng SoC" >> + depends on ACPI >> + depends on ARM64 || COMPILE_TEST >> + help >> + The Huawei Cache-Coherent System (HCCS) is a bus protocol standard > Just curious: what makes it a standard? HCCS is just a self-defined bus protocol and used for multi-chip interconnection. The description above doesn't seem appropriate. I will fix these releated description in next version. > >> + for ensuring cache coherent on HiSilicon SoC. The performance of > coherence Ack, thanks. > >> + the application may be affected if some hccs ports are in non-full > HCCS HCCS is a bus protocol, it should be all capitals. And hccs port is an abstraction object in code layer here. So maybe it is ok here. what do you think? Best regards, Huisong