From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Martin Kaiser <martin@kaiser.cx>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
Michael Straube <straube.linux@gmail.com>,
Pavel Skripkin <paskripkin@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/17] staging: r8188eu: clean up mlme handlers
Date: Mon, 24 Oct 2022 19:43:07 +0200 [thread overview]
Message-ID: <f4a70a29-4c27-c091-4332-dc476e258b74@gmail.com> (raw)
In-Reply-To: <20221024081417.66441-1-martin@kaiser.cx>
On 10/24/22 10:14, Martin Kaiser wrote:
> This series cleans up the mlme handlers that process incoming management
> frames.
>
> We can reorder the handler functions and remove forward declarations. We
> can also remove unused return values and simplify the error handling.
>
> This series should be applied after the "some more small cleanups" series.
>
> As usual, this series was tested with EdimaxV2 on an arm32 system.
>
> Martin Kaiser (17):
> staging: r8188eu: restructure mlme subfunction handling
> staging: r8188eu: make OnAssocReq static
> staging: r8188eu: make OnAssocRsp static
> staging: r8188eu: make OnProbeReq static
> staging: r8188eu: make OnProbeRsp static
> staging: r8188eu: make OnBeacon static
> staging: r8188eu: make OnDisassoc static
> staging: r8188eu: make OnAuthClient static
> staging: r8188eu: make OnDeAuth static
> staging: r8188eu: make OnAction static
> staging: r8188eu: make OnAuth static
> staging: r8188eu: change mlme handlers to void
> staging: r8188eu: remove unnecessary label
> staging: r8188eu: remove unnecessary else branch
> staging: r8188eu: remove unnecessary return
> staging: r8188eu: remove an else branch
> staging: r8188eu: go2asoc is not needed
>
> drivers/staging/r8188eu/core/rtw_mlme_ext.c | 226 ++++++++----------
> .../staging/r8188eu/include/rtw_mlme_ext.h | 23 +-
> 2 files changed, 100 insertions(+), 149 deletions(-)
>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150
prev parent reply other threads:[~2022-10-24 20:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 8:14 Martin Kaiser
2022-10-24 8:14 ` [PATCH 01/17] staging: r8188eu: restructure mlme subfunction handling Martin Kaiser
2022-10-24 8:14 ` [PATCH 02/17] staging: r8188eu: make OnAssocReq static Martin Kaiser
2022-10-24 8:14 ` [PATCH 03/17] staging: r8188eu: make OnAssocRsp static Martin Kaiser
2022-10-24 8:14 ` [PATCH 04/17] staging: r8188eu: make OnProbeReq static Martin Kaiser
2022-10-24 8:14 ` [PATCH 05/17] staging: r8188eu: make OnProbeRsp static Martin Kaiser
2022-10-24 8:14 ` [PATCH 06/17] staging: r8188eu: make OnBeacon static Martin Kaiser
2022-10-24 8:14 ` [PATCH 07/17] staging: r8188eu: make OnDisassoc static Martin Kaiser
2022-10-24 8:14 ` [PATCH 08/17] staging: r8188eu: make OnAuthClient static Martin Kaiser
2022-10-24 8:14 ` [PATCH 09/17] staging: r8188eu: make OnDeAuth static Martin Kaiser
2022-10-24 8:14 ` [PATCH 10/17] staging: r8188eu: make OnAction static Martin Kaiser
2022-10-24 8:14 ` [PATCH 11/17] staging: r8188eu: make OnAuth static Martin Kaiser
2022-10-24 8:14 ` [PATCH 12/17] staging: r8188eu: change mlme handlers to void Martin Kaiser
2022-10-24 8:14 ` [PATCH 13/17] staging: r8188eu: remove unnecessary label Martin Kaiser
2022-10-24 8:14 ` [PATCH 14/17] staging: r8188eu: remove unnecessary else branch Martin Kaiser
2022-10-24 8:14 ` [PATCH 15/17] staging: r8188eu: remove unnecessary return Martin Kaiser
2022-10-24 8:14 ` [PATCH 16/17] staging: r8188eu: remove an else branch Martin Kaiser
2022-10-24 8:14 ` [PATCH 17/17] staging: r8188eu: go2asoc is not needed Martin Kaiser
2022-10-24 17:43 ` Philipp Hortmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4a70a29-4c27-c091-4332-dc476e258b74@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=martin@kaiser.cx \
--cc=paskripkin@gmail.com \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®