From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933942AbcHDOHx (ORCPT ); Thu, 4 Aug 2016 10:07:53 -0400 Received: from eusmtp01.atmel.com ([212.144.249.242]:42271 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933832AbcHDOHu (ORCPT ); Thu, 4 Aug 2016 10:07:50 -0400 Subject: Re: [RFC PATCH 1/2] net: macb: Correct CAPS mask To: Harini Katakam , , References: <1470036023-22368-1-git-send-email-harinik@xilinx.com> CC: , , , , , "Neil Armstrong" From: Nicolas Ferre Organization: atmel Message-ID: Date: Thu, 4 Aug 2016 16:07:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1470036023-22368-1-git-send-email-harinik@xilinx.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.145.133.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 01/08/2016 à 09:20, Harini Katakam a écrit : > USRIO and JUMBO CAPS have the same mask. > Fix the same. > > Signed-off-by: Harini Katakam Hi, Indeed there's a bug... > --- > drivers/net/ethernet/cadence/macb.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/cadence/macb.h b/drivers/net/ethernet/cadence/macb.h > index 36893d8..b6fcf10 100644 > --- a/drivers/net/ethernet/cadence/macb.h > +++ b/drivers/net/ethernet/cadence/macb.h > @@ -403,11 +403,11 @@ > #define MACB_CAPS_USRIO_DEFAULT_IS_MII_GMII 0x00000004 > #define MACB_CAPS_NO_GIGABIT_HALF 0x00000008 > #define MACB_CAPS_USRIO_DISABLED 0x00000010 > +#define MACB_CAPS_JUMBO 0x00000020 > #define MACB_CAPS_FIFO_MODE 0x10000000 > #define MACB_CAPS_GIGABIT_MODE_AVAILABLE 0x20000000 > #define MACB_CAPS_SG_DISABLED 0x40000000 > #define MACB_CAPS_MACB_IS_GEM 0x80000000 > -#define MACB_CAPS_JUMBO 0x00000010 Acked-by: Nicolas Ferre Can you please send it independently without the RFC tag in the subject and with the following tags in the body as well: Fixes: ce721a702197 ("net: ethernet: cadence-macb: Add disabled usrio caps") Cc: stable@vger.kernel.org # v4.5+ > /* Bit manipulation macros */ > #define MACB_BIT(name) \ > Thanks, bye, -- Nicolas Ferre