From: Zheng Qixing <zhengqixing@huaweicloud.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: song@kernel.org, yukuai@fnnas.com, linan122@huawei.com,
xni@redhat.com, linux-raid@vger.kernel.org,
linux-kernel@vger.kernel.org, yi.zhang@huawei.com,
yangerkun@huawei.com, houtao1@huawei.com,
Zheng Qixing <zhengqixing@huawei.com>
Subject: Re: [RFC v2 0/5] md/raid1: introduce a new sync action to repair badblocks
Date: Wed, 4 Feb 2026 17:29:29 +0800 [thread overview]
Message-ID: <f4aec8a0-0798-4afc-a85a-3fe8afd3433c@huaweicloud.com> (raw)
In-Reply-To: <aYIi1JoZnDMq8rNe@infradead.org>
在 2026/2/4 0:31, Christoph Hellwig 写道:
> On Tue, Feb 03, 2026 at 04:08:23PM +0800, Zheng Qixing wrote:
>> Hi,
>>
>> 在 2026/2/3 15:31, Christoph Hellwig 写道:
>>> Just curious, but what kind of devices do you see that have
>>> permanent bad blocks at a fixed location that are not fixed by
>>> rewriting the sector?
>> The bad_blocks entries record sectors where I/O failed, which
>> indicates that the device-internal remapping did not succeed
>> at that time.
>>
>> `rectify` does not assume a permanently bad or fixed LBA. Its
>> purpose is to trigger an additional rewrite, giving the underlying
>> device (e.g. FTL or firmware) another opportunity to perform its
>> own remapping.
> Well, what devices do you see where writes fail, but rewrites
> fix them?
I understand your concerns, but I do not have a concrete example tied to a specific device model... The intent here is to provide an additional rewrite opportunity, which allows the write path to be exercised again and gives the underlying device or stack a chance to recover or remap the affected range. For remote storage devices, I/O may fail due to network or transport issues. If the final attempt fails, MD can record the affected range in bad_blocks. This behavior does not appear to be tied to a specific device model. For local storage, some controllers may have limitations or corner cases in their remapping mechanisms. In such cases, a sector that could potentially be recovered may be marked as bad, leaving no opportunity for a subsequent successful rewrite.
next prev parent reply other threads:[~2026-02-04 9:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-03 6:12 Zheng Qixing
2026-02-03 6:12 ` [RFC v2 1/5] md: add helpers for requested sync action Zheng Qixing
2026-02-03 6:12 ` [RFC v2 2/5] md: serialize requested sync actions and clear stale request state Zheng Qixing
2026-02-03 6:12 ` [RFC v2 3/5] md: rename mdstat action "recovery" to "recover" Zheng Qixing
2026-02-03 6:12 ` [RFC v2 4/5] md: introduce MAX_RAID_DISKS macro to replace magic number Zheng Qixing
2026-02-03 6:12 ` [RFC v2 5/5] md/raid1: introduce rectify action to repair badblocks Zheng Qixing
2026-02-03 7:31 ` [RFC v2 0/5] md/raid1: introduce a new sync " Christoph Hellwig
2026-02-03 8:08 ` Pascal Hambourg
2026-02-03 16:30 ` Christoph Hellwig
2026-02-03 20:36 ` Pascal Hambourg
2026-02-04 16:59 ` Christoph Hellwig
2026-02-03 8:08 ` Zheng Qixing
2026-02-03 16:31 ` Christoph Hellwig
2026-02-04 9:29 ` Zheng Qixing [this message]
2026-02-04 9:32 ` Zheng Qixing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4aec8a0-0798-4afc-a85a-3fe8afd3433c@huaweicloud.com \
--to=zhengqixing@huaweicloud.com \
--cc=hch@infradead.org \
--cc=houtao1@huawei.com \
--cc=linan122@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=song@kernel.org \
--cc=xni@redhat.com \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai@fnnas.com \
--cc=zhengqixing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®