From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ravi Hothi <ravi.hothi@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Prasad Kumpatla <quic_pkumpatl@quicinc.com>,
Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
Cc: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, ajay.nandam@oss.qualcomm.com
Subject: Re: [PATCH v1] arm64: dts: qcom: qcm6490-idp: Fix WCD9370 reset GPIO polarity
Date: Fri, 20 Feb 2026 11:41:27 +0100 [thread overview]
Message-ID: <f4b207ff-8e21-4738-8e4b-64849d91aba5@kernel.org> (raw)
In-Reply-To: <20260220090220.2992193-1-ravi.hothi@oss.qualcomm.com>
On 20/02/2026 10:02, Ravi Hothi wrote:
> The WCD9370 audio codec reset line on QCM6490 IDP should be active-low, but
> the device tree described it as active-high. As a result, the codec is
> kept in reset and fails to reset the SoundWire, leading to timeouts
> and ASoC card probe failure (-ETIMEDOUT).
>
> Fix the reset GPIO polarity to GPIO_ACTIVE_LOW so the codec can properly
> initialize.
>
> Fixes: aa04c298619f ("arm64: dts: qcom: qcm6490-idp: Add WSA8830 speakers and WCD9370 headset codec")
So above was never tested on mainline.
I fixed the driver in 2251db28edcc70b7ee8a8c6bcbaecf752b3ea5ec, so back
in 2024, thus sound on qcm6490-idp COULD NOT WORK when that DTS change
was posted...
...unless it was developed on downstream.
And a BASIC probe test would discover that - whether device probes
and/or appears in sysfs soundwire bus.
Since basic test would discover it, then I really believe this was done
on some downstream-style clone.
I think this is wider problem with @qualcomm patches.
> Signed-off-by: Ravi Hothi <ravi.hothi@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-02-20 10:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-20 9:02 Ravi Hothi
2026-02-20 9:28 ` Konrad Dybcio
2026-02-20 10:41 ` Krzysztof Kozlowski [this message]
2026-02-23 19:56 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4b207ff-8e21-4738-8e4b-64849d91aba5@kernel.org \
--to=krzk@kernel.org \
--cc=ajay.nandam@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mohammad.rafi.shaik@oss.qualcomm.com \
--cc=quic_pkumpatl@quicinc.com \
--cc=ravi.hothi@oss.qualcomm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®