From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754515AbdKQKgd (ORCPT ); Fri, 17 Nov 2017 05:36:33 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:43849 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750777AbdKQKgX (ORCPT ); Fri, 17 Nov 2017 05:36:23 -0500 X-Google-Smtp-Source: AGs4zMY2UiLgdrU+89jB0UTjXP5YxpfIOTfV5YGq8ORyI1De1IorgaC1d56phbVH7eY9ZOw5bKRlBA== From: Arvind Yadav To: benjamin.gaignard@linaro.org, vincent.abriou@st.com, airlied@linux.ie Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH] drm/sti: Handle return value of platform_get_irq_byname Date: Fri, 17 Nov 2017 16:06:06 +0530 Message-Id: X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org platform_get_irq_byname() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- drivers/gpu/drm/sti/sti_hdmi.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c index 30f02d2..adabd41 100644 --- a/drivers/gpu/drm/sti/sti_hdmi.c +++ b/drivers/gpu/drm/sti/sti_hdmi.c @@ -1414,6 +1414,11 @@ static int sti_hdmi_probe(struct platform_device *pdev) init_waitqueue_head(&hdmi->wait_event); hdmi->irq = platform_get_irq_byname(pdev, "irq"); + if (hdmi->irq < 0) { + DRM_ERROR("Cannot get HDMI irq\n"); + ret = hdmi->irq; + goto release_adapter; + } ret = devm_request_threaded_irq(dev, hdmi->irq, hdmi_irq, hdmi_irq_thread, IRQF_ONESHOT, dev_name(dev), hdmi); -- 2.7.4