From: Hans de Goede <hdegoede@redhat.com>
To: Daniel Beer <daniel.beer@tirotech.co.nz>
Cc: Mark Gross <markgross@kernel.org>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] winmate-fm07-keys: Winmate FM07/FM07P buttons
Date: Tue, 22 Mar 2022 12:28:03 +0100 [thread overview]
Message-ID: <f4b82d3d-5c8b-2973-4918-5308210e4431@redhat.com> (raw)
In-Reply-To: <20220321193258.GA31646@nyquist.nev>
Hi,
On 3/21/22 20:32, Daniel Beer wrote:
> On Mon, Mar 21, 2022 at 11:22:40AM +0100, Hans de Goede wrote:
>> Do you have control of the firmware on this device?
>>
>> If yes then IMHO it would be better to implement this in ACPI
>> using the intel-hid fw API for this, see:
>
> Hi Hans,
>
> Unfortunately not. I don't work for Winmate and they haven't provided
> any documentation on this.
Ok, in that case please send a v2 addressing Barnabás' remarks.
I'll do a full review of v2 and then depending on what I find
merge it, or ask you to do a v3.
Regards,
Hans
next prev parent reply other threads:[~2022-03-22 11:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-21 3:16 Daniel Beer
2022-03-21 10:22 ` Hans de Goede
2022-03-21 19:32 ` Daniel Beer
2022-03-22 11:28 ` Hans de Goede [this message]
2022-03-21 20:13 ` Barnabás Pőcze
2022-03-21 21:53 ` Daniel Beer
2022-03-22 12:34 ` Barnabás Pőcze
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4b82d3d-5c8b-2973-4918-5308210e4431@redhat.com \
--to=hdegoede@redhat.com \
--cc=daniel.beer@tirotech.co.nz \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®