From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 659462D8DA8 for ; Thu, 5 Mar 2026 13:01:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.125.188.123 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772715663; cv=none; b=fRBu2PTDWwAPtY5DEjPYYJ9f7qA8kgBQpdCOfZjNYoVhNpPpwDSxfxEJYlJ77JtRTMmgAiDGUamdPbEQG639hqb2NZ3lev38LYIGoV9nEwhH1w2IXy8nc+sjyEFn4G67gG5lFj5bNNQRJx+5CzncOVeHX6U3+tnhmhfPEYDYacw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772715663; c=relaxed/simple; bh=T4KwmX+nXEALTndUnXHf19Z4vD2t+P4iGNjFjDxxv0Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qrhzedf4LZ0LmnKfdvrciadA7iBZFlWPZZxAUkV20ONQ1da9QMXWTOGdSFCBI2rWsNFjGmnYRzdTT/fozEPC8gHKEofaun33tdbSFW5klVbO+fRvMZBsCVQsWQHn8Mp9BTWVGS0xDJgo1MmyDVN11qix3rwq2DIgI5tzqN6+GHo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=canonical.com; spf=pass smtp.mailfrom=canonical.com; dkim=pass (4096-bit key) header.d=canonical.com header.i=@canonical.com header.b=VGTKwDZj; arc=none smtp.client-ip=185.125.188.123 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=canonical.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=canonical.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=canonical.com header.i=@canonical.com header.b="VGTKwDZj" Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id AFE903F863 for ; Thu, 5 Mar 2026 13:00:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20251003; t=1772715653; bh=AwP4BhYIWaYYtzi0hBUxp/zG8QUjl+08i0ub1kRdEPI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VGTKwDZjs+VyA1CbFKlRSt8fI4+j3+wUQssZbxDy+zF44hYWhJIQRkJpiLuIn8rM2 ip29ch2fMgXkpj+AjAwdeEtOYt4jIPgiCSmJzG0TN3IbSNk1/1gJ77hhIG+ViacKJX 3iQsdsouaQW0+c9+Xw/ak4XCi/jN8DrzCIt1CUXJHw4fRq4YWFfydG/wduMpQ172M2 hD7XpF9knXHg3ehQPmuEwa9AWulAQE2oIzUNA8ugn9JldGjZWsJMnq3JeRAE8FQH6W K2D2GVL806G3iJrWbFc1CMlQYl44Fdm9JimrcwlY4TjDPk/l1aweMLPM2U59SIPUnS Xp/Z7mpdvVhvKQMf64RXYu/rUKe26vPsu56QJ6SX8XrfYgxcDhYylgXGplmxiMNmL8 +jq5+46wajDvxGdReAtyy3R01NPNNXR/TqJMuQbSX+YysyIM0BuRnvXqfcJXAG6W8G 2/W6daYYVUy89vdOgiu1UDnVqLAk7U62qBTsfd3j69mw56iTRX6Q4IClEJUEUoEVx8 CBeWNAs7wAMpJqlxQ8uQbKBx0ZEbXNgeLrM5/xmISCwztQMXtQ3u+j4LRDCNyO3cuf A2Km0qz7V/rWI9SKzg+osh8aK1GyY+aPm7kEOTxNMCuODPWlDsX+/n+fOgwYZVP1Z/ si8w2aOqZtThamrARoEJ5P6o= Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-483a2db68caso65809095e9.0 for ; Thu, 05 Mar 2026 05:00:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772715653; x=1773320453; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AwP4BhYIWaYYtzi0hBUxp/zG8QUjl+08i0ub1kRdEPI=; b=QbReo9dA5QEM8eBDD+yapPpeILoQxZiXcGij4JwUybZcQ6K635B0UnENwtJ8ZhFKmV c9wTJjTP1w7mmrT7vjP8t0+TwlZgNKVxWZVwLuzHFdk1MxlcgoHC+R2Qt4sHvZRSRyB6 7LKoWxbIHoFnrv1gPOf6X7od1/mEhpUu0eMUvL+eqDnXB0ym+DNEFXY30vp+bmaVlJyy vE6drnyYTFg23HD1AU/Dlvsx+4l34U94dQ8rOWcvTmWzffikJvGf8EcViidY53+h4MhW PMoDFEtqYmGKPeD3Gi31A84NBZU9wTXDu9vlilW5wnurmVhEjGT8nGY1Qk6UGuiy6za9 TwFw== X-Gm-Message-State: AOJu0YyteH3ixCbHuz/dDSpsmz748/J2DYdDfAnsCmsw22ZxePDorM7s cHUy+frxzTzSa4gQx3DDytaJkxEknm5xP1vQkVDNcagGtI+0qVTvQALo5RxK2zwb2ZtK9FNkLsv KHv3WrTIEQaCjocWKRXbN3XY5iM8g2SRma1nvZwfaS4qOVcOmf33sM4T5kXu2gpicvBTf+mnsHl aQ5vRpow== X-Gm-Gg: ATEYQzwnS1W1ZYt8curu5FO6a4n4+F/LMtjyT1m3xOWtQa4TJObatKbslA0QWq+UZEZ j5IIWDZ76GfFmJa79vry+dDcNUs+EUWmKU3AG93tUgU9tba4FUjA/4xVmIht9K1iXnCgevgsmzs yZMsxPvgRln96eWeelTq3ytteJmOCT0vMg9uVuwFsFWK7ItevbS8au9mMZ9NnAdr5EYqKezs9zS ObFexWaZL0AczP1j8DPLQCjcHpmeTYkeAehDbFoCCUnXp2yoEbTEiHarnScTEonHbvlR5kiGVTn tv4GX1CeHAT2UxDF7C4bQebxyBn9pebgOxah1O4hinf9LIXw7G/aYaIGRi5k4fgHzU096FEhSO7 jKGGZvt65SVcDd0DchXe7gzCk28h5VtosiwiQhrXTBvhii+NKre+Yh79Zc6sR9Z3vWR2ossQ4ej 3p0WBHfQ3+6T/IRoerJQfvP8oTBW6N3t0WQ5ehLH0rMtTMlNdZ/XI= X-Received: by 2002:a05:600c:64ce:b0:477:7925:f7fb with SMTP id 5b1f17b1804b1-485198608e9mr100891305e9.10.1772715653175; Thu, 05 Mar 2026 05:00:53 -0800 (PST) X-Received: by 2002:a05:600c:64ce:b0:477:7925:f7fb with SMTP id 5b1f17b1804b1-485198608e9mr100890655e9.10.1772715652709; Thu, 05 Mar 2026 05:00:52 -0800 (PST) Received: from [192.168.103.129] (ip-005-147-080-091.um06.pools.vodafone-ip.de. [5.147.80.91]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439c1fc577bsm19363148f8f.19.2026.03.05.05.00.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Mar 2026 05:00:52 -0800 (PST) Message-ID: Date: Thu, 5 Mar 2026 14:00:50 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] riscv: acpi: update FADT revision check to 6.6 To: "rom.wang" Cc: linux-kernel@vger.kernel.org, Yufeng Wang , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Conor Dooley , Ryan Roberts , Sean Chang , Anshuman Khandual , linux-riscv@lists.infradead.org References: <20260305091433.83983-1-r4o5m6e8o@163.com> Content-Language: en-US From: Heinrich Schuchardt In-Reply-To: <20260305091433.83983-1-r4o5m6e8o@163.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/5/26 10:14, rom.wang wrote: > From: Yufeng Wang > > ACPI 6.6 is required for RISC-V as it introduces RISC-V specific > tables such as RHCT (RISC-V Hart Capabilities Table) and > RIMT (RISC-V I/O Mapping Table). > > Update the FADT revision check from 6.5 to 6.6 and remove > the TODO comment since ACPI 6.6 has been officially released. If I understand the change correctly: After the patch QEMU v10.0.0 will stop to boot Linux via ACPI. QEMU v10.1.0 will be supported as it indicates revision 6.6. See function build_fadt_rev6() in qemu/hw/riscv/virt-acpi-build.c. For Ubuntu this is not an issue as it is on QEMU 10.1 on recent releases (https://launchpad.net/ubuntu/+source/qemu). Fedora 43 also has QEMU 10.1 (https://packages.fedoraproject.org/pkgs/qemu/qemu/). Suse Tumbleweed has 10.2.1 (https://software.opensuse.org/package/qemu). Stable Debian Trixie using 10.0 will be impacted (https://packages.debian.org/trixie/qemu-system-misc). Debian Testing has 10.2. Acked-by: Heinrich Schuchardt > > Signed-off-by: Yufeng Wang > --- > arch/riscv/kernel/acpi.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/arch/riscv/kernel/acpi.c b/arch/riscv/kernel/acpi.c > index 71698ee11621..ff681db9f4f1 100644 > --- a/arch/riscv/kernel/acpi.c > +++ b/arch/riscv/kernel/acpi.c > @@ -85,12 +85,12 @@ static int __init acpi_fadt_sanity_check(void) > * The revision in the table header is the FADT's Major revision. The > * FADT also has a minor revision, which is stored in the FADT itself. > * > - * TODO: Currently, we check for 6.5 as the minimum version to check > - * for HW_REDUCED flag. However, once RISC-V updates are released in > - * the ACPI spec, we need to update this check for exact minor revision > + * ACPI 6.6 is required for RISC-V as it introduces RISC-V specific > + * tables such as RHCT (RISC-V Hart Capabilities Table) and RIMT > + * (RISC-V I/O Mapping Table). > */ > - if (table->revision < 6 || (table->revision == 6 && fadt->minor_revision < 5)) > - pr_err(FW_BUG "Unsupported FADT revision %d.%d, should be 6.5+\n", > + if (table->revision < 6 || (table->revision == 6 && fadt->minor_revision < 6)) > + pr_err(FW_BUG "Unsupported FADT revision %d.%d, should be 6.6+\n", > table->revision, fadt->minor_revision); > > if (!(fadt->flags & ACPI_FADT_HW_REDUCED)) {