From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05D6DC77B7A for ; Wed, 7 Jun 2023 18:53:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233065AbjFGSxY (ORCPT ); Wed, 7 Jun 2023 14:53:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232822AbjFGSxT (ORCPT ); Wed, 7 Jun 2023 14:53:19 -0400 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA9181BD2; Wed, 7 Jun 2023 11:53:18 -0700 (PDT) Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-25690e009c8so3329874a91.0; Wed, 07 Jun 2023 11:53:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686163998; x=1688755998; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Q6P+PAKNYbxbNX9E/3+E3k8i/1DJ/ZptAnSElYZPC90=; b=gMD9WBezapKm5Y0uzKdtaHj/aG76WXW7AObFIh6S8CNq7n6F/ZWuJw0RCG8hM9+rHL ErzfZiLkmcs/jnd64i0lUmukB7l5qYceVo6s6nDDGlpp1pWBwi6r+tJuqhlJvc97oxEb t8xRZbSfRpgd3cipyB4GsEFZf8959cx4c47WOYUJf2FgHRghK0zGmuSOinFQNHjzs+1X ZFdPOQycMx9kngRW6lzq9hKc/aii+v2HsJVTdzoogTh1uMc6DSZ2Jr/JdsN0BBn5EYtP eb/PETxfmXgFkzOFyr+o9Y1i8bMlsQGzJaklV0UVMa01WDflvc0nJ4ukJHHMbTSgKnji U2tA== X-Gm-Message-State: AC+VfDy4PsH2kkIU2DhJ9sP+O6nlbkJXFYkz1CXEQXz2/k4/oWduNztd 72oPXftVH2D1XWdWEhaX3sQ= X-Google-Smtp-Source: ACHHUZ4tvgf/SYreGGwIqMKu8RQ+3loY5ft/f2mlHs/IZpTz9Nd8VNpsJCFYywsrM8L8QcBuHj31Ig== X-Received: by 2002:a17:90a:49cc:b0:259:a879:cb8f with SMTP id l12-20020a17090a49cc00b00259a879cb8fmr2226855pjm.7.1686163998206; Wed, 07 Jun 2023 11:53:18 -0700 (PDT) Received: from [192.168.51.14] ([98.51.102.78]) by smtp.gmail.com with ESMTPSA id cm14-20020a17090afa0e00b00256799877ffsm1653239pjb.47.2023.06.07.11.53.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Jun 2023 11:53:17 -0700 (PDT) Message-ID: Date: Wed, 7 Jun 2023 11:53:16 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2] ufs: core: Combine ufshcd_mq_poll_cqe functions Content-Language: en-US To: Stanley Chu , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, martin.petersen@oracle.com, avri.altman@wdc.com, alim.akhtar@samsung.com, jejb@linux.ibm.com References: <20230601225048.12228-1-stanley.chu@mediatek.com> From: Bart Van Assche In-Reply-To: <20230601225048.12228-1-stanley.chu@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/1/23 15:50, Stanley Chu wrote: > Currently, ufshcd_mcq_poll_cqe_nolock() is only called by > ufshcd_mcq_poll_cqe_lock() with the addition of a spinlock wrapper > for ufshcd_mcq_poll_cqe_nolock(). Combining these two functions > into one would result in cleaner code. For future patches, please use the imperative mood for the patch description ("would result in" -> "results in"). Additionally, a follow-up patch that renames ufshcd_mcq_poll_cqe_lock() into ufshcd_mcq_poll_cqe() would be welcome. Anyway: Reviewed-by: Bart Van Assche