From: "Huang, Kai" <kai.huang@intel.com>
To: "pbonzini@redhat.com" <pbonzini@redhat.com>,
"seanjc@google.com" <seanjc@google.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] KVM: x86/mmu: Bug the VM, not the host kernel, if KVM write-protects upper SPTEs
Date: Fri, 19 Jun 2026 04:40:26 +0000 [thread overview]
Message-ID: <f4bb68a798408d2147046462ab2cca99f024842b.camel@intel.com> (raw)
In-Reply-To: <20260618185641.2022368-1-seanjc@google.com>
On Thu, 2026-06-18 at 11:56 -0700, Sean Christopherson wrote:
> WARN and terminate the VM if KVM attempts to write-protect non-leaf SPTEs
> instead of bugging the host kernel, as there is no reason to bring down the
> entire host. Even termininating the VM is likely overkill, but in theory a
> missed write could corrupt guest memory, so play it safe.
>
> Signed-off-by: Sean Christopherson <seanjc@google.com>
I wondered a bit whether the BUG_ON() was for checking "non-leaf SPTEs". I.e.,
maybe "write-protect the level which cannot have any leaf SPTE" reflects better,
but perhaps they are the same thing.
Reviewed-by: Kai Huang <kai.huang@intel.com>
next prev parent reply other threads:[~2026-06-19 4:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-18 18:56 Sean Christopherson
2026-06-19 4:40 ` Huang, Kai [this message]
2026-06-24 9:28 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4bb68a798408d2147046462ab2cca99f024842b.camel@intel.com \
--to=kai.huang@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®