From: Frank Wang <frank.wang@rock-chips.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org,
sebastian.reichel@collabora.com, heiko@sntech.de,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rockchip@lists.infradead.org, huangtao@rock-chips.com,
william.wu@rock-chips.com, jianwei.zheng@rock-chips.com,
yubing.zhang@rock-chips.com, wmc@rock-chips.com
Subject: Re: usb: typec: tcpm: fix cc role at port reset
Date: Fri, 16 Jun 2023 11:03:14 +0800 [thread overview]
Message-ID: <f4bc4e7e-b9d4-432b-2157-f5b30c160a3a@rock-chips.com> (raw)
In-Reply-To: <3c3fbecd-caf9-c432-0890-93cceade98c1@roeck-us.net>
Hi Guenter,
On 2023/6/16 10:27, Guenter Roeck wrote:
> On 6/15/23 19:20, Frank Wang wrote:
>> In the current implementation, the tcpm set CC1/CC2 role to open when
>> it do port reset would cause the VBUS removed by the Type-C partner.
>>
>> This sets CC1/CC2 according to the default state of port to fix it.
>>
>> Comments are suggested by Guenter Roeck.
>>
>
> I have no idea (recollection) of what I suggested here :-(
Aha, this is also an old patch I have sent before, you suggested that
the cc role should require some tweaking based on the port type or
default state, do you remember it now?
Anyway, Can you help to review this patch again?
BR.
Frank
>
> Guenter
>
>> Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
>> ---
>> drivers/usb/typec/tcpm/tcpm.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/typec/tcpm/tcpm.c
>> b/drivers/usb/typec/tcpm/tcpm.c
>> index 3c6b0c8e2d3ae..9f6aaa3e70ca8 100644
>> --- a/drivers/usb/typec/tcpm/tcpm.c
>> +++ b/drivers/usb/typec/tcpm/tcpm.c
>> @@ -4885,7 +4885,8 @@ static void run_state_machine(struct tcpm_port
>> *port)
>> break;
>> case PORT_RESET:
>> tcpm_reset_port(port);
>> - tcpm_set_cc(port, TYPEC_CC_OPEN);
>> + tcpm_set_cc(port, tcpm_default_state(port) == SNK_UNATTACHED ?
>> + TYPEC_CC_RD : tcpm_rp_cc(port));
>> tcpm_set_state(port, PORT_RESET_WAIT_OFF,
>> PD_T_ERROR_RECOVERY);
>> break;
>
next prev parent reply other threads:[~2023-06-16 3:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-16 2:20 Frank Wang
2023-06-16 2:27 ` Guenter Roeck
2023-06-16 3:03 ` Frank Wang [this message]
2023-06-16 6:06 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4bc4e7e-b9d4-432b-2157-f5b30c160a3a@rock-chips.com \
--to=frank.wang@rock-chips.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=jianwei.zheng@rock-chips.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=sebastian.reichel@collabora.com \
--cc=william.wu@rock-chips.com \
--cc=wmc@rock-chips.com \
--cc=yubing.zhang@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®