From: Andrew Lunn <andrew@lunn.ch>
To: Justin Lai <justinlai0215@realtek.com>
Cc: "kuba@kernel.org" <kuba@kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Ping-Ke Shih <pkshih@realtek.com>,
Larry Chiu <larry.chiu@realtek.com>
Subject: Re: [PATCH net-next v9 08/13] net:ethernet:realtek:rtase: Implement net_device_ops
Date: Fri, 6 Oct 2023 15:44:18 +0200 [thread overview]
Message-ID: <f4bcf3e9-d059-4403-a2b7-508806da9631@lunn.ch> (raw)
In-Reply-To: <99dfcd7363dc412f877730fab4a9f7dd@realtek.com>
> > > +static void rtase_tx_timeout(struct net_device *dev, unsigned int
> > > +txqueue) {
> > > + rtase_sw_reset(dev);
> >
> > Do you actually see this happening? The timeout is set pretty high, i think 5
> > seconds. If it does happen, it probably means you have a hardware/firmware
> > bug. So you want to be noisy here, so you get to know about these problems,
> > rather than silently work around them.
>
> I would like to ask if we can dump some information that will help
> us understand the cause of the problem before doing the reset? And
> should we use netdev_warn to print this information?
You might want to look at 'devlink health'.
Andrew
next prev parent reply other threads:[~2023-10-06 13:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 10:49 [PATCH net-next v9 00/13] Add Realtek automotive PCIe driver Justin Lai
2023-09-28 10:49 ` [PATCH net-next v9 01/13] net:ethernet:realtek:rtase: Add pci table supported in this module Justin Lai
2023-09-28 10:49 ` [PATCH net-next v9 02/13] net:ethernet:realtek:rtase: Implement the .ndo_open function Justin Lai
2023-09-28 12:57 ` Andrew Lunn
2023-10-03 12:40 ` Justin Lai
2023-09-28 10:49 ` [PATCH net-next v9 03/13] net:ethernet:realtek:rtase: Implement the rtase_down function Justin Lai
2023-09-28 10:49 ` [PATCH net-next v9 04/13] net:ethernet:realtek:rtase: Implement the interrupt routine and rtase_poll Justin Lai
2023-09-28 10:49 ` [PATCH net-next v9 05/13] net:ethernet:realtek:rtase: Implement hardware configuration function Justin Lai
2023-09-28 10:49 ` [PATCH net-next v9 06/13] net:ethernet:realtek:rtase: Implement .ndo_start_xmit function Justin Lai
2023-09-28 10:49 ` [PATCH net-next v9 07/13] net:ethernet:realtek:rtase: Implement a function to receive packets Justin Lai
2023-09-28 10:49 ` [PATCH net-next v9 08/13] net:ethernet:realtek:rtase: Implement net_device_ops Justin Lai
2023-09-28 14:02 ` Andrew Lunn
2023-10-06 4:02 ` Justin Lai
2023-10-06 13:44 ` Andrew Lunn [this message]
2023-10-16 1:49 ` Justin Lai
2023-09-28 10:49 ` [PATCH net-next v9 09/13] net:ethernet:realtek:rtase: Implement pci_driver suspend and resume function Justin Lai
2023-09-28 10:49 ` [PATCH net-next v9 10/13] net:ethernet:realtek:rtase: Implement ethtool function Justin Lai
2023-09-28 10:49 ` [PATCH net-next v9 11/13] net:ethernet:realtek:rtase: Add a Makefile in the rtase folder Justin Lai
2023-09-28 10:49 ` [PATCH net-next v9 12/13] net:ethernet:realtek: Update the Makefile and Kconfig in the realtek folder Justin Lai
2023-09-28 21:00 ` kernel test robot
2023-10-04 23:47 ` kernel test robot
2023-09-28 10:49 ` [PATCH net-next v9 13/13] MAINTAINERS: Add the rtase ethernet driver entry Justin Lai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4bcf3e9-d059-4403-a2b7-508806da9631@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=justinlai0215@realtek.com \
--cc=kuba@kernel.org \
--cc=larry.chiu@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®