From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73A9DC64ED8 for ; Mon, 27 Feb 2023 18:43:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230056AbjB0Snc (ORCPT ); Mon, 27 Feb 2023 13:43:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229595AbjB0Sna (ORCPT ); Mon, 27 Feb 2023 13:43:30 -0500 Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E37326AE; Mon, 27 Feb 2023 10:43:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ZIN4RUa47JWixv+iKRFDKHEww2SYThdo5L1ZrUf4BrI=; b=mYIfTSJGhbbyJuL7F2bcXQipOd VMT54s64OyCYw+8M0aTqMRIVnTpskim2lfe1gLCN2Gtdt16OQ1i+CMgasv1azSXv3vl8CDayZkcvS 9cjtEMRpWpgrqcM/UIq7Y1cmZS1EnI5nc7nCVuea2taxGz/Zm+krtDBR+7V/j2vBimolZsO663PBF Vt0iyE58nI37tPYybkrZNKAIehi0E667MYbsqMmIk8jsBCfn26iXOm8zu182epbyNLZ/IrDfkhW04 hm0O5FcTsYp4exEyhh3Tbc/8orabVGz7QjhE/A4M1/e1W/gowQGPMOD07AqA5ifEex/U56MiI/HAp Kn0gwdnA==; Received: from [152.254.196.162] (helo=[192.168.1.60]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1pWiT6-00H0De-Pv; Mon, 27 Feb 2023 19:43:25 +0100 Message-ID: Date: Mon, 27 Feb 2023 15:43:16 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] soc: bcm: brcmstb: Remove bare-metal ARM suspend/resume code Content-Language: en-US To: Florian Fainelli , linux-arm-kernel@vger.kernel.org Cc: drv@mailo.com, ssengar@microsoft.com, kumarpraveen@linux.microsoft.com, christophe.jaillet@wanadoo.fr, Broadcom internal kernel review list , Nick Desaulniers , "Russell King (Oracle)" , Arnd Bergmann , Miaoqian Lin , Liang He , Andy Shevchenko , Julia Lawall , open list , "moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" References: <20230224215249.239405-1-f.fainelli@gmail.com> <421678cb-6ec0-903c-a84b-c833f013815d@igalia.com> <35dc0b00-0de4-f1b4-8d43-7efd181e7dbf@gmail.com> From: "Guilherme G. Piccoli" In-Reply-To: <35dc0b00-0de4-f1b4-8d43-7efd181e7dbf@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/02/2023 15:38, Florian Fainelli wrote: > [...] >>> -static int brcmstb_pm_panic_notify(struct notifier_block *nb, >>> - unsigned long action, void *data) >>> -{ >>> - writel_relaxed(BRCMSTB_PANIC_MAGIC, ctrl.aon_sram + AON_REG_PANIC); >>> - >>> - return NOTIFY_DONE; >>> [...] >> >> Hi Florian, thanks for the clean-up! >> >> I'm curious with the above panic notifier - is it not necessary when >> PSCI is used? > > This is a bit of long story, but no, it is not necessary. OK then heh Glad for the clean-up!