Re: [PATCH] spi: zynq-qspi: Replace kzalloc with kmalloc for buffer allocation

[Michal Simek <michal.simek@amd.com>]

On 8/14/24 21:28, Kuan-Wei Chiu wrote:
> In zynq_qspi_exec_mem_op(), the temporary buffer is allocated with
> kzalloc and then immediately initialized using memset to 0xff. To
> optimize this, replace kzalloc with kmalloc, as the zeroing operation
> is redundant and unnecessary.
> 
> Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
> ---
> Note: Build test only.
> 
>   drivers/spi/spi-zynq-qspi.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi-zynq-qspi.c b/drivers/spi/spi-zynq-qspi.c
> index d6325c6be3d4..b67455bda972 100644
> --- a/drivers/spi/spi-zynq-qspi.c
> +++ b/drivers/spi/spi-zynq-qspi.c
> @@ -569,7 +569,7 @@ static int zynq_qspi_exec_mem_op(struct spi_mem *mem,
>   	}
>   
>   	if (op->dummy.nbytes) {
> -		tmpbuf = kzalloc(op->dummy.nbytes, GFP_KERNEL);
> +		tmpbuf = kmalloc(op->dummy.nbytes, GFP_KERNEL);
>   		if (!tmpbuf)
>   			return -ENOMEM;
>   

Reviewed-by: Michal Simek <michal.simek@amd.com>

Thanks,
Michal