From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 780CC37F72C for ; Sat, 1 Aug 2026 22:01:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785621685; cv=none; b=WdpjJ7mO3tYy0Ls/6zWUGBcdt/A1UEjYlHq68oGzHP3uy9Y7eodWKysC2LazOLQPJSFiZsL0Y5TvOo1f4jWYr4ELMJx0CG33bA7Cz7l1kD92qXq8PxNQOO+vmugFJK8ujxgLYyS3ZGUprcxyNXWTtMhoCZZTCbx05x5fBcWvTuc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785621685; c=relaxed/simple; bh=0GZwqUy172rmUBMrDMV2vQcxlGBw18Y+h2pa3/xDLGE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rgNG01n2r0UEAIRYoAzl4zp+yU0Fg8iVZsOpbd03zWrLOPl36uMYURx1e3Az4e/rwcum04JOx3BhxbzvXJdINYWD6V9aN97ocH6Th4q+5Fwd8jzxuJtFJBw9wuBGafgJmrOXKRxBdHkMl7KRGHH4fUb2HRCXwGzZ4cAVBx/SaCQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BSZ8BYZc; arc=none smtp.client-ip=209.85.128.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BSZ8BYZc" Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-80bb41f7f3cso21508057b3.2 for ; Sat, 01 Aug 2026 15:01:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785621681; x=1786226481; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ZTD9K6oObS45hnhRjtGbn2SpngZimROJJDwLscvqzbo=; b=BSZ8BYZcRcxM3awTw2IR7SZiL43EtkPRP/HJP4UPaqugzYvhfLH137ZE2fnZ/yXFQo Bj6/x4uvRE2rZOtNaBO730T8RAOfYjuV6Dk5k3ywMABH++Kyeg6iAx701bEzkaxAijCd vklhSZJe346aVtPeUcqtK6v1X3c+q4a97+cCSwSYcQxHEL99Z6N+bHK0QmnAFcQjU0bA m1qWp4jkg0aC52mVVoCDl47RDlm8EfFS13z6UIoWvyopX9vJ9lF8GqmSQL8KWCktQnFK xRteSSXvUrUGEZWpk4iY5sXR0zGBZhnJjmgwG9TZcxuRYcxXHIgbaWWD7SgUkh/5tZ6W OIKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785621681; x=1786226481; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=ZTD9K6oObS45hnhRjtGbn2SpngZimROJJDwLscvqzbo=; b=LjmPZtDGwy3flLtWyo/dgKM8lBSkQd6dRkPEUTs88PNITg8Y9ULIwiF0g3X3l47eIh r/VfsUfMG/wOnwvvN0hme886t5XYmwxbfpJLUXL8Bj8EhVuNUAtr/XU5RrPkPm9IU+XV wLtDEHLH7CSIbaqXJFW4nd7FmaSjJKJS5NFnyzwIjtkOfAF77whKZxU7kem8x8JcXY8z zYBWK0s64B9bmGaeXVwZIP3jGltSZnhLWU5epDWBvQbuo2Stsdmjw2rubux/xQkgYEli C4nqdYN5CJxu1UtVq6sTsMDcnXjh8eUT4n+Jn56TBq9p43mHZLFnFeiMmdoHwDGUfXz+ wuVw== X-Forwarded-Encrypted: i=1; AHgh+Rqu8VMTUEAZdJ+CQAmzJJB3IHOuRjWAMrWiW+EKs4DYG7Ctaz0d0fAQAr9tGivHrF1pxby/f6q6r+f0Wrs=@vger.kernel.org X-Gm-Message-State: AOJu0YxpWscIYZAH4FhLHWtN9Yc0UR74LzaeMmUgti2HlKyl5AoXGP+U V+bfsMY/0yHhjRvhvMJISsNVQZlK39vIRwPtZzOyrc2CHjyZHfzlkYiw X-Gm-Gg: AR+sD13ls3kSSYYbb6xt3QHt4hHmsCnAXNI9ZbanxmlYAGFXwysd6y9yC7IO5CluEae 5a6vCxPIfpUOmnMseuigcUbRRSnNk7J9gKxfibqmzadZ78sskWXhm5Pv0mp5f/vdWzPuzUQijf+ 4limcz+bi+8gRWYrZMFK4uJyYEIodxoJbpAKizH8dXMq8UIBpfA1YUu/Ly029t6dl5SX3A+qVqx 3KIvZ8xZSnuwRbPZyu8dcMW2wvY4FCi/CCfR8DX3x5WA3FH0jEpJZX+0ufdOGCVxwJPkJTwaxpW 99GVj84dGRUbJ1V6MCcBtJO7MOmLRYEjEw3mFSQoyDUczWhqFvmjwm7ffs8h3KjJlIb/pIdgjX0 TmIJdhuV32m9B5KV1zGbiFF+ss2mCSzEe9CtQbrWJPpBSC1uIcfszp0cjhLObYGA/sPZOIMszI/ RZCgoI4sW1tFjuy72OV4xqscUZRLUKWoLmJUKJArYrO/r2qQb1/us7P27IUHwYKQnEnuH+iFCTX nRSVgY= X-Received: by 2002:a05:690c:6ac9:b0:81e:ae6d:caed with SMTP id 00721157ae682-81fd4bf66c7mr72228817b3.34.1785621680760; Sat, 01 Aug 2026 15:01:20 -0700 (PDT) Received: from syssplab.cs.fiu.edu (nat1.cs.fiu.edu. [131.94.134.89]) by smtp.gmail.com with ESMTPSA id 00721157ae682-81fcd0d6fbbsm29903767b3.25.2026.08.01.15.01.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Aug 2026 15:01:20 -0700 (PDT) From: Chao Shi To: Jan Kara , Christian Brauner , Alexander Viro , Matthew Wilcox , linux-fsdevel@vger.kernel.org Cc: Theodore Ts'o , Andreas Dilger , Baokun Li , Ojaswin Mujoo , Ritesh Harjani , Zhang Yi , Bob Copeland , Namjae Jeon , Sungjong Seo , Yuezhang Mo , OGAWA Hirofumi , Mark Fasheh , Joel Becker , Joseph Qi , Andreas Gruenbacher , linux-ext4@vger.kernel.org, ocfs2-devel@lists.linux.dev, gfs2@lists.linux.dev, linux-karma-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Chao Shi Subject: [PATCH 08/19] ext2: check for an xattr block write error with buffer_write_io_error() Date: Sat, 1 Aug 2026 18:00:52 -0400 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ext2_xattr_set2() spots a failed synchronous write by testing BH_Req together with !BH_Uptodate. That relies on the write completion handler clearing BH_Uptodate on error, which this series removes: a buffer whose write failed still holds the data the filesystem asked to be written, so declaring it not up to date is wrong and makes callers re-read it. BH_Write_EIO says exactly what this code wants to know, and it implies BH_Req, so the pair collapses into one test. No behaviour change today - a failed write sets BH_Write_EIO and clears BH_Uptodate together. It stops being a no-op at the end of the series, where the new test is the one that still works. Signed-off-by: Chao Shi --- fs/ext2/xattr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ext2/xattr.c b/fs/ext2/xattr.c index be63f89402a3..39005ec23fe5 100644 --- a/fs/ext2/xattr.c +++ b/fs/ext2/xattr.c @@ -769,7 +769,7 @@ ext2_xattr_set2(struct inode *inode, struct buffer_head *old_bh, if (IS_SYNC(inode)) { sync_dirty_buffer(new_bh); error = -EIO; - if (buffer_req(new_bh) && !buffer_uptodate(new_bh)) + if (buffer_write_io_error(new_bh)) goto cleanup; } } -- 2.43.0