From: Dan Murphy <dmurphy@ti.com>
To: Martin Fuzzey <martin.fuzzey@flowbird.group>,
<jacek.anaszewski@gmail.com>, <pavel@ucw.cz>
Cc: <linux-leds@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v16 04/19] leds: multicolor: Introduce a multicolor class definition
Date: Thu, 14 Nov 2019 06:56:23 -0600 [thread overview]
Message-ID: <f4c891b6-3ce7-c3d7-447a-7633b96face1@ti.com> (raw)
In-Reply-To: <a7f18f3b-c1fb-3810-8d9b-30ecdada96ff@flowbird.group>
Martin
On 11/14/19 5:24 AM, Martin Fuzzey wrote:
> Hi Dan,
>
> On 04/11/2019 13:36, Dan Murphy wrote:
>> +int devm_led_classdev_multicolor_register_ext(struct device *parent,
>> + struct led_classdev_mc *mcled_cdev,
>> + struct led_init_data *init_data)
>> +{
>> + struct led_classdev_mc **dr;
>> + int ret;
>> +
>> + dr = devres_alloc(devm_led_classdev_multicolor_release,
>> + sizeof(*dr), GFP_KERNEL);
>> + if (!dr)
>> + return -ENOMEM;
>> +
>> + ret = led_classdev_multicolor_register(parent, mcled_cdev);
>
>
> This drops init_data, should be led_classdev_multicolor_register_ex
>
Thanks for the issue I will fix and send v17
Dan
next prev parent reply other threads:[~2019-11-14 12:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 12:36 [PATCH v16 00/19] Multicolor Framework Dan Murphy
2019-11-04 12:36 ` [PATCH v16 01/19] dt: bindings: Add multicolor class dt bindings documention Dan Murphy
2019-11-04 12:36 ` [PATCH v16 02/19] dt-bindings: leds: Add multicolor ID to the color ID list Dan Murphy
2019-11-04 12:36 ` [PATCH v16 03/19] " Dan Murphy
2019-11-04 12:36 ` [PATCH v16 04/19] leds: multicolor: Introduce a multicolor class definition Dan Murphy
2019-11-14 11:24 ` Martin Fuzzey
2019-11-14 12:56 ` Dan Murphy [this message]
2019-11-04 12:36 ` [PATCH v16 05/19] dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers Dan Murphy
2019-11-04 12:36 ` [PATCH v16 06/19] leds: lp50xx: Add the LP50XX family of the RGB LED driver Dan Murphy
2019-11-04 12:36 ` [PATCH v16 07/19] dt: bindings: lp55xx: Be consistent in the document with LED acronym Dan Murphy
2019-11-04 12:36 ` [PATCH v16 08/19] dt: bindings: lp55xx: Update binding for Multicolor Framework Dan Murphy
2019-11-04 12:36 ` [PATCH v16 09/19] ARM: dts: n900: Add reg property to the LP5523 channel node Dan Murphy
2019-11-04 12:36 ` [PATCH v16 10/19] ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 " Dan Murphy
2019-11-04 12:36 ` [PATCH v16 11/19] ARM: dts: ste-href: Add reg property to the LP5521 channel nodes Dan Murphy
2019-11-04 12:37 ` [PATCH v16 12/19] leds: lp55xx: Convert LED class registration to devm_* Dan Murphy
2019-11-04 12:37 ` [PATCH v16 13/19] leds: lp55xx: Add multicolor framework support to lp55xx Dan Murphy
2019-11-04 12:37 ` [PATCH v16 14/19] leds: lp5523: Update the lp5523 code to add multicolor brightness function Dan Murphy
2019-11-04 12:37 ` [PATCH v16 15/19] leds: lp5521: Add multicolor framework multicolor brightness support Dan Murphy
2019-11-04 12:37 ` [PATCH v16 16/19] leds: lp55xx: Fix checkpatch file permissions issues Dan Murphy
2019-11-04 12:37 ` [PATCH v16 17/19] leds: lp5523: Fix checkpatch issues in the code Dan Murphy
2019-11-04 12:37 ` [PATCH v16 18/19] dt: bindings: Update lp55xx binding to recommended LED naming Dan Murphy
2019-11-04 12:37 ` [PATCH v16 19/19] leds: lp55xx-common: Remove extern from lp55xx-common header Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4c891b6-3ce7-c3d7-447a-7633b96face1@ti.com \
--to=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=martin.fuzzey@flowbird.group \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®